Author |
Topic |
DavidRhodes
Senior Member
United Kingdom
1222 Posts |
Posted - 28 July 2003 : 15:31:46
|
admin_links.asp line 142 replace chkSelect(strLMRating,1) with chkSelect(strLMRating,2)
The help text to add to pop_config_help.asp has not been included< |
The UK MkIVs Forum |
|
|
DavidRhodes
Senior Member
United Kingdom
1222 Posts |
Posted - 28 July 2003 : 16:00:21
|
using sql server found the error as above when language is off
similar error also when banners are off when editing
Microsoft OLE DB Provider for SQL Server (0x80040E14)
Line 1: Incorrect syntax near ','.
/forum/links.asp, line 1127 < |
The UK MkIVs Forum |
|
|
aspwiz
Junior Member
250 Posts |
Posted - 28 July 2003 : 16:09:35
|
Can I just say that when a board is using this MOD and allows guest submissions, then it may be wise to look at this article as the MOD described would be a very wise addition to this MOD.
see This Topic for more details.
I am still trying to get my head round the code to make this possible and if anyone can help, I and I'm sure anyone else who values their search engine rankings will greatly appreciate it.
Regards,
Rob< |
|
|
DavidRhodes
Senior Member
United Kingdom
1222 Posts |
Posted - 28 July 2003 : 16:18:44
|
guest submissions require approval though so may not be much of an issue as links within the forum itself< |
The UK MkIVs Forum |
|
|
aspwiz
Junior Member
250 Posts |
Posted - 28 July 2003 : 16:25:55
|
I realise that.... but manual research of each link is still a pain in the a** though, right?
Rob< |
|
|
AWD_ENVY
Junior Member
103 Posts |
Posted - 28 July 2003 : 16:58:35
|
quote: Originally posted by aspwiz
Can I just say that when a board is using this MOD and allows guest submissions, then it may be wise to look at this article as the MOD described would be a very wise addition to this MOD.
see This Topic for more details.
I am still trying to get my head round the code to make this possible and if anyone can help, I and I'm sure anyone else who values their search engine rankings will greatly appreciate it.
Regards,
Rob
In my opinion, if you're worried about search engine rank, you should remove the forum directory from "robots.txt". Most things that are valueble to surfers are not the forum, but the other things in the site. The forum is more of an "Add on" or Bonus in my book. I have really good ratings with Google, MSN, & Yahoo.... & I don't share my ANYTHING in my forum directory with the spiders.< |
|
|
OneWayMule
Dev. Team Member & Support Moderator
Austria
4969 Posts |
Posted - 28 July 2003 : 17:55:29
|
quote: I am getting an error when inserting - the SQL does not have a value for the language - I have Language turned off so it is not asked on the form so I guess a default is not being set
Fixed.
quote: Just noticed this http://www.onewaymule.org/onewayscripts/lm3/links.asp?action=showsubcat&id=24 Clicking 'open in new window' opens in the same window
Fixed.
quote: admin_links.asp line 142 replace chkSelect(strLMRating,1) with chkSelect(strLMRating,2)
Fixed.
quote: The help text to add to pop_config_help.asp has not been included
Fixed.
quote: using sql server found the error as above when language is off
similar error also when banners are off when editing
Microsoft OLE DB Provider for SQL Server (0x80040E14) Line 1: Incorrect syntax near ','. /forum/links.asp, line 1127
Fixed.
quote: I realise that.... but manual research of each link is still a pain in the a** though, right?
It is recommended that you check out a site before you approve it; you don't want to link to a site with *bad content*, do you?
quote: Just a Heads-Up for MySQL users....
In the links table, there is a field called "SHOW".... this is reserved in MySQL. I renamed it as well as all references to "SHOWLINK", and it works fine.
Yes, this was already a problem with LM2. I'm not sure how I'll solve this; I don't want to release a extra MOd for MySQL users, it will be available as one package. I could include some code to the dbs file to drop the SHOW table and create a SHOWLINKS table. (The problem would be - a default value of 0 would mean you'll have to approve all your links again) Let me know what you think about this.
Oh, and thank you all for your bug reports, you're great!
I have updated the zip file, please re-download and replace all files from the zip with the new ones. The instructions on how to add the code to pop_config_help.asp are now included in the readme.< |
My MODs: Birthdays - Custom Policy - F.A.Q. Administration - Forum Rules - Guestbook Links Manager - MyOwnGoogle - Profile Views - Search Log - WebSearch
Useful stuff: Forum and MOD Installation - MOD Installation Guide - Snitz v3.4.05 Readme - Free ASP Hosts - Support Snitz
|
|
|
AWD_ENVY
Junior Member
103 Posts |
Posted - 28 July 2003 : 18:04:06
|
Found another issue in "Links.asp" with MySQL...
I have banners turned off, and this creates an issue when I go to edit a link. The "strFormBannerSize" seems to be returning a null value, so to correct for this I did the following.
On Links.asp on APROX line: 1124
Right Before: strsql = strsql & "BANNER_SIZE=" & strFormBannerSize & ", "
I put: IF strFormBannerSize = "" or strFormBannerSize < 1 THEN strFormBannerSize = 0 END IF
So that it now looks like: IF strFormBannerSize = "" or strFormBannerSize < 1 THEN strFormBannerSize = 0 END IF strsql = strsql & "BANNER_SIZE=" & strFormBannerSize & ", "
This seemed to fix all issues with updating.... I've updated the ZIP file that I posted for fellow MySQL users as well.< |
|
|
OneWayMule
Dev. Team Member & Support Moderator
Austria
4969 Posts |
|
OneWayMule
Dev. Team Member & Support Moderator
Austria
4969 Posts |
|
borge
Junior Member
Norway
185 Posts |
Posted - 29 July 2003 : 13:00:45
|
OneWayMule
Thanks for the updates to the files! It is really a nice mod. You told me to remind you concerning an include file so that the "Categories & Subcategories" table on the links.asp page could be included on the default.asp page. I would really like to display that table in the footer (or on the inc_site_left.asp from the site integration mod), or another place on the default.asp page. It would be a nice add on I think.< |
borge |
|
|
DavidRhodes
Senior Member
United Kingdom
1222 Posts |
Posted - 29 July 2003 : 13:55:31
|
Couple of minor bugs: links.asp, when editing links If you don't change the language and leave as is, it says you must enter a language even though there aleady is one and it says "edtit/approve links" < |
The UK MkIVs Forum |
Edited by - DavidRhodes on 29 July 2003 13:56:02 |
|
|
AWD_ENVY
Junior Member
103 Posts |
Posted - 29 July 2003 : 14:34:45
|
Found another small issue. For people that re-configure the Cookie's ID, the below lines will have issues.
Line 69 in "pop_links.asp":
ORIGINAL : If getMemberID(Request.Cookies("Snitz00User")("Name")) = rs("RATE_BY") Then EDITED: If getMemberID(Request.Cookies(strUniqueID & "User")("Name")) = rs("RATE_BY") Then
Line 114 & 115 in "pop_links.asp": ORIGINAL : If Request.Cookies("Snitz00User")("Name") <> "" Then strMName = Request.Cookies("Snitz00User")("Name") EDITED: If Request.Cookies(strUniqueID & "User")("Name") <> "" Then strMName = Request.Cookies(strUniqueID & "User")("Name") < |
|
|
OneWayMule
Dev. Team Member & Support Moderator
Austria
4969 Posts |
Posted - 29 July 2003 : 17:23:24
|
quote: Thanks for the updates to the files! It is really a nice mod. You told me to remind you concerning an include file so that the "Categories & Subcategories" table on the links.asp page could be included on the default.asp page. I would really like to display that table in the footer (or on the inc_site_left.asp from the site integration mod), or another place on the default.asp page. It would be a nice add on I think.
I have not forgotten your request, it's on my list!
quote: Couple of minor bugs: links.asp, when editing links If you don't change the language and leave as is, it says you must enter a language even though there aleady is one
Fixed.
quote: and it says "edtit/approve links"
Fixed. Also, the "/Approve" is now only shown when the user is either an admin or a moderator.
quote: Found another small issue. For people that re-configure the Cookie's ID, the below lines will have issues...
Fixed. Seems I have forgotten to replace
Request.Cookies(strUniqueID & "User")("Name") with
strDBNTUsername (as defined in inc_header.asp) in this file. Sorry!
Files updated in the zip file as well as on the test forum.< |
My MODs: Birthdays - Custom Policy - F.A.Q. Administration - Forum Rules - Guestbook Links Manager - MyOwnGoogle - Profile Views - Search Log - WebSearch
Useful stuff: Forum and MOD Installation - MOD Installation Guide - Snitz v3.4.05 Readme - Free ASP Hosts - Support Snitz
|
|
|
DavidRhodes
Senior Member
United Kingdom
1222 Posts |
Posted - 30 July 2003 : 08:20:45
|
Bug: When 'Accept New Links' is on, Admin users can't add links!!< |
The UK MkIVs Forum |
|
|
Topic |
|