Author |
Topic |
MarkJH
Senior Member
United Kingdom
1722 Posts |
|
PPSSWeb
Junior Member
312 Posts |
Posted - 31 October 2007 : 08:34:31
|
quote: Originally posted by MarkJH
All pop up windows on my forum seem to work fine, Steve.
Thanks for confirming this as a non MOD related issue. If anyone has any ideas as to why this would be happening when this mod is added and not when it is removed, please let me know. < |
|
|
Etymon
Advanced Member
United States
2385 Posts |
Posted - 31 October 2007 : 11:20:04
|
quote: Originally posted by MarkJH
All pop up windows on my forum seem to work fine, Steve.
I viewed your site using FireFox and the MOD works as expected.< |
|
|
PPSSWeb
Junior Member
312 Posts |
Posted - 01 November 2007 : 09:52:04
|
I found the error I was having as detailed above. I originally did not notice that there was no close script tag on the line above.
When I insert this line instead, all works fin:
'#####################Smooth Scroller##########################################
Response.Write "<script src=""js/smooth.pack.js"" type=""text/javascript""></script>"
'#####################End Smooth Scroller###################################### < |
Edited by - PPSSWeb on 01 November 2007 10:28:18 |
|
|
PPSSWeb
Junior Member
312 Posts |
Posted - 01 November 2007 : 13:21:24
|
I believe I have fixed the issue with this MOD and Proeder's File Attachment MOD.
Problem. The the links for the file upload just didn't do anything when this mod is installed.
Cause: This mod hunts down all href instances that contain an '#' assuming that they are all anchors. Unfortunately, the links to the upload function for Proeder's also contain this character.
Solution: The '#' character appears at end of the string for the Proeder's links and in the middle for normal anchors. Adding a check in the javascript to exclude instances where the '#' appears at the end of the string fixes the issue.
In smooth-src-comments.js change line 79 from:
To:
Then modify the link in inc_header.asp to use this file instead.
This works for my setup, so hopefully it will help others to use this really cool script.< |
|
|
balexandre
Junior Member
Denmark
418 Posts |
Posted - 01 November 2007 : 13:58:59
|
good catch, now everyone can have their users flying to the top < |
Bruno Alexandre (Strøby, DANMARK)
"a Portuguese in Danmark"
|
|
|
Lon
Starting Member
USA
47 Posts |
Posted - 21 December 2007 : 12:01:35
|
I too use the Proeder's File Attachment MOD and I made this MOD corrections, however when the user clicks on the paperclip, the page scrolls.....
If I remove the line in inc_header.asp, the Proeder's File Attachment MOD works fine.
Just checking to see if anyone else has this issue or just me?< |
|
|
PPSSWeb
Junior Member
312 Posts |
Posted - 24 December 2007 : 09:30:50
|
quote: Originally posted by Lon
I too use the Proeder's File Attachment MOD and I made this MOD corrections, however when the user clicks on the paperclip, the page scrolls.....
If I remove the line in inc_header.asp, the Proeder's File Attachment MOD works fine.
Just checking to see if anyone else has this issue or just me?
Did you make both of the changes detailed in my posts above?< |
|
|
Lon
Starting Member
USA
47 Posts |
Posted - 24 December 2007 : 10:32:39
|
Yes, I have made both the above changes. It is a cool MOD, however the ability to upload is more important.< |
|
|
PPSSWeb
Junior Member
312 Posts |
Posted - 24 December 2007 : 11:20:22
|
quote: Originally posted by Lon
Yes, I have made both the above changes. It is a cool MOD, however the ability to upload is more important.
I agree it is very cool. I got them both to work together with the changes above though. The first fixed the issue with the popup windows and the second with the paperclip button performing a scroll instead of opening the upload page.
If you changed the line in the file smooth-src-comments.js to the fixed one above and are pointing to that file in inc_header.asp instead of the original, than I am not sure what the problem could be off hand. If you want to send me those two files, I can look at them and compare to my own working versions.< |
|
|
Lon
Starting Member
USA
47 Posts |
Posted - 24 December 2007 : 15:29:56
|
Ok, I think I understand now. My inc_header.asp still had "smooth.pack.js" in it. I thought that is what you were trying to say until I read this whole topic word-for-word again. I replaced that with "smooth-src-comments.js" and it seems to work now. WOW! Sometimes I can be hard-headed. < |
|
|
balexandre
Junior Member
Denmark
418 Posts |
Posted - 05 March 2008 : 09:35:23
|
< |
Bruno Alexandre (Strøby, DANMARK)
"a Portuguese in Danmark"
|
|
|
leatherlips
Senior Member
USA
1838 Posts |
|
balexandre
Junior Member
Denmark
418 Posts |
Posted - 22 March 2008 : 14:46:10
|
it's easy...
download the forum and see the file
but to make it simple, it's below all the javascript include files that you find, right before the <body> tag
< |
Bruno Alexandre (Strøby, DANMARK)
"a Portuguese in Danmark"
|
|
|
leatherlips
Senior Member
USA
1838 Posts |
|
Topic |
|