| Author |
 Topic  |
|
Aaron S.
Average Member
USA
985 Posts |
 Posted - 20 April 2002 : 10:25:50
|
Looking at my Recent Topics in my profile, I noticed that it was not correctly showing the last 10 posts that I made.
I am trying to decipher the SQL string to see what the exact problem is so it can be fixed. If anyone knows, please post.
Additionally, I noticed that it is pulling back the entire recordset and then only keeping 10 records. This seems pretty expensive (especially for high volume posters).
You could add "SELECT TOP 10" at the beginning of the SQL statement to have the Db just return the first 10 records. Is this supported by MySql?
--Aaron
MySubs Email MOD
MOD to Smile Mgr
HotKeys MOD
Edited by - aaron s. on 20 April 2002 17:34:58 |
|
|
ruirib
Snitz Forums Admin
Portugal
26364 Posts |
Posted - 20 April 2002 : 10:49:15
|
quote:
You could add "SELECT TOP 10" at the beginning of the SQL statement to have the Db just return the first 10 records. Is this supported by MySql?
No it is not. I guess the sintax for MySQL should be LIMIT 10 at the end of the SQL instruction.
-------------------------------------------------
Installation Guide | Do's and Dont's | MODs |
 |
|
|
Aaron S.
Average Member
USA
985 Posts |
Posted - 20 April 2002 : 11:12:26
|
As of this post my Recent Topics has the following dates:
20 April 2002 : 10:25:50
20 April 2002 : 10:17:42
19 April 2002 : 14:53:29
18 April 2002 : 22:16:37
18 April 2002 : 21:39:29
17 April 2002 : 22:23:32
17 April 2002 : 15:59:42
17 April 2002 : 14:12:23
17 April 2002 : 13:41:02
05 April 2002 : 21:26:38
BUT doing a simple search shows that I had ADDITIONAL posts with these dates (and many others, this is a sample):
16 April 2002 : 10:20:02
12 April 2002 : 11:36:12
11 April 2002 : 11:22:31
11 April 2002 : 09:32:49
11 April 2002 : 00:22:37
07 April 2002 : 14:13:52
These should all come above the April 5th listing.
I think this is because it is using LAST_POST instead of R_DATE and T_DATE to find the most recent.
--Aaron
MySubs Email MOD
MOD to Smile Mgr
HotKeys MOD |
|
|
|
Aaron S.
Average Member
USA
985 Posts |
Posted - 20 April 2002 : 11:28:06
|
Ok... right now it is ordering by LAST_POST... so it could show a topic on your RECENT TOPICS list that you haven't posted to for years as long as someone else posted to it recently.
What the code should do is:
1. include REPLY.R_DATE and TOPICS.T_DATE in the SELECT statement
2. do a getrows() so it can put the information into an array
3. sort the array by REPLY.R_DATE and TOPICS.T_DATE
4. display the first 10 records (from 0 to 9)
In this case, you cannot use TOP 10 or LIMIT 10 because the data will be unsorted.
Another option would be to put the date into a temporary table and then sort the information, but that seem more expensive than the first option.
--Aaron
MySubs Email MOD
MOD to Smile Mgr
HotKeys MOD |
|
|
|
RichardKinser
Snitz Forums Admin
USA
16655 Posts |
Posted - 20 April 2002 : 14:07:42
|
It shows the last 10 topics that have been active where you have posted in. That is what it is supposed to do.
So if you posted in a message a year ago and someone just posted in it, making it active again, then yes, it's going to show in that list again.
That is how it was designed.
Gor explained this in a post about a year or 2 ago, just can't find it right now.... |
|
|
|
Aaron S.
Average Member
USA
985 Posts |
Posted - 20 April 2002 : 16:27:17
|
IMHO this is not what RECENT TOPICS would mean to the average visitor looking at someone's profile.
The profile is mainly used for OTHERS to view information about YOU(including where you have most recently posted).
Subscriptions and bookmarks are for YOU to track topics that are of interest to YOU (which is what RECENT TOPICS is useful for now).
In other words, it is designed to do what was spec'ed, but I think the spec is wrong for the purpose of that page.
BUT, if y'all think it is designed properly and shouldn't be changed then I'll just make a MOD for anyone else who thinks it's funky.
--Aaron
MySubs Email MOD
MOD to Smile Mgr
HotKeys MOD
Edited by - aaron s. on 20 April 2002 16:32:27 |
|
|
|
ruirib
Snitz Forums Admin
Portugal
26364 Posts |
Posted - 20 April 2002 : 16:53:38
|
Well I kinda been thinking that it would be interesting to have a link from your profile where you could access all the topics where you posted. It wouldn't even be necessary to change the current profile. I would just add a link to a personal post list, from the profile page.
This personal page could have a drop-down limiting the time for the posts to be displayed, just like in topic.asp. It would then show all the topics where you may have posted, using page navigation, like topic.asp also.
I should have already done if I weren't so lazy starting new things...
So, Aaron what you think? If you want we can share some of the burden of development, although this doesn't seem too complicated... It would be nice to do it to support Internationalization.
-------------------------------------------------
Installation Guide | Do's and Dont's | MODs |
|
|
|
Nathan
Help Moderator
USA
7664 Posts |
Posted - 20 April 2002 : 17:03:23
|
Sounds like a good mod Ruirib. . . if you need help let me know.
 Nathan Bales
Snitz Exchange | Do's and Dont's
Edited by - Nathan on 20 April 2002 17:03:47 |
|
|
|
Aaron S.
Average Member
USA
985 Posts |
Posted - 20 April 2002 : 17:16:06
|
Ruirib (and Nathan):
I'll have the basic function finished in a few minutes... I'll post that and then you can internationalize it and stuff into a formatting template similar to active.asp or whatever.
--Aaron
MySubs Email MOD
MOD to Smile Mgr
HotKeys MOD |
|
|
|
Nathan
Help Moderator
USA
7664 Posts |
Posted - 20 April 2002 : 17:29:26
|
Since this has turned into a mod thread, could it be renamed and moved to the Mods w/o code forum???
Nathan Bales
Snitz Exchange | Do's and Dont's |
|
|
|
ruirib
Snitz Forums Admin
Portugal
26364 Posts |
Posted - 20 April 2002 : 17:32:53
|
Ok guys, let's do it. Let's wait for Aaron's code and we pick it up from there...
-------------------------------------------------
Installation Guide | Do's and Dont's | MODs |
|
|
|
RichardKinser
Snitz Forums Admin
USA
16655 Posts |
Posted - 20 April 2002 : 18:08:09
|
We have already added the ability to search for all posts by a user in v3.4...
It just involved adding a link to inc_profile.asp and then a few modifications to search.asp...
Here is a sneak peek:
(I know, looks just like the way that phpBB2 looks.) |
|
|
|
ruirib
Snitz Forums Admin
Portugal
26364 Posts |
Posted - 20 April 2002 : 18:22:31
|
Well Richard, you just killed my first mod right before it was born  (just joking   ).
I guess this only adds to the anxiety over version 3.4 release...
What about adding paging to search.asp?
Usually it's not very important but if you post a lot likely searching for your posts can return a large number of them...
-------------------------------------------------
Installation Guide | Do's and Dont's | MODs |
|
|
|
RichardKinser
Snitz Forums Admin
USA
16655 Posts |
Posted - 20 April 2002 : 18:25:40
|
| Why not go ahead and do it? I'm sure there are people who would like that functionality right now (not to mention those who won't upgrade to v3.4 for one reason or another), I was just letting you know that it was a feature in v3.4.. |
|
|
|
RichardKinser
Snitz Forums Admin
USA
16655 Posts |
Posted - 20 April 2002 : 18:30:53
|
| btw... I moved this to MOD Add-On Forum (W/O Code) |
|
|
|
ruirib
Snitz Forums Admin
Portugal
26364 Posts |
Posted - 20 April 2002 : 18:35:22
|
Well, some of your remarks are correctly, specially those related to the users that won't be upgrading to 3.4.
A downside to your post is that it seems to imply that 3.4 won't be released as soon as that...
Well, I guess I'll have a look at it. Your suggestion to start with search.asp does seem to diminish the effort necessary to do it, anyway.
-------------------------------------------------
Installation Guide | Do's and Dont's | MODs |
|
|
|
Topic |
|
Topic Locked
