| Author |
 Topic  |
|
laser
Advanced Member
Australia
3859 Posts |
 Posted - 19 November 2004 : 07:40:54
|
OK, I know I'm using 3.4.03 with most of the security patches applied. I know I've played with the code in quite a lot of places , but I hope to only post problems I see with the base code.
Feel free to correct me, and this is a work in progress, so I will be editting this post a lot to add extra info (but don't expect line numbers  ).
config.asp :
set rsConfig = Nothing
needed just before :
LoadModConfig()
post_info.asp :
set rs2 = Nothing
needed just after :
rs2.close
in the sub "DoAutoMoveEmail" |
|
|
HuwR
Forum Admin
United Kingdom
20584 Posts |
Posted - 19 November 2004 : 08:20:40
|
1)This forum is for reporting Bugs in the Snitz base code, not for problems with your MODS, loadmodconfig is not par of Snitz base code
2)why, rs2 is only used in DoAutoMoveEmail, not setting it to nothing isn't a BUG, and actually doesn't make any difference under IIS, as it is done automatically. |
 |
|
|
laser
Advanced Member
Australia
3859 Posts |
Posted - 19 November 2004 : 09:24:24
|
1) Fair enough, but I did say "but I hope to only post problems I see with the base code" - my mistake obviously. (Please move this thread to a more suitable forum if required)
2) What's done automatically ? I'm currently experiencing some stability problems with the forums (only recent change was moving to a new server), and I was advised that not setting all objects to Nothing was a problem that I needed to correct ASAP
3) Applying the theory in 2), the line "set Server2 = Server" appears 3 times, only to alter the ScriptTimeout value. |
|
|
|
HuwR
Forum Admin
United Kingdom
20584 Posts |
Posted - 19 November 2004 : 15:13:15
|
when the ASP page has finished, any objects created during the life of that page will automatically be released by Active Scripting, so it is not strictly necesary to do so yourself, unless your pages are taking a very long time to load.
quote:
I'm currently experiencing some stability problems with the forums (only recent change was moving to a new server), and I was advised that not setting all objects to Nothing was a problem that I needed to correct ASAP
That is a cop out which basically means your site is sat on a server with several hundred other sites and therfore has barely enough resources to squish a flea.
Also, the function in question is only ever used when you move a topic and if you have the topic move notification turned on, so unless you move several thousand topics a day it will have virtually no effect whatsoever on the servers resources. |
|
|
|
Gremlin
General Help Moderator
New Zealand
7528 Posts |
Posted - 19 November 2004 : 17:32:56
|
quote:
That is a cop out which basically means your site is sat on a server with several hundred other sites and therfore has barely enough resources to squish a flea.
I'll tell you for a fact there aren't any resource issue on the server.
laser's site is regularly once every 48-72 hours killing it's application pool and needs to be manually recylced, it's the only site on the server having these problems and I'm 99.9% confident that it's code related (it's also using more memory than any other site as well). It's interesting to note we weren't seeing these issues under W2K, under W2K3 Access based forums seem to be a lot less reliable.
In general, when a page used to create a recordset goes out of scope (meaning the asp page is completely parsed), the recordset is destroyed. However, It is not considered good practice to wait for this event to occur before you destroy a recordset that is no longer in use and I would think you of all people Huw wouldn't be recommending to someone bad coding practices. |
Kiwihosting.Net - The Forum Hosting Specialists
|
Edited by - Gremlin on 19 November 2004 17:51:11 |
|
|
|
HuwR
Forum Admin
United Kingdom
20584 Posts |
Posted - 19 November 2004 : 17:45:03
|
| a sites memory useage does not nesecarily indicate it has a code problem, it may just be very busy, I can also assure you both that Snitz would not cause this, I host a lot of snitz forums, some do use large amounts of ram >200mb but none of them cause IIS to crash ever. |
|
|
|
HuwR
Forum Admin
United Kingdom
20584 Posts |
Posted - 19 November 2004 : 17:47:53
|
quote:
However, It is not considered good practice to wait for this event to occur before you destroy a recordset that is no longer in use and I would think you of all people Huw wouldn't be recommending to someone bad coding practices.
I'm not, but like I said unless he is moving several thousand topics a day that piece of code will have a negligable effect if any. |
|
|
|
Gremlin
General Help Moderator
New Zealand
7528 Posts |
Posted - 19 November 2004 : 17:53:09
|
Agree about that piece of code, but I think thats just been the tip of the iceberg in Lasers case, I did say to him if he found any objects in base code not destroyed that he should probably post them here becuase I thought you'd like to know about them.
I don't believe it Snitz core code causing the problem, this server has 5 very very high volume snitz sites on it which are all without mods applied vs lasers which does have mods so you can see where I was heading with asking him to check out his objects. |
Kiwihosting.Net - The Forum Hosting Specialists
|
Edited by - Gremlin on 19 November 2004 17:57:39 |
|
|
|
laser
Advanced Member
Australia
3859 Posts |
Posted - 19 November 2004 : 18:23:36
|
Yes, the code in question will only be run on the very odd occassion. Topics moving forums would average 1/month MAYBE, and none on this server.
The config.asp problem would be more important. The rsConfig is closed, but never set to Nothing.
Also, while we're on the Gremlin issue, is just seems to down the ASP Server. I can still render plain HTML, GIFs, anything, but ASP extensions - no way  . When the application pool is reset, everything works until the next time it goes down.
|
|
|
|
HuwR
Forum Admin
United Kingdom
20584 Posts |
Posted - 19 November 2004 : 18:41:58
|
quote:
Also, while we're on the Gremlin issue, is just seems to down the ASP Server. I can still render plain HTML, GIFs, anything, but ASP extensions - no way . When the application pool is reset, everything works until the next time it goes down.
that is because asp and html are run by a different process.
quote:
The config.asp problem would be more important. The rsConfig is closed, but never set to Nothing.
Also not a problem, if you look at the code carefully rsconfig is only instantiated during a setup process, it is not instantiated every time config.asp loads, so there is nothing to free up anyway as it hasn't been created.
|
|
|
|
laser
Advanced Member
Australia
3859 Posts |
Posted - 19 November 2004 : 19:01:27
|
quote:
that is because asp and html are run by a different process.
I understand that, just mentioning it in case it's the lead someone need to solve my greater problem then.
quote:
Also not a problem
Fair enough then, just thought you'd like to know about these problems though. I'm trying to note potential problems in the code so they can be fixed, simple as that.
No sinister motives here  |
|
|
|
RichardKinser
Snitz Forums Admin
USA
16655 Posts |
Posted - 19 November 2004 : 19:23:42
|
| moving this to DEV Discussions (General) for now, so y'all can discuss this without us having to approve each new message. |
|
|
|
Gargoyle
Junior Member
USA
280 Posts |
Posted - 19 November 2004 : 22:58:48
|
I hate to chime in like this as I know very little about hosting and what it requires. But I did have a similar issue with an access database, a fully modded SHN forum, and a hosting provider using windows 2003 servers.
In the end the only real solution was to move it back to a windows 2000 server as the windows 2003 server just flat out could not handle my site. And I only got about 500 page hits a day. So I am hoping that my past experience will help Laser come to a quick solution.
BTW.... We spent about 6 months trying to fix it before I moved my site back to a win2k server. Ever since the move back I have had ZERO problems.  |
Here is a link to my Snitz powered Drag Racing site. |
|
|
|
Gremlin
General Help Moderator
New Zealand
7528 Posts |
Posted - 19 November 2004 : 23:52:15
|
| We have snitz sites on the same server getting 10's of thousands of hits per day that haven't failed once, MS Access I know we've had problems with and we're converting to MSSQL sometime soon, but having objects not being closed does't help any either. |
Kiwihosting.Net - The Forum Hosting Specialists
|
|
|
|
HuwR
Forum Admin
United Kingdom
20584 Posts |
Posted - 20 November 2004 : 04:09:06
|
| the two objects mentioned by laser are opened so seldom that they would not cause a problem. The first is ONLY opened when setup.asp is run, the second according to laser maybe once a month, that is not going to cause a crash. |
|
|
|
Da_Stimulator
DEV Team Forum Moderator
USA
3373 Posts |
Posted - 20 November 2004 : 04:10:25
|
| So whats the big difference between 2k3 and 2k thats causing an issue? |
-Stim |
|
|
|
Topic |
|
Topic Locked
