| Author |
 Topic  |
|
Nikkol
Forum Moderator
USA
6907 Posts |
 Posted - 10 February 2004 : 16:36:33
|
| okay, this isn't something that I'm going to be able to work on any time soon. If anyone wants to take over revisions for the new version ... feel free! |
Nikkol ~ Help Us Help You | ReadMe | 3.4.03 fixes | security fixes ~ |
 |
|
|
ajhvdb
Junior Member
Netherlands
392 Posts |
Posted - 10 February 2004 : 18:21:26
|
Well you did such a great job documenting this Mod that it will be a pain updating it 
I've done the upgrade to 3.4.04 and for now i can say that your installation instructions still hold up. Only some linenumbers are a little bit different. The only part missing to make it work in 3.4.04 is below:
File: inc_func_secure.asp
Find the following code:function chkForumAccessNew(fPrivateForums,fFPasswordNew,fForum_Subject,fForum_ID,UserNum)
if MemberID = UserNum then
if mLev < 1 then
chkForumAccessNew = false
elseif mLev = 3 then
chkForumAccessNew = true
elseif mLev = 4 then
chkForumAccessNew = true
exit function
end if
end if
dim Users
dim MatchFound
Change it to:function chkForumAccessNew(fPrivateForums,fFPasswordNew,fForum_Subject,fForum_ID,UserNum)
if MemberID = UserNum then
if mLev < 1 then
chkForumAccessNew = false
elseif mLev = 3 then
chkForumAccessNew = true
elseif mLev = 4 then
chkForumAccessNew = true
exit function
end if
end if
'####### Begin UserGroup MOD #######
if isDeniedMember(fForum_ID, UserNum) = 1 then
chkForumAccessNew = false
exit function
end if
'####### End UserGroup MOD #######
dim Users
dim MatchFound
|
|
|
|
miperez
Junior Member
Spain
243 Posts |
Posted - 12 February 2004 : 06:35:02
|
Thanks, ajhvdb.
I have still a problem in my forum, though. If I set the permission for a Forum and a group to "Read-only", when a member os that group logs in he doesn't see the forum at all.
Have you tried this? Is it a problem with the MOD and version 3.4.04 or maybe I have made some mistake applying the MOD? |
Best Regards
Mikel Perez
"Hell is the place where everything test perfectly, and nothing works"
|
|
|
|
ajhvdb
Junior Member
Netherlands
392 Posts |
Posted - 12 February 2004 : 06:49:36
|
| I can test it.. what is the setting "Auth Type" for your forum? |
|
|
|
miperez
Junior Member
Spain
243 Posts |
Posted - 12 February 2004 : 06:58:08
|
| It is "Allowed member list (hidden)" |
Best Regards
Mikel Perez
"Hell is the place where everything test perfectly, and nothing works"
|
|
|
|
ajhvdb
Junior Member
Netherlands
392 Posts |
Posted - 12 February 2004 : 09:27:24
|
| Ok, i've done some testing and don't see the read-only forum. But before saying it's a bug someone (nikkol) needs to test this with the old version. |
|
|
|
miperez
Junior Member
Spain
243 Posts |
Posted - 12 February 2004 : 09:49:39
|
Hi, ajhvdb and all.
I had an older version of my forum (3.4.03), that I used for prototyping and presentation purposes before downloading the new one (3.4.04) that I'd like to upload to production servers soon.
So, I have created a virtual directory that points to the old forum, and made the test. I had four forums, so I have created a group and assign a member to that group. Here are the results:
Auth type, as before, is set to Allowed member list (hidden).
Forum Permissions Result
----- ----------- ------
Forum1 Do not set Not seen --> Is this correct?
Forum2 Allow Seen properly
Forum3 Deny Not seen
Forum4 Read-only Not seen --> Incorrect
So it seems that it is not caused by the new forum version, but by something in the MOD itself. |
Best Regards
Mikel Perez
"Hell is the place where everything test perfectly, and nothing works"
|
|
|
|
miperez
Junior Member
Spain
243 Posts |
Posted - 12 February 2004 : 10:04:32
|
| BTW, thanks for your help and your time, ajhvdb |
Best Regards
Mikel Perez
"Hell is the place where everything test perfectly, and nothing works"
|
|
|
|
Nikkol
Forum Moderator
USA
6907 Posts |
Posted - 12 February 2004 : 11:39:41
|
| I think the original intention of the read only was to permit members to read a forum, but not post. it should work this way if you set the auth type to all visitors. ... if you change the auth type, can you see it then? |
Nikkol ~ Help Us Help You | ReadMe | 3.4.03 fixes | security fixes ~ |
|
|
|
miperez
Junior Member
Spain
243 Posts |
Posted - 12 February 2004 : 13:35:46
|
Right now I cannot do it, as I have that in my office computer.
I know I had done some debugging during this evening and made a couple of changes so that the forums and topics are shown. I will tell you tomorrow.
I still have to check if, once the forums are seen, they are really read-only, or I have to change something more so that the user can't post a topic. |
Best Regards
Mikel Perez
"Hell is the place where everything test perfectly, and nothing works"
|
|
|
|
ajhvdb
Junior Member
Netherlands
392 Posts |
Posted - 12 February 2004 : 16:09:35
|
Nikkol, I think there is a logical problem.
You have:
PERMS = 0 = Allow
PERMS = 1 = Deny
PERMS = 2 = Read-only
In functions "isAllowedMember" and "OldisAllowedMember" you search the forums the user is allowed to:
strSql = "SELECT FORUM_ID FROM " & strTablePrefix & "ALLOWED_USERGROUPS " &_
"WHERE USERGROUP_ID IN (" & strGroupMembership & ") AND PERMS = 0"
This means the forums who are read-only (2) are never allowed!
Now if i change in the 2 statements the red part:
strSql = "SELECT FORUM_ID FROM " & strTablePrefix & "ALLOWED_USERGROUPS " &_
"WHERE USERGROUP_ID IN (" & strGroupMembership & ") AND PERMS IN (0,2)"
The user can now view "allow" and "read-only" but when posting or trying to post in a "read-only" forum, the user receives a error because the extra check with function "isReadOnly" returns true.
|
Edited by - ajhvdb on 12 February 2004 19:00:55 |
|
|
|
Nikkol
Forum Moderator
USA
6907 Posts |
Posted - 12 February 2004 : 17:23:35
|
yes, it may be that way because i had added the read only as an after thought to something someone wanted (which i believe was to allow an all visitors forum to be read only for certain groups) that's why i hadn't looked at it being for auth type being allowed list.
but anyway, are you saying that it works as you would expect with your change? or when you say error, you mean you get a vb error? |
Nikkol ~ Help Us Help You | ReadMe | 3.4.03 fixes | security fixes ~ |
|
|
|
ajhvdb
Junior Member
Netherlands
392 Posts |
Posted - 12 February 2004 : 18:04:43
|
| No, now it does work. With error i ment to say "Your access to this forum is read-only" |
|
|
|
Nikkol
Forum Moderator
USA
6907 Posts |
|
|
ajhvdb
Junior Member
Netherlands
392 Posts |
Posted - 12 February 2004 : 19:06:10
|
I've changed in the above message the instructions to explain this change needs to take place in 2 places. Maybe miperez can check if it works for him to.
|
|
|
|
Topic |
|
Topic Locked
