function OldisAllowedMember(fForum_ID,fMemberID)
	OldisAllowedMember = 0
	if isDeniedMember(fForum_ID, fMemberID) then exit function
	strSql = "SELECT MEMBER_ID, FORUM_ID FROM " & strTablePrefix & "ALLOWED_MEMBERS "
	strSql = strSql & " WHERE FORUM_ID = " & cLng(fForum_ID)
	strSql = strSql & " AND MEMBER_ID = " & cLng(fMemberID)

	Set rsAllowedMember = Server.CreateObject("ADODB.Recordset")
	rsAllowedMember.open strSql, my_Conn
	blnAM = 0
	if not rsAllowedMember.bof and not rsAllowedMember.eof then blnAM = 1
	rsAllowedMember.close
	set rsAllowedMember = nothing

	'## if the member exists as an allowed member for the forum then return value 1
	if blnAm = 1 then
		OldisAllowedMember = 1
	else

		'## check for usergroup membership
		strGroupsForUser = getGroupMembership(fMemberID,1)
		if strGroupsForUser <> "" then
			'## check to see if the user's groups are a part of this forum
			strSql = "SELECT USERGROUP_ID FROM " & strTablePrefix & "ALLOWED_USERGROUPS "
			strSql = strSql & "WHERE FORUM_ID = " & fForum_ID
			strSql = strSql & " AND PERMS = 0"
			set rsAllowedUserGroups = my_Conn.execute(strSql)
	
			blnAllowed = 0
			Do While Not rsAllowedUserGroups.eof Or OldisAllowedMember = 1
				intUserGroupID = rsAllowedUserGroups("USERGROUP_ID")
				if InStr("," & strGroupsForUser & ",", "," & intUserGroupID & ",") then OldisAllowedMember = 1
				rsAllowedUserGroups.movenext
			Loop
			rsAllowedUserGroups.close
			set rsAllowedUserGroups = nothing
		end if
	end if
end function

quote:

---

Originally posted by gDewar

David,

I come from VB6 land... so maybe this is a dumb question...

In VB, True is = -1, Not 1. I know this is also the case in script because

Response.Write Int(True)

Returns -1

Shouldn't you guys use -1, not 1? Also, why aren't you guys using the True and False keywords to begin with?

This would seem especially important in this lawless land where there are no data types to force the correct values.

Maybe I'm just being a code fascist, I don't know... Just starting to get into this asp stuff so not sure I feel confident enough yet to root out the problem, but I may be more helpful soon - I've been using the forums in Interdev to teach myself this stuff.

Glenn

---

quote:

---

Originally posted by Reinsnitz

Nothing wrong with being a finatic :)

Easy question to answer :) The forums are written to be cross database compatible. Access, MySQL, MSSQL, MSDN, Sybase, Oracle, FoxPro, etc... is all possible with this product, not just SQL Server or Access or MySQL... these were all planned from the beginning :)

---

quote:

---

Originally posted by gDewar


But many of the instances where I see 1 being used as a boolean True value, are not related to Boolean fields in a database.

Another question:
Is there a set of coding conventions for Snitz that MOD developers are asked to follow?

---

quote:

---

Originally posted by gDewar


Lastly, I'm not sure I'm asking these questions in the right forum... David seemed to suggest we unwittingly went off topic... Is there a section of the forum for discussing preferred code methodology for Snitz?

---