Author |
Topic  |
|
Aaron S.
Average Member
  
USA
985 Posts |
Posted - 24 May 2002 : 11:28:28
|
I searched but could not find this bug posted before.
As Admin I went into a post and edited it (so the Edited text would not show up).
I created the topic under my normal posting name (Aaron).
When I checked my email, I had two emails saying that the Topic had been Moved.
I did not move the topic, and the topicis in the same place it has always been.
Why did I receive these emails?
--Aaron
DOWNLOAD GREAT NEW MODS HERE
Edited by - Aaron S. on 24 May 2002 12:37:17 |
|
HuwR
Forum Admin
    
United Kingdom
20595 Posts |
Posted - 24 May 2002 : 11:35:26
|
I think Richard may be looking at this, as it happened to him a couple of days ago.
To be honest I think this bug is recent so may be related to security fixes
|
 |
|
Aaron S.
Average Member
  
USA
985 Posts |
|
HuwR
Forum Admin
    
United Kingdom
20595 Posts |
Posted - 24 May 2002 : 12:10:36
|
quote:
Thanks for updating me!
I think I would wait on Richards confirmation before thanking me 
|
 |
|
Aaron S.
Average Member
  
USA
985 Posts |
Posted - 24 May 2002 : 12:27:22
|
It is most likely a bug in post_info... and probably is due to the recent changes.
In order for the email to go out, this code must trigger:
if Forum_ID <> aryForum(1) then blnTopicMoved = true
aryForum is defined earlier in the code as:
'## Set array to pull out CAT_ID and FORUM_ID from dropdown values in post.asp aryForum = split(Request.Form("Forum"), "|")
Forum_ID is set earlier in the code as:
Forum_ID = cLng(Request.Form("FORUM_ID"))
I am guessing (cause I am just not that familar with some of this stuff) that Forum_ID is now converting to a number and the value in the aryForum is not a number - so they aren't equaling each other.
Just a guess... I'll try to play around some more.
--Aaron
DOWNLOAD GREAT NEW MODS HERE |
 |
|
Aaron S.
Average Member
  
USA
985 Posts |
Posted - 24 May 2002 : 12:36:54
|
I seemed to have fixed this by changing:
if Forum_ID <> aryForum(1) then
to:
if Forum_ID <> CLng(aryForum(1)) then
Again, I don't fully understand the code... so this might not be the only place this change needs to be made (in fact, any other comparisons to the newly patched Clng FORUM_ID, CAT_ID and TOPIC_ID might need this change also).
It works though... I no longer get the Topic Moved email when I edit a topic.
--Aaron
DOWNLOAD GREAT NEW MODS HERE
Edited by - Aaron S. on 24 May 2002 12:40:16 |
 |
|
Davio
Development Team Member
    
Jamaica
12217 Posts |
Posted - 24 May 2002 : 12:44:28
|
You are probably right on that bug Aaron. I believe Richard noticed it too. What you suggest should fix it.
«------------------------------------------------------» Want to know when the next version comes out, as soon as possible? Join our Mailing Lists ! |
 |
|
RichardKinser
Snitz Forums Admin
    
USA
16655 Posts |
Posted - 24 May 2002 : 14:28:06
|
confirmed that this does fix that bug.
I added cLng() around all instances of aryForum(0) and aryForum(1) within the if/then for MethodType = "EditTopic".
fixed on this site. |
 |
|
dayve
Forum Moderator
    
USA
5820 Posts |
Posted - 04 July 2002 : 00:23:29
|
I am still getting the emails for Topic Moved when I simply edit the first post ... am I missing anything that is not in this thread?
 http://www.nineinchnailz.com |
 |
|
dayve
Forum Moderator
    
USA
5820 Posts |
Posted - 04 July 2002 : 00:26:57
|
well, for good measure I placed cLng around all aryForum(0) and aryForum(1) and it seemed to stop. is there a problem with applying this to all instances??
 http://www.nineinchnailz.com |
 |
|
RichardKinser
Snitz Forums Admin
    
USA
16655 Posts |
Posted - 04 July 2002 : 00:41:01
|
No, there shouldn't be. |
 |
|
|
Topic  |
|