| Author |
 Topic  |
|
favorini
Starting Member
USA
27 Posts |
 Posted - 05 October 2006 : 15:01:03
|
Does this mod have any issues with 3.4.06?
I noticed that the links in the readme.html to the following are missing the "#":
inc_profile.asp
register.asp
pop_mail.asp
-FF< |
 |
|
|
favorini
Starting Member
USA
27 Posts |
Posted - 05 October 2006 : 16:03:52
|
quote:
Originally posted by favorini
Does this mod have any issues with 3.4.06?
To answer my own question, the only significant change seems to be with pop_mail.asp, which has changed somewhat.
The second edit winds up going at line 181 of original file:
Replace (add the green part, remove the red part)
Response.Write "</td>" & vbNewLine & _
" </tr>" & vbNewLine & _
" <tr>" & vbNewLine & _
with
Response.Write " </td>" & vbNewLine & _
" </tr>" & vbNewLine
'################################ Begin GateKeeper AntiSpam Mod #################################
if strPopMailGatekeeper = "1" then
Response.Write " <tr>" & vbNewLine & _
" <td bgColor=""" & strPopUpTableColor & """ noWrap vAlign=""top"" align=""right""><font face=""" & strDefaultFontFace & """ size=""" & strDefaultFontSize & """><b>Antispam question:</b></font></td>" & vbNewLine & _
" <td bgColor=""" & strPopUpTableColor & """ valign=""top""><font face=""" & strDefaultFontFace & """ size=""" & strDefaultFontSize & """>" & strGatekeeperQuestion & "</font></td>" & vbNewLine & _
" </tr>" & vbNewLine & _
" <tr>" & vbNewLine & _
" <td bgColor=""" & strPopUpTableColor & """ noWrap vAlign=""top"" align=""right""><font face=""" & strDefaultFontFace & """ size=""" & strDefaultFontSize & """><b>Answer:</b></font></td>" & vbNewLine & _
" <td bgColor=""" & strPopUpTableColor & """ valign=""top""><input name=""GateKeeperAnswer"" size=""25"" type=""text"" value=""" & Request.Form("GateKeeperAnswer") & """></td>" & vbNewLine & _
" </tr>" & vbNewLine
end if
'################################ End GateKeeper AntiSpam Mod #################################
Response.Write " <tr>" & vbNewLine & _
< |
Edited by - favorini on 05 October 2006 16:05:08 |
|
|
|
favorini
Starting Member
USA
27 Posts |
Posted - 05 October 2006 : 17:00:38
|
I think that the instructions for post.asp are wrong.
The code in question is around line 539 (abbreviated for clarity):
if mlev = 4 or mlev = 3 or mlev = 2 or mlev = 1 then
'Include username and password from cookie as hidden fields
'(i.e., user is already authenticated)
else
if (lcase(strNoCookies) = "1") or _
(strDBNTUserName = "" or strCkPassWord = "") then
'Include username and password text boxes so user can authenticate
'#1 The instructions say put Gatekeeper prompt here
end if
end if
'#2 I think you should put Gatekeeper prompt here
Correct me if I'm wrong, but if the prompt goes at #1, it will only show up when the user is not authenticated. If you move it to #2, it will always show up (if it's turned on), which is what you want, since the answer is always checked in post_info.asp.
-FF< |
|
|
|
favorini
Starting Member
USA
27 Posts |
Posted - 05 October 2006 : 17:13:24
|
Another issue is in post_info.asp. The check for GateKeeper answer only
occurs when posting a new topic, but not a reply. To include the check
there also, edit the code near line 1005 of post_info.asp.
Add the part in green (same as the code added to the first part of post_info.asp):
if strSignatures = "1" and strDSignatures <> "1" then
if Request.Form("sig") = "yes" and GetSig(strDBNTUserName) <> " " then
txtMessage = txtMessage & vbNewline & vbNewline & ChkString(GetSig(strDBNTUserName), "signature" )
end if
end if
'################################ Begin GateKeeper AntiSpam Mod #################################
if strLinkSpamGatekeeper = "1" then
select case len(Request.Form("GateKeeperAnswer"))
case "0"
Go_Result "You have not entered an answer for the Antispam question. Please use your back button and try again.", 0
case else
if (lcase(Request.Form("GateKeeperAnswer")) <> lcase(strGatekeeperAnswer1)) and (lcase(Request.Form("GateKeeperAnswer")) <> lcase(strGatekeeperAnswer2)) then
Go_Result "You have entered a wrong answer for the Antispam question. Please use your back button and try again.", 0
end if
end select
end if
'################################ End GateKeeper AntiSpam Mod #################################
< |
|
|
|
Podge
Support Moderator
Ireland
3775 Posts |
|
|
favorini
Starting Member
USA
27 Posts |
Posted - 05 October 2006 : 23:33:11
|
quote:
Originally posted by Podge
All of the spam I've seen has been a bot posting a new topic. It makes sense to prevent replies too.
If you don't mind I'll add you code to the zip also.
Yeah, I figured, but they will adapt eventually. By all means use anything I posted.
-FF< |
|
|
|
favorini
Starting Member
USA
27 Posts |
Posted - 05 October 2006 : 23:57:34
|
Another suggestion...
In post.asp, change the if to add the part in green:
if strLinkSpamGatekeeper = "1" and (strRqMethod = "Topic" or strRqMethod = "TopicQuote" or strRqMethod = "Reply" or strRqMethod = "ReplyQuote") then The GateKeeper question isn't needed (or checked) when editing a topic/reply or creating/editing forums/URLs/categories.
-FF
< |
|
|
|
favorini
Starting Member
USA
27 Posts |
Posted - 06 October 2006 : 01:58:36
|
quote:
Originally posted by JBaldwin
I am now also having problem using Quick Reply. It is saying I did not enter/entered incorrect antispam info. Do we need to add the anti-spam boxes to the quick reply as well?
Yep. Edit topic.asp in Sub QuickReply around line 1094.
Replace (add the green part, remove the red part)
" <td bgColor=""" & strHeadCellColor & """ noWrap vAlign=""top"" colspan=""2""><font face=""" & strDefaultFontFace & """ size=""" & strDefaultFontSize & """ color=""" & strHeadFontColor & """><b>Quick Reply</b></font></td>" & vbNewLine & _
" </tr>" & vbNewLine & _
" <tr>" & vbNewLine & _
with
" <td bgColor=""" & strHeadCellColor & """ noWrap vAlign=""top"" colspan=""2""><font face=""" & strDefaultFontFace & """ size=""" & strDefaultFontSize & """ color=""" & strHeadFontColor & """><b>Quick Reply</b></font></td>" & vbNewLine & _
" </tr>" & vbNewLine
'################################ Begin GateKeeper AntiSpam Mod #################################
if strLinkSpamGatekeeper = "1" then
Response.Write " <tr>" & vbNewLine & _
" <td bgColor=""" & strForumCellColor & """ noWrap vAlign=""top"" align=""right""><font face=""" & strDefaultFontFace & """ size=""" & strDefaultFontSize & """ color=""" & strForumFontColor & """><b>Antispam question:</b></font></td>" & vbNewLine & _
" <td bgColor=""" & strForumCellColor & """ valign=""top""><font face=""" & strDefaultFontFace & """ size=""" & strDefaultFontSize & """>" & strGatekeeperQuestion & "</font></td>" & vbNewLine & _
" </tr>" & vbNewLine & _
" <tr>" & vbNewLine & _
" <td bgColor=""" & strForumCellColor & """ noWrap vAlign=""top"" align=""right""><font face=""" & strDefaultFontFace & """ size=""" & strDefaultFontSize & """ color=""" & strForumFontColor & """><b>Answer:</b></font></td>" & vbNewLine & _
" <td bgColor=""" & strForumCellColor & """ valign=""top""><input name=""GateKeeperAnswer"" size=""25"" type=""text"" value=""" & Request.Form("GateKeeperAnswer") & """></td>" & vbNewLine & _
" </tr>" & vbNewLine
end if
'################################ End GateKeeper AntiSpam Mod #################################
Response.Write " <tr>" & vbNewLine & _
< |
Edited by - favorini on 06 October 2006 02:04:54 |
|
|
|
bobby131313
Senior Member
USA
1163 Posts |
Posted - 16 October 2006 : 00:33:06
|
quote:
Any volunteers to test the new readme.html ?
OK, you just had a non-asp proficient tester do it. Still a few issues, but I got it working fine.
In pop-mail.asp it says to look for this....
if YEmail <> "" then Response.Write(YEmail)
Response.Write "</font></td>" & vbNewLine & _
" </tr>" & vbNewLine & _
" <tr>" & vbNewLine & _ if YEmail <> "" then Response.Write(YEmail)
Response.Write "" & vbNewLine & _
" " & vbNewLine & _
" <tr>" & vbNewLine & _
As you can see it's doubled. Drove me nuts for a few minutes.
Also as noted above...
quote:
I think that the instructions for post.asp are wrong.
The code in question is around line 539 (abbreviated for clarity):
--------------------------------------------------------------------------------
if mlev = 4 or mlev = 3 or mlev = 2 or mlev = 1 then
'Include username and password from cookie as hidden fields
'(i.e., user is already authenticated)
else
if (lcase(strNoCookies) = "1") or _
(strDBNTUserName = "" or strCkPassWord = "") then
'Include username and password text boxes so user can authenticate
'#1 The instructions say put Gatekeeper prompt here
end if
end if
'#2 I think you should put Gatekeeper prompt here
This still needs to be fixed, the question would not show until I moved the code block after the double "end if" as mentioned before.
Even with having to figure out these problems, it only took me 30 minutes or so.
Thanks Podge! 
< |
Switch the order of your title tags |
Edited by - bobby131313 on 16 October 2006 00:33:56 |
|
|
|
janaf
Starting Member
Sweden
19 Posts |
Posted - 18 October 2006 : 11:48:39
|
Newbie question:
Any changes required for 3.4.06?
Would it not be a good idea to remove the "Click to send email" link / function, replacing it with a "You can't email yet"-message? It would prevent legitimate but new members from spending time composing emals, just to get a NO message, which is frustrating.< |
|
|
|
Podge
Support Moderator
Ireland
3775 Posts |
|
|
janaf
Starting Member
Sweden
19 Posts |
Posted - 19 October 2006 : 10:38:40
|
Thats OK, I will try manually inserting your code line by line instead of using the edited files.
What do you think of a scheeme like this:
- New user signs by entering only the email adderess (and CAPTCHA test). The address and a random number is stored as a temporary record.
- Confirmation mail with a signup link and random number is sent
- Person completes the proper signup
- If no response is recieved within x time, the temporary record is disabled/deleted.
This way the forum admin never needs to see the signups until the above procedure is completed.
< |
|
|
|
Podge
Support Moderator
Ireland
3775 Posts |
|
|
marckmcgill
Junior Member
Italy
134 Posts |
Posted - 26 November 2006 : 12:18:39
|
Hello there Podge, I just installed your MOD.
Great piece of software, I hope it'll solve my problems.
The setup hasn't been a problem, I just have two additional notes:
quote:
Originally posted by bobby131313
In pop-mail.asp it says to look for this....
if YEmail <> "" then Response.Write(YEmail)
Response.Write "</font></td>" & vbNewLine & _
" </tr>" & vbNewLine & _
" <tr>" & vbNewLine & _ if YEmail <> "" then Response.Write(YEmail)
Response.Write "" & vbNewLine & _
" " & vbNewLine & _
" <tr>" & vbNewLine & _
As you can see it's doubled. Drove me nuts for a few minutes.
As a reminder, please note that this still needs to be corrected in the readme.
quote:
I think that the instructions for post.asp are wrong.
The code in question is around line 539 (abbreviated for clarity):
--------------------------------------------------------------------------------
if mlev = 4 or mlev = 3 or mlev = 2 or mlev = 1 then
'Include username and password from cookie as hidden fields
'(i.e., user is already authenticated)
else
if (lcase(strNoCookies) = "1") or _
(strDBNTUserName = "" or strCkPassWord = "") then
'Include username and password text boxes so user can authenticate
'#1 The instructions say put Gatekeeper prompt here
end if
end if
'#2 I think you should put Gatekeeper prompt here
Mmmhhh... Apparently, if the block is put in position #1, the antispam question will NOT be asked BUT new topics will be blocked.
However, if the Gatekeeper block is put in postion #2, it will ALWAYS ask the question,
even to subscribers who are logged in. I don't think the avarage administrator wants it to work this way (oh, well.. at least I dont'... ).
Having to fill the answer field every time is extremely annoying and perhaps not very useful until a board doesn't have GREAT issues with spam.
Is there a way to let the admin choose between mode "ask the question when opening a new topic" and mode "let those who are logged in open new topics freely without antispam question"?.
Cheers - M.< |
Edited by - marckmcgill on 28 November 2006 04:17:29 |
|
|
|
Podge
Support Moderator
Ireland
3775 Posts |
|
|
Topic |
|
Snitz GateKeeper Antispam
