Author |
Topic |
dayve
Forum Moderator
USA
5820 Posts |
|
stuF
Average Member
United Kingdom
561 Posts |
Posted - 20 November 2001 : 10:30:23
|
great mod, been after somthing new to addon for ages :)
i installed it fine, all dandy, but in the code you suggest to add in forum/active.asp you forgot to include the bgcolor thing. You might want to add that for the less initiate amongst us. Is thier a limit to the number of members names it will show?
snitz all dolled up @ http://36-degrees.co.uk/cgi-bin/forum/ |
|
|
Da_Stimulator
DEV Team Forum Moderator
USA
3373 Posts |
Posted - 20 November 2001 : 10:53:52
|
The database field is limited to 255 charecters - so when that fills up it will stop recording members who viewed. Replies are unlimited.
255 charecters will display about 50-75 members who viewed the topic
---- -Eric | Mod Resource | Test Area Sleep: A completely inadequate substitute for caffeine http://phpscriptcenter.com -Quality PHP Scripts |
|
|
dayve
Forum Moderator
USA
5820 Posts |
Posted - 20 November 2001 : 13:19:24
|
quote:
great mod, been after somthing new to addon for ages :)
i installed it fine, all dandy, but in the code you suggest to add in forum/active.asp you forgot to include the bgcolor thing. You might want to add that for the less initiate amongst us. Is thier a limit to the number of members names it will show?
snitz all dolled up @ http://36-degrees.co.uk/cgi-bin/forum/
sorry about that, I didn't add the bgcolor because I have a tweak on my forum that does table highlighting and I had to remove the individual bgcolors from all the table cells. thanks for pointing that out. I am making the changes the Stim and G noted for 3.3 and I will update the zip file with the bgcolor tags as well.
____________ dayve http://www.nineinchnailz.com/forum |
|
|
GauravBhabu
Advanced Member
4288 Posts |
Posted - 20 November 2001 : 13:25:06
|
quote:
The database field is limited to 255 charecters - so when that fills up it will stop recording members who viewed. Replies are unlimited.
255 charecters will display about 50-75 members who viewed the topic
What I am thinking is to Make it FIFO. So that it shows the newest readers.
GauravBhabu There is only one miracle...That is LIFE! | It is difficult to IMPROVE on Perfection, There is no harm in Keep Trying. |
|
|
stuF
Average Member
United Kingdom
561 Posts |
|
GauravBhabu
Advanced Member
4288 Posts |
Posted - 20 November 2001 : 14:13:43
|
quote:
one more thing: http://36-degrees.co.uk/cgi-bin/forum/pop_show_replies.asp?TOPIC_ID=51&show=reply
how do i get rid of that empty cell at the bottom, i thought it would be simple, but the whole if, response write thing scared me!
snitz all dolled up @ http://36-degrees.co.uk/cgi-bin/forum/
Most likely, You have an extra row towards the end of pop_show_replies.asp between these two statements.
Wait, You removed that Link ViewTopic and Close Window. It is due to taht. <%=strDisplay%> </table>
GauravBhabu There is only one miracle...That is LIFE! | It is difficult to IMPROVE on Perfection, There is no harm in Keep Trying.
Edited by - GauravBhabu on 20 November 2001 14:17:23 |
|
|
aston
New Member
Andorra
51 Posts |
Posted - 20 November 2001 : 21:56:11
|
sorry,when I am a guest visit your site ,I got this error.
ADODB.Field error '800a0bcd' Either BOF or EOF is True, or the current record has been deleted. Requested operation requires a current record.
/forum/inc_functions.asp, line
______________________
Fly me to the Moon
|
|
|
dayve
Forum Moderator
USA
5820 Posts |
Posted - 21 November 2001 : 04:52:51
|
quote:
sorry,when I am a guest visit your site ,I got this error.
ADODB.Field error '800a0bcd' Either BOF or EOF is True, or the current record has been deleted. Requested operation requires a current record.
/forum/inc_functions.asp, line
______________________
Fly me to the Moon
you got me on a day that my host has just been killing me with problems. I have since then migrated my entire forum to my server at home where it should run more smoothly until I get a new host. it works fine... check it out again or check out Stims site for the 3.3 version. they are identical...
____________ dayve http://www.nineinchnailz.com/forum |
|
|
dayve
Forum Moderator
USA
5820 Posts |
|
Snack
Starting Member
Switzerland
7 Posts |
Posted - 24 November 2001 : 11:13:14
|
Two Questions:
1. GauravBhabu was talking about that FIFO function. Is there already such an update available?
2. In the "Who wieved..." File, I'd really like to see, when the user saw the topic the last time (date/time). IMHO this would make sense, so that you immediately know, how far the user read the topic and if he's "up to date"... Is there someone, who's able to add that feature? It looks quite difficult to me, but I know that there are real Cracks out there, isn't it?
SNACK |
|
|
GauravBhabu
Advanced Member
4288 Posts |
Posted - 24 November 2001 : 12:44:49
|
quote: GauravBhabu was talking about that FIFO function. Is there already such an update available
I posted the modified code for that. and i believe it has been updated in the zip as well
GauravBhabu There is only one miracle...That is LIFE! | It is difficult to IMPROVE on Perfection, There is no harm in Keep Trying. |
|
|
dayve
Forum Moderator
USA
5820 Posts |
Posted - 24 November 2001 : 14:15:41
|
quote:
quote: GauravBhabu was talking about that FIFO function. Is there already such an update available
I posted the modified code for that. and i believe it has been updated in the zip as well
GauravBhabu There is only one miracle...That is LIFE! | It is difficult to IMPROVE on Perfection, There is no harm in Keep Trying.
yes it has been updated with GauravBhabu's latest updates as applied to the 3.3 version.
____________ dayve http://www.nineinchnailz.com/forum |
|
|
dayve
Forum Moderator
USA
5820 Posts |
Posted - 24 November 2001 : 14:18:19
|
quote: 2. In the "Who wieved..." File, I'd really like to see, when the user saw the topic the last time (date/time). IMHO this would make sense, so that you immediately know, how far the user read the topic and if he's "up to date"... Is there someone, who's able to add that feature? It looks quite difficult to me, but I know that there are real Cracks out there, isn't it?
the way it was coded would require a complete restructure so I don't think you will see this feature anytime soon, although I second it. Stim uses parsed data to retrieve the member names, you can't associate that with timestamping unless he incorporates a parallel array for member id's and time stamping..... hmmm what do you think stim?, the date string would definately have to be longer than 255 characters though... I suppose it could be done...
____________ dayve http://www.nineinchnailz.com/forum
Edited by - dayve on 24 November 2001 14:19:27
Edited by - dayve on 24 November 2001 14:20:44 |
|
|
ManuelW
Starting Member
5 Posts |
Posted - 24 November 2001 : 17:35:19
|
For this error in 3.1 R4
ADODB.Field error '800a0bcd' Either BOF or EOF is True, or the current record has been deleted. Requested operation requires a current record.
/forum/inc_functions.asp, line
i have updated the code and it works fine ;)
'########### update by ManuelW for Reply View ############ chkGuestUser = Request.Cookies(strUniqueID & "User")("Pword") if chkGuestUser ="" then else ########################################################### '--------------- TOPIC AND REPLY VIEW (Updated 11.21.01) MemberID = getMemberID(strDBNTUserName) Dim LenWhoViewed,Topic_WhoViewed,DoUpdate,TmpWhoViewed,UpdateTview,IDToDiscard if MemberID = 0 or IsNull(MemberID) or MemberID < 0 then 'dont update anything else DoUpdate = True strsql = "SELECT T.T_WHOVIEWED FROM " & strTablePrefix & "TOPICS T WHERE " strsql = strsql & "T.TOPIC_ID=" & Request.QueryString("TOPIC_ID") set tviewRS = Server.CreateObject("ADODB.RecordSet") tviewRS.open strsql, my_conn, 3 Topic_WhoViewed = tviewRS("T_WHOVIEWED") tviewRS.close set tviewRS = nothing if IsNull(Topic_WhoViewed) or Topic_WhoViewed = "" or Topic_WhoViewed = "0" or Len(Trim(Topic_WhoViewed)) = 0 then UpdateTview = MemberID else LenWhoViewed = len(Topic_WhoViewed) arrWhoViewed = split(Topic_WhoViewed,",",-1,1) 'CHECK if the MemberID already Exists if IsArray(arrWhoViewed) then If Instr(1,Topic_WhoViewed, "," & MemberID & ",",1) > 0 or _ Trim(arrWhoViewed(lbound(arrWhoViewed))) = Trim(MemberID) or _ Trim(arrWhoViewed(ubound(arrWhoViewed))) = Trim(MemberID) then DoUpDate = false end if else if Trim(Topic_WhoViewed) = Trim(MemberID) then DoUpdate = false end if 'CHECK if Field is Full. If Full then discard the 'Oldest MemberID(FIFO) if DoUpdate = True then if (LenWhoViewed + len(MemberID) = 255) or _ (LenWhoViewed + len(MemberID) > 255) then 'Max Limit IDToDiscard = left(Topic_WhoViewed,(instr(len(MemberID),Topic_WhoViewed,",",1))) if IDToDiscard <> MemberID & "," then TmpWhoViewed = Replace (Topic_WhoViewed,IDToDiscard,"",1,1,1) Topic_WhoViewed = TmpWhoViewed DoUpdate = True else DoUpdate = false end if end if end if if DoUpDate = True then UpdateTview = Topic_WhoViewed & "," & MemberID end if end if 'UPDATE the Database if DOUpdate = true then strsql = "UPDATE " & strTablePrefix & "TOPICS " strsql = strsql & "SET " & strTablePrefix & "TOPICS.T_WHOVIEWED = '" & UpdateTview & "' WHERE " strsql = strsql & strTablePrefix & "TOPICS.TOPIC_ID = " & Request.QueryString("TOPIC_ID") my_conn.execute(strsql) end if LenWhoViewed = "" end if
'--------------- END TOPIC AND REPLY VIEW
'########### update by ManuelW for Reply View ############ end if '#########################################################
|
|
|
dayve
Forum Moderator
USA
5820 Posts |
Posted - 29 November 2001 : 19:45:19
|
hmmm, I replied and viewed a topic but the views popup does not show me as viewing the topic. I made all the latest and greatest updates that was applied to 3.3
____________ dayve http://www.nineinchnailz.com/forum |
|
|
Topic |
|