| Author |
 Topic  |
|
|
marckmcgill
Junior Member
Italy
134 Posts |
 Posted - 12 January 2010 : 04:50:37
|
Hi there.
I've read about the security fix
http://forum.snitz.com/forum/topic.asp?TOPIC_ID=69117
and then checked my situation.
I have V. 3.4.03
I could find the function block only in Inc_func_common.asp, but not in post_info.asp and register.asp. Is that okay?
Did the patch need to be applied at all to Inc_func_common.asp?
Thanks a lot for reading. |
|
|
HuwR
Forum Admin
United Kingdom
20611 Posts |
Posted - 12 January 2010 : 05:42:38
|
This affects Snitz 3.4.07. Previous versions that applied a bug fix that was posted for 3.4.06, using server variables HTTP_X_FORWARDED_FOR and REMOTE_ADDR may need similar fixing.
if you don't have the bug fix that was posted for 3.4.06, using server variables HTTP_X_FORWARDED_FOR and REMOTE_ADDR then you won't need to fix anything |
 |
|
|
kgrammer
Starting Member
USA
16 Posts |
Posted - 12 January 2010 : 22:35:48
|
I wanted to verify that the fix should be here:
function UpdateLastHereDate(fTime,UserName)
UserIPAddress = Request.ServerVariables("HTTP_X_FORWARDED_FOR")
if UserIPAddress = "" or left(UserIPAddress, 7) = "unknown" then
UserIPAddress = Request.ServerVariables("REMOTE_ADDR")
elseif InStr(UserIPAddress, ",") > 0 then
UserIPAddress = Left(UserIPAddress, InStr(UserIPAddress, ",")-1)
elseif InStr(UserIPAddress, ";") > 0 then
UserIPAddress = Left(UserIPAddress, InStr(UserIPAddress, ";")-1)
end If
UserIPAddress = Trim(ChkString(UserIPAddress,"SQLString"))
And NOT here:
function UpdateLastHereDate(fTime,UserName)
UserIPAddress = Request.ServerVariables("HTTP_X_FORWARDED_FOR")
if UserIPAddress = "" or left(UserIPAddress, 7) = "unknown" then
UserIPAddress = Request.ServerVariables("REMOTE_ADDR")
elseif InStr(UserIPAddress, ",") > 0 then
UserIPAddress = Left(UserIPAddress, InStr(UserIPAddress, ",")-1)
elseif InStr(UserIPAddress, ";") > 0 then
UserIPAddress = Left(UserIPAddress, InStr(UserIPAddress, ";")-1)
end If
if InStr(UserIPAddress, ":") > 0 then
UserIPAddress = Left(UserIPAddress, InStr(UserIPAddress, ":")-1)
end if
UserIPAddress = Trim(ChkString(UserIPAddress,"SQLString"))
Can you verify that the RED code placement is correct?
Thanks. |
Ken Grammer
Used Snitz on SpecRacer.com and GT_RaceCar.com |
|
|
|
ruirib
Snitz Forums Admin
Portugal
26364 Posts |
Posted - 12 January 2010 : 22:43:44
|
| Both the red and blue will work without any issues, but if you ask me, I would do the blue, just as a matter of preference. Effectiveness wise the results will be the same. |
Snitz 3.4 Readme | Like the support? Support Snitz too |
|
|
|
kgrammer
Starting Member
USA
16 Posts |
Posted - 12 January 2010 : 23:54:00
|
| Thanks! I also thought both would ultimately produce the same results, but the blue seemed to make more sense to me (and any future readers of the code! |
Ken Grammer
Used Snitz on SpecRacer.com and GT_RaceCar.com |
|
|
|
marckmcgill
Junior Member
Italy
134 Posts |
Posted - 13 January 2010 : 05:22:52
|
I applied every patch ever released for my version, so, even though that sentence is involuted and hard to understand, if logic doesn't fail me it implies that my software does need the patch indeed.
As said, however, I could locate the function subject to application of this patch only in one of the three files. Is that okay, or should I worry?
By the way I realize now that I should have opened this thread in the "current version" board. I apologize for this, I didn't get immediately that my version is still considered the current one. Mods can eventually move this topic there. |
|
|
|
ruirib
Snitz Forums Admin
Portugal
26364 Posts |
Posted - 13 January 2010 : 05:57:23
|
quote:
Originally posted by marckmcgill
I applied every patch ever released for my version, so, even though that sentence is involuted and hard to understand, if logic doesn't fail me it implies that my software does need the patch indeed.
As said, however, I could locate the function subject to application of this patch only in one of the three files. Is that okay, or should I worry?
By the way I realize now that I should have opened this thread in the "current version" board. I apologize for this, I didn't get immediately that my version is still considered the current one. Mods can eventually move this topic there.
This is the correct forum for previous versions. As HuwR stated elsewhere, this affects mainly 3.4.06 patched versions and 3.4.07. In previous versions, X_FORWARDED_FOR wasn't even used and that is the biggest risk the fix tries to protect.
For the ultimate protection, all requests for Request.ServerVariables("REMOTE_ADDR") should be sanitized too, but it's much less pressing that sanitizing X_FORWARDED_FOR.
Our fix takes care of both. |
Snitz 3.4 Readme | Like the support? Support Snitz too |
|
|
| |
Topic |
|
|
|
Topic Locked
