| Author |
 Topic  |
|
Andy Humm
Average Member
United Kingdom
908 Posts |
 Posted - 20 May 2008 : 08:58:39
|
Further to above looking into why the searched word is not highlighted, if you change the line
SearchLink = "&SearchTerms=" & ChkString(Request("searchterms"),"display")
back to
SearchLink = "&SearchTerms=" & ChkString(Request("search"),"display") the searchword is highlight but no popup and can't
< |
 |
|
|
Carefree
Advanced Member
Philippines
4222 Posts |
Posted - 20 May 2008 : 09:04:56
|
| Andy, look at my search_mod.asp, highlighting works, it finds words with apostrophes, etc.< |
|
|
|
leatherlips
Senior Member
USA
1838 Posts |
Posted - 20 May 2008 : 09:25:22
|
quote:
Originally posted by Carefree
Andy, look at my search_mod.asp, highlighting works, it finds words with apostrophes, etc.
It's not that our search_mod will not find or highlight words with apostrophes. It will do that just fine. Our problem is that we also installed the search terms mod. With a word with an apostrophe it will not allow the pop up page to appear. If we apply the code above it will work but then it will not highlight the word.
If you go to my search page you can see what we are talking about. Search for can't. Then try to click the "quick look" icon. Then try searching for can and do the same thing.< |
Mangione Magic Forum - The Music of Chuck Mangione
My Mods: Googiespell MOD | Link To Reply MOD | Petition MOD | Contact Page MOD | Share This Topic MOD | MP3 MOD | PageEar MOD | Google Viewer MOD |
Edited by - leatherlips on 20 May 2008 09:25:58 |
|
|
|
Andy Humm
Average Member
United Kingdom
908 Posts |
Posted - 20 May 2008 : 09:42:50
|
| I have tried your coding (thank you) from search_mod.asp and still the pop_printer_friendly.asp does not pop up. Now reverted to last above where, everything works except the highlighting of the searched text.< |
Edited by - Andy Humm on 20 May 2008 09:47:40 |
|
|
|
Andy Humm
Average Member
United Kingdom
908 Posts |
Posted - 20 May 2008 : 10:07:38
|
quote:
Originally posted by leatherlips
quote:
Originally posted by Carefree
Andy, look at my search_mod.asp, highlighting works, it finds words with apostrophes, etc.
It's not that our search_mod will not find or highlight words with apostrophes. It will do that just fine. Our problem is that we also installed the search terms mod. With a word with an apostrophe it will not allow the pop up page to appear. If we apply the code above it will work but then it will not highlight the word.
If you go to my search page you can see what we are talking about. Search for can't. Then try to click the "quick look" icon. Then try searching for can and do the same thing.
Try the same on my search_mod.asp and see the differences, I have the added code from phy1729 and can't will display both on topic.asp and pop_printer_friendly.asp but all searched words will not highlight< |
|
|
|
Carefree
Advanced Member
Philippines
4222 Posts |
Posted - 20 May 2008 : 10:35:06
|
OK - I looked at the search terms mod & the problem is in the single line within search.asp (or search_mod.asp). Eliminate the javascript call and go with a target=_blank and the problem is solved.
< |
|
|
|
leatherlips
Senior Member
USA
1838 Posts |
|
|
Andy Humm
Average Member
United Kingdom
908 Posts |
Posted - 20 May 2008 : 11:22:49
|
Carefree well done...
But just as a reminder because we have removed the javascript call we need to do the same in topic.asp as the printer friendly links 'error page' too.
Topic.asp line 993 amend to read:
Response.Write " <br /><a href=""pop_printer_friendly.asp?" & ArchiveLink & "TOPIC_ID=" & Topic_ID & SearchLink & """ target=""_blank"">" & getCurrentIcon(strIconPrint,"","align=""absmiddle""") & "</a> <a href=""pop_printer_friendly.asp?" & ArchiveLink & "TOPIC_ID=" & Topic_ID & SearchLink & """ target=""_blank"">Printer Friendly</a>" & vbNewLine< |
|
|
|
Carefree
Advanced Member
Philippines
4222 Posts |
Posted - 20 May 2008 : 11:30:54
|
Leather, cannot be done. Those properties are only for javascript controlled windows; so you'll have to forego them if you want the thing to work at all.
I forgot about the call in topic.asp, Andy; was concentrating on the issue that had everyone bothered lol.
So with the exception of losing a controllable window size, we're all good?< |
|
|
|
leatherlips
Senior Member
USA
1838 Posts |
|
|
Andy Humm
Average Member
United Kingdom
908 Posts |
Posted - 20 May 2008 : 11:57:22
|
| Carefree, yes it had me bothered too... But like leatherlips, we were homing in on the problem from all angles, just to get it right. Thank's every one (whooops there's an apostrophe to worry about.. ho ho ho..)< |
|
|
|
Carefree
Advanced Member
Philippines
4222 Posts |
Posted - 20 May 2008 : 12:20:28
|
| The reason is because the javascript routine requires the use of apostrophes to delineate the page to open; it disregards them afterward.< |
|
|
|
phy1729
Average Member
USA
589 Posts |
Posted - 20 May 2008 : 13:41:32
|
Should have used jsurlpath not display for the ChkString so it's not
Response.Write " <a href=""JavaScript:openWindow5('pop_printer_friendly.asp?" & ArchiveLink & "TOPIC_ID=" & Topic_ID & ChkString(SearchLink,"display") & "')"">" & getCurrentIcon(strIconPrint,"","align=""absmiddle""") & "</a>"
it's
Response.Write " <a href=""JavaScript:openWindow5('pop_printer_friendly.asp?" & ArchiveLink & "TOPIC_ID=" & Topic_ID & ChkString(SearchLink,"jsurlpath") & "')"">" & getCurrentIcon(strIconPrint,"","align=""absmiddle""") & "</a>"
< |
|
|
|
leatherlips
Senior Member
USA
1838 Posts |
|
|
Lon
Starting Member
USA
47 Posts |
Posted - 22 May 2008 : 08:09:09
|
I've had this issue for a long time and could not figure it out. I am very proud of you guys working together to get this solved. I'm sure many others were also watching.
Thanks again.
Lon< |
|
|
|
Topic |
|
Topic Locked
