Author |
Topic |
|
ruirib
Snitz Forums Admin
Portugal
26364 Posts |
Posted - 18 January 2008 : 11:42:17
|
When subscribing to a topic that you have posted to, by checking the subscribe to this topic checkbox, no current check is done to find if there is already an existing subscription to the topic or to a higher subscription level including the topic. To fix that, a change to AddSubscription is needed. I'm including the complete code, just replace the existing function by the new one_
Find this code (around line#1982)
and replace it by
|
Snitz 3.4 Readme | Like the support? Support Snitz too |
|
HuwR
Forum Admin
United Kingdom
20584 Posts |
Posted - 18 January 2008 : 12:25:10
|
are you sure rui ?
if you reply to a topic you are already subscribed too, the check box should be to un-subscribe you rather than subcribe you.
< |
|
|
ruirib
Snitz Forums Admin
Portugal
26364 Posts |
Posted - 18 January 2008 : 12:29:04
|
Ah... maybe it's something that Bobby did, then. I did fix it on his code and the check box remained the same, but now that you mention it...
Of course, the extra code won't do any harm, but if the checkbox remains unchanged, the extra checks I added won't bring any advantage.< |
Snitz 3.4 Readme | Like the support? Support Snitz too |
|
|
HuwR
Forum Admin
United Kingdom
20584 Posts |
Posted - 18 January 2008 : 12:32:22
|
but you can't get duplicate subscriptions to the same topic (not unless you hack it) since checking the subscription checkbox a second time removes your subscription, so changing any code that relates to the checkbox may in fact break it.< |
|
|
ruirib
Snitz Forums Admin
Portugal
26364 Posts |
|
Lon2
Junior Member
USA
151 Posts |
Posted - 27 February 2009 : 12:00:50
|
quote: Originally posted by HuwR
but you can't get duplicate subscriptions to the same topic (not unless you hack it) since checking the subscription checkbox a second time removes your subscription, so changing any code that relates to the checkbox may in fact break it.
I delete duplicate subscriptions all the time in our forums. Should I apply ruirib's fixes from both this topic and the "Bug + fix: pop_subscription.asp" topic?
If it matters, we have the "delete multiple subscriptions" mod on our forum.< |
|
|
Lon2
Junior Member
USA
151 Posts |
Posted - 12 March 2009 : 14:45:57
|
rui, should I replace the "sub AddSubscription(SubLevel, MemberID, CatID, ForumID, TopicID)" routine in pop_subscription.asp as well? |
|
|
ruirib
Snitz Forums Admin
Portugal
26364 Posts |
|
Lon2
Junior Member
USA
151 Posts |
Posted - 12 March 2009 : 15:00:35
|
I'll let you know.
Thanks for the quick response! |
|
|
richfed
Average Member
United States
999 Posts |
Posted - 05 April 2009 : 10:08:50
|
So, what is the end result here? Should this fix be applied or not? [patched] Version ...3.05 ... |
|
|
ruirib
Snitz Forums Admin
Portugal
26364 Posts |
|
richfed
Average Member
United States
999 Posts |
Posted - 05 April 2009 : 20:42:09
|
Not that I am aware of, Ruirib ... I was just wondering if this, in conjunction with the fix in the other related thread, might prevent one down the road. I mean, applying both patches won't "break" anything right? |
|
|
ruirib
Snitz Forums Admin
Portugal
26364 Posts |
|
richfed
Average Member
United States
999 Posts |
Posted - 06 April 2009 : 06:51:50
|
Thanks, as always.
Wondering: Are these fixes included in the new version, 3.4.07? |
|
|
ruirib
Snitz Forums Admin
Portugal
26364 Posts |
|
AnonJr
Moderator
United States
5768 Posts |
Posted - 06 April 2009 : 12:47:40
|
No, they didn't make it. |
|
|
|
Topic |
|