Snitz Forums 2000
Snitz Forums 2000
Home | Profile | Register | Active Topics | Members | Search | FAQ
Username:
Password:
Save Password
Forgot your Password?

 All Forums
 Snitz Forums 2000 DEV-Group
 DEV Discussions (General)
 Q on inc_create_forum_xxx
 New Topic  Topic Locked
 Printer Friendly
Author Previous Topic Topic Next Topic  

MasterOfTheCats
Junior Member

103 Posts

Posted - 07 July 2003 :  22:09:37  Show Profile
They all have very same default value INSERT commands. Is there any reason that they are duplicated?

I see that MySQL version does not check for empty table as the tables are already empty, but that should not differ. I think they can all use the same code...

pweighill
Junior Member

United Kingdom
453 Posts

Posted - 08 July 2003 :  04:13:12  Show Profile
I've mentioned that before too. I don't know why its like that.

If you look at v3.4.0 there was even more duplication, but versions after that had some of the common code moved into a separate file: inc_create_forum_configvalues.asp
Go to Top of Page

MasterOfTheCats
Junior Member

103 Posts

Posted - 08 July 2003 :  09:30:33  Show Profile
Actually after examining a bit more, I found out the upgrade code and new setup code differ in results, mainly on constraints and indexes. The upgrade code and new setup code also have duplicates. There are also some hidden bugs like :

	SpecialSql4(Access) = "CREATE TABLE " & strTablePrefix & "ALLOWED_MEMBERS ("
	SpecialSql4(Access) = SpecialSql4(Access) & "MEMBER_ID INT NOT NULL, FORUM_ID INT NOT NULL, "
	SpecialSql4(Access) = SpecialSql4(Access) & "CONSTRAINT " & strTablePrefix & "SnitzC373 PRIMARY KEY (MEMBER_ID, FORUM_ID) ) "

This is for "V3.1 Service Release 3 Beta 2" and nobody hits it of course ...

IMHO, it would be ideal to have procedures to create a table with constraints and (non-foreign) indexes. A procedure for creating a table could be called from new setup and upgrade code. I see a nice logic for upgrade which uses arrays passed as parameters for new column/table creation, alterations etc, but as they don't use the same methodology, the code gets bigger and hard to cope with. I'm sure it is a nightmare for the developers to release a new version (this is not to criticise, just to say "I feel your pain").
Go to Top of Page
  Previous Topic Topic Next Topic  
 New Topic  Topic Locked
 Printer Friendly
Jump To:
Snitz Forums 2000 © 2000-2021 Snitz™ Communications Go To Top Of Page
This page was generated in 0.7 seconds. Powered By: Snitz Forums 2000 Version 3.4.07