I was under the impression we were making 3.4 addons response.write to mathch the other forum code....
although it would be nice, it is not mandatory. in fact when I release the upload avatar mod for 3.4 here shortly it will not use a whole bunch of response.writes ... well it may, depending on how lazy I feel at the time
quote:I was under the impression we were making 3.4 addons response.write to mathch the other forum code....
All response.write conversion isn't necessary for a MOD to work with v3.4. Since I wasn't the orignal author of this MOD, I've left most of the code in tact as it was in the previous version, just made a few minor changes to get it to work with v3.4. I figured this would buy the orignal authors some time to develop it how they wanted while people had something that works.
Btw, I'm not a big fan of all response.write anyway so, IPGate, the one MOD I did write may not end up being all response.writes.
just remembered, this code needs some reviewing because it will show topic titles in private forums! although a non member can not get into the topic, sometimes the topic title is enough to stir some controversy.
quote:just remembered, this code needs some reviewing because it will show topic titles in private forums!
Seems like I do remember spotting this when I was upgrading the code, but I didn't want to modify the actual functionality of the features and didn't figure it would be too big of an issue if the stats were only available to moderators and admins. This shouldn't be too difficult to implement a fix to block out private forums from showing up on the list and/or doing a security check.
I believe that if information is place in private areas, then all aspects of it should remain private, including the subjects. there was a huge issue on an forum where a private and hidden discussion about the banishment of a member was discussed. the title was something like
"Consideration for banishment of jake"
well jake found out and decided that since he was being considered for banishment he would raise hell during his final days and sure enough it stirred up quite a controversy.
anyway, I think I will edit the code which should be fairly simple to do to omit private items to those not having access to begin with.
Who then, if anyone, is updating this MOD? Alan (Aznknight) has moved on to .NET these days, so I doubt he'll be interested. Has one of the other original authors picked this up?
I appreciate the way you're handling MOD updates, but would it be possible for you to email me what you've got... on an "unofficial" basis?