quote:

---

Remove many of the GetMemberID calls and replace them with MemberId to Ruirib that helps a lot also.

www.daoc-halo.com

---

Member_Id = getNewMemberID()

quote:

---

I have ~50,000 active posts, the rest are archived.
I will try ruirib's modification now.

Pop Up Times Webmaster
http://www.popuptimes.com

---

if MemberID <> 0 then
  getNewMemberNumber = MemberID
  exit function
end if

CREATE PROCEDURE p_snitz_JumpTo  AS
set nocount on
select  SNITZ_CATEGORY.CAT_ID, CAT_NAME, CAT_ORDER,FORUM_ID,F_SUBJECT,F_ORDER,F_TYPE,F_URL
 FROM SNITZ_CATEGORY WITH(NOLOCK)
 JOIN SNITZ_FORUM WITH(NOLOCK) ON SNITZ_FORUM.CAT_ID=SNITZ_CATEGORY.CAT_ID
 ORDER BY CAT_ORDER ASC, CAT_NAME ASC,F_ORDER ASC,F_SUBJECT ASC
GO

<%
'#################################################################################
'## Copyright (C) 2000-01 Michael Anderson and Pierre Gorissen
'## 
'## This program is free software; you can redistribute it and/or
'## modify it under the terms of the GNU General Public License
'## as published by the Free Software Foundation; either version 2
'## of the License, or any later version.
'##
'## All copyright notices regarding Snitz Forums 2000
'## must remain intact in the scripts and in the outputted HTML
'## The "powered by" text/logo with a link back to 
'## http://forum.snitz.com in the footer of the pages MUST
'## remain visible when the pages are viewed on the internet or intranet.
'## 
'## This program is distributed in the hope that it will be useful,
'## but WITHOUT ANY WARRANTY; without even the implied warranty of
'## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
'## GNU General Public License for more details.
'## 
'## You should have received a copy of the GNU General Public License
'## along with this program; if not, write to the Free Software
'## Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
'## 
'## Support can be obtained from support forums at:
'## http://forum.snitz.com 
'##
'## Correspondence and Marketing Questions can be sent to:
'## reinhold@bigfoot.com
'## 
'## or
'## 
'## Snitz Communications 
'## C/O: Michael Anderson
'## PO Box 200
'## Harpswell, ME 04079
'#################################################################################
Response.Write 	"<!-- START JUMP TO -->" & vbNewline
Response.Write	"    <form name=""Stuff"">"
Response.Write	"		<font face=""" & strDefaultFontFace & """ size=""" & strDefaultFontSize & _
				"""><b>Jump To:</b></font>" & vbNewline
Response.Write	"	    <select name=""SelectMenu"" size=""1"" onchange=""jumpTo(this)"">" & vbNewline & _
				"		    <option value=""./"">Select Forum</option>" & vbNewline
'## Get all Forum Categories From DB
Set cmdCat=Server.CreateObject("ADODB.Command")
cmdCat.ActiveConnection=my_Conn
cmdCat.CommandType=adCmdStoredPRoc
cmdCat.CommandText="dbo.p_snitz_JumpTo"
Set rsCat=Server.CreateObject("ADODB.RecordSet")
rsCat.Open cmdCat,,adOpenForwardOnly,adLockReadOnly
Set cmdCat=nothing

iOldCat = 0
do until rsCat.eof '## Grab the Categories.
	CatID	= rsCat("CAT_ID")
	CatName = rsCat("CAT_NAME")
	ForumCatID	 = rsCat("CAT_ID")
	ForumID		 = rsCat("FORUM_ID")
	ForumType	 = rsCat("F_TYPE")
	ForumURL	 = rsCat("F_URL")
	if ChkForumAccess(ForumID, getNewMemberNumber()) then
		if CatID <> iOldCat Then
			Response.Write "      <option value='/forums/default.asp'>" & CatName & "</option>" & vbNewline
			iOldCat = CatID
		end if
		if ForumType = 0 then
			Response.Write "      <option value='" & MakeForumURL(ForumID,"","") & "'"
		elseif ForumType = 1 then
			Response.Write "      <option value='" & ForumURL & "'"
		end if
		if ForumID = Request.Querystring("Forum_ID") then 
			Response.Write(" SELECTED") 
		end if
		Response.Write ">      " & rsCat("F_SUBJECT")& "</option>" & vbNewline
	end if
	rsCat.MoveNext
loop
rsCat.Close
Set rsCat=nothing
Response.Write	"		<option value=""""> --------------------</option>" & vbNewline & _
				"		<option value=""" & strHomeURL & """>Home</option>" & vbNewline & _
				"		<option value=""active.asp"">Active Topics</option>" & vbNewline & _
				"		<option value=""faq.asp"">Frequently Asked Questions</option>" & vbNewline & _
				"		<option value=""members.asp"">Member Information</option>" & vbNewline & _
				"		<option value=""search.asp"">Search Page</option>" & vbNewline & _
				"	</select>" & vbNewline & _
				"</form>" & vbNewline & _
				"<!-- END JUMP TO -->" & vbNewline
%>

if (listForumModerators(allForumData(0, iForum)) <> "") then
    Response.Write listForumModerators(allForumData(0, iForum)) & vbNewline
else
     Response.Write "         " & vbNewline
end if

szModerators=listForumModerators(allForumData(0, iForum)
if szModerators<>"" Then
    Response.Write szModerators & vbNewline
Else
    Response.Write "         " & vbNewline
End If

CREATE PROCEDURE p_snitz_GetForums (@iUsers int=0) AS
set nocount on
SELECT SNITZ_FORUM.FORUM_ID, SNITZ_FORUM.F_STATUS, SNITZ_FORUM.CAT_ID, SNITZ_FORUM.F_SUBJECT, SNITZ_FORUM.F_URL, SNITZ_FORUM.F_DESCRIPTION,
      SNITZ_FORUM.F_TOPICS, SNITZ_FORUM.F_COUNT, SNITZ_FORUM.F_LAST_POST, SNITZ_FORUM.F_TYPE, SNITZ_FORUM.F_ORDER, SNITZ_FORUM.F_PRIVATEFORUMS,
      SNITZ_FORUM.F_A_COUNT, SNITZ_FORUM.F_SUBSCRIPTION, SNITZ_MEMBERS.MEMBER_ID, SNITZ_MEMBERS.M_NAME,IsNull(SUBSCRIPTION_ID,0) as Forum_Sub,IsNull(dbo.f_snitz_ListModerators(SNITZ_FORUM.FORUM_ID),'') as Moderators
   FROM SNITZ_FORUM WITH(NOLOCK)
   LEFT JOIN SNITZ_MEMBERS WITH(NOLOCK) ON SNITZ_FORUM.F_LAST_POST_AUTHOR = SNITZ_MEMBERS.MEMBER_ID
   LEFT JOIN SNITZ_SUBSCRIPTIONS WITH(NOLOCK) ON SNITZ_SUBSCRIPTIONS.FORUM_ID=SNITZ_FORUM.FORUM_ID
     AND SNITZ_SUBSCRIPTIONS.TOPIC_ID=0
     AND SNITZ_SUBSCRIPTIONS.MEMBER_ID=@iUsers

   ORDER BY SNITZ_FORUM.F_ORDER ASC, SNITZ_FORUM.F_SUBJECT ASC
GO

CREATE FUNCTION dbo.f_snitz_ListModerators (@iForums int)
RETURNS varchar(255) AS  
BEGIN 
DECLARE @vcModList varchar(255)

SELECT @vcModList=COALESCE(@vcModList + ', ','')+SNITZ_MEMBERS.M_NAME 
  FROM SNITZ_MODERATOR WITH (NOLOCK)
    LEFT OUTER JOIN SNITZ_MEMBERS WITH (NOLOCK) ON SNITZ_MODERATOR.MEMBER_ID=SNITZ_MEMBERS.MEMBER_ID
  WHERE SNITZ_MODERATOR.FORUM_ID=@iForums

return @vcModList
END

if (listForumModerators(allForumData(0, iForum)) <> "") then
    Response.Write listForumModerators(allForumData(0, iForum)) & vbNewline
else
     Response.Write "         " & vbNewline
end if

if (allForumData(17,iForum) <> "") then
     Response.Write allForumData(17, iForum) & vbNewline
else
     Response.Write "        " & vbNewline
end if

quote:

---

Thanks; I have a ton more -- my forums are almost 100% stored procedures and getrows, with numerous performance improvements. However, at the same time I was doing that work I was modifying them for better integration with a website and user database. I'd be happy to contribute all of my SP's and code modifications, but someone would have to modify them back to fit a "stock" snitz installation.

---