Snitz Forums 2000 - html in topic.asp

Snitz Forums 2000

Username:	Password:
Save Password
Forgot your Password?

All Forums

Snitz Forums 2000 DEV-Group

DEV Bug Reports (Open)

html in topic.asp

New Topic

Topic Locked

Printer Friendly

Author

Topic

OneWayMule
Dev. Team Member & Support Moderator

Austria
4969 Posts

Posted - 27 March 2002 : 22:09:05

I'm currently modifying topic.asp and I've found some HTML "bugs" you might want to remove. I've listed them below.

------------------------------------------
line 313:

<td align="right" colspan=2 width=100%>

should be:

<td align="right" colspan="2" width="100%">

-------------------------------------------

lines 379 and 527

		<font color="<% =strForumFontColor %>" face="<% =strDefaultFontFace %>" size="<% =strDefaultFontSize %>"><b><% =ChkString(rsReplies("M_NAME"),"display") %></a>
        </b></font>

should be:

		<font color="<% =strForumFontColor %>" face="<% =strDefaultFontFace %>" size="<% =strDefaultFontSize %>"><b><% =ChkString(rsReplies("M_NAME"),"display") %></b></a>
        </font>

-------------------------------------------

line 485:

            <td valign="top"><font face="<% =strDefaultFontFace %>" size="<% =strDefaultFontSize %>"><b>Topic is <% =maxpages %> Pages Long: </font></td>

should be:

            <td valign="top"><font face="<% =strDefaultFontFace %>" size="<% =strDefaultFontSize %>"><b>Topic is <% =maxpages %> Pages Long: </b></font></td>

-------------------------------------------

line 690, 712, 714, 718, 721 723

The border attribute appears 2 times in the img tag.

-------------------------------------------------
Installation Guide | Do's and Dont's | MODs

Edited by - OneWayMule on 27 March 2002 22:22:10

RichardKinser
Snitz Forums Admin

USA
16655 Posts

Posted - 27 March 2002 : 22:14:35

All of these items have already been fixed in v3.4

colspan=2

should really be:

colspan="2"

OneWayMule
Dev. Team Member & Support Moderator

Austria
4969 Posts

Posted - 27 March 2002 : 22:21:44

quote:

All of these items have already been fixed in v3.4

Great!

quote:

colspan=2

should really be:

colspan="2"

umm... silly me...

-------------------------------------------------
Installation Guide | Do's and Dont's | MODs

Aaron S.
Average Member

USA
985 Posts

Posted - 27 March 2002 : 22:22:09

Davio freaks out when I point out an extra (and not needed) "&_" in code saying its not a bug... but this one counts??

You don't really needs the quotes but I like when there is consistency in the code.

OneWayMule
Dev. Team Member & Support Moderator

Austria
4969 Posts

Posted - 27 March 2002 : 22:52:34

I think clean code (no matter if ASP/VBScript or HTML or something else) is very important and it makes a product look more professional.

And I just thought the small "bugs" should be fixed before converting everything to response.write.

-------------------------------------------------
Installation Guide | Do's and Dont's | MODs

RichardKinser
Snitz Forums Admin

USA
16655 Posts

Posted - 27 March 2002 : 23:00:46

I fixed them while I was converting the files to Response.Write. I didn't use Search and Replace during the conversion. I actually went through every single file line by line and converted it manually. I corrected the alignment of the code as well.

Davio
Development Team Member

Jamaica
12217 Posts

Posted - 28 March 2002 : 00:00:27

Freak out? I merely told you it's not a bug.
And it has already been changed in the 3.4 version.

A bug, as I consider it, is when a program/software doesn't function the way the programmer intended it to be or there is an error during the operation of the program/software that either hinders the user from using the program/software or causes the program/software to not function the way it was intended.

Now what you posted and also this post, I do not consider a bug per se, as how a bug is defined. It doesn't generate an error in the forum nor does it prohibits the normal use of the forum.

Here are a few pages on the term 'bug':
http://www.pcwebopedia.com/TERM/b/bug.html
http://www.techweb.com/encyclopedia/defineterm?term=bug&x=27&y=9

But if your posting would be categorized, I would say it was a Design Bug. Although it doesn't generate an error and the forum works with or without it, it is incorrect coding. And we do our best to clean up the code and conform to coding standards. So your post didn't go un-noticed.

If you want to discuss this further or anyone else, start a new topic in the DEV Discussions (General) forum.

«------------------------------------------------------»
Read the Do's and Don'ts before you post for help

Nathan
Help Moderator

USA
7664 Posts

Posted - 28 March 2002 : 00:36:35

Humm, perhaps during the CSS conversion it would be a great opertunity to utalize a W3C syntax checker and get the forums as close as possible to HTML 4.0 (or XHTML 1.0

) spec.

Nathan Bales - Romans 15:13
----------------------------------
Snitz Exchange | Do's and Dont's

Aaron S.
Average Member

USA
985 Posts

Posted - 28 March 2002 : 09:09:26

Davio... the inclusion of a smiley was so you understood that I was ribbing you and not being serious.

I think everyone is in agreement that we want the code to be as clean and consistent as possible... to that end, all the FORM elements need quotes around the id = and name =.

Most just say id=form1 and name=form1.

RichardKinser
Snitz Forums Admin

USA
16655 Posts

Posted - 28 March 2002 : 19:26:32

Like I said above, when I converted all of the files to Response.Write, I fixed all of the missing quotes.

Topic

New Topic

Topic Locked

Printer Friendly

Jump To:

Snitz Forums 2000

This page was generated in 0.13 seconds.