Author |
Topic  |
Deleted
deleted
    
4116 Posts |
|
Nathan
Help Moderator
    
USA
7664 Posts |
Posted - 09 March 2002 : 14:22:06
|
You da man bozden I'll let you finish it. . . 
Nathan Bales - Romans 15:13 ---------------------------------- Snitz Exchange | Do's and Dont's< |
 |
|
Deleted
deleted
    
4116 Posts |
Posted - 09 March 2002 : 15:24:53
|
It was ready but my wife called me to dinner .
Think PinkPost v40b03 Patches< |
 |
|
fatum
Junior Member
 
Belgium
281 Posts |
|
Deleted
deleted
    
4116 Posts |
Posted - 09 March 2002 : 16:22:34
|
quote:
I'll check the mods I already uploaded at Nathans site to see if everything is correct.
Please do not take them as they are and elaborate on them. Together we can find better solutions .
Edited by - bozden on 09 March 2002 16:39:58< |
 |
|
Nathan
Help Moderator
    
USA
7664 Posts |
Posted - 09 March 2002 : 16:43:51
|
quote: Do not allow unnecessary multiple definitions for the same string in one file. You may allow (or not allow, if you want to make it more flexible) multiple definitions
Brings up another good question.
Why has "All Forums: been defined seperatly for every single file in the base code? Couldn't things like this and "Admin Options" that are used alot and taken in the same contenxt be made global lang strings?
Nathan Bales - Romans 15:13 ---------------------------------- Snitz Exchange | Do's and Dont's< |
 |
|
Deleted
deleted
    
4116 Posts |
Posted - 09 March 2002 : 17:07:32
|
quote:
Why has "All Forums: been defined seperatly for every single file in the base code? Couldn't things like this and "Admin Options" that are used alot and taken in the same contenxt be made global lang strings?
In v4b03.003, there are 46 different strings/phrases that are used more than 3 times. These are (pay attention, some have & nbsp;):
All Forums 17 Go Back To Enter Data 15 All Forums 15 Password: 14 Admin Section 14 There Was A Problem With Your Details 11 NOTE: 11 Back To Admin Home 11 Reset Old Values 10 Congratulations! 10 Submit New Config 9 Send 9 Configuration Posted! 9 User Name: 8 On: 8 Off: 8 UserName: 6 Un-Lock Forum 6 Un-Lock Category 6 NT Account: 6 Admin Login 6 You Must enter a valid email address 5 Un-Lock Topic 5 New Topic 5 Login 5 Lock Topic 5 Lock Forum 5 Hello %s1% 5 Forum Locked 5 Delete Topic 5 Delete Forum 5 Close Window 5 Category Locked 5 Back To Forum 5 Topic Locked 4 Topic 4 Reply to Topic 4 Posts 4 Message: 4 Last Post 4 Go Back to Re-Authenticate 4 Edit Message 4 Edit Forum Properties 4 by: 4 Author 4 Admin Section 4
The average length of these strings are about 12.8 (the global average is 32.1 chars).
This is a part of a post I sent to the closed developers Forum titled "v4-Discussion-1: Reducing the String Load":
quote:
d) Define Global Strings (or Functions): At an early stage I decided to keep each file standalone and not to define/share language variables among files. I.e. every file has its own definition for "All Forums". This will increase the flexibility in language and in program writing, but we have some performance lost here. Note that there are no duplicates in a file, i.e if the same phrase is used more than once, they use the same variable. Here are the current values: There are 46 such strings (some very similar) repeated more than 3, resulting in 322 definitions (322-46=276 duplicates).
We can define variables like LangGlobal00010 = "All Forums".
Pros: Although this can be though as a good %14 reduction, it is not actually so. The average number of chars in these repeated strings are 12.8, so the savings in file size and server memory are much less (~%8). The real saving will be in the area of translation. Cons: It will not be easy for the programmer to keep trach of these "global" variables. You must use a "lexicon" to find what they are. My idea: We should not do this. But as most of these variables are repeated as a part of repeated code, such as the folder structure at the beginning of each file, error messages saying "go back to enter data" or "There Was A Problem With Your Details", link for the "admin section", entries for "username" or "password". I think it will be better to move some of these into inc_functions.asp as a whole, also reducing the repeated strings.
Think PinkPost v40b03 Patches< |
 |
|
Nathan
Help Moderator
    
USA
7664 Posts |
Posted - 09 March 2002 : 17:13:10
|
That makes sence. 
There should be a law against being so organized. 
Nathan Bales - Romans 15:13 ---------------------------------- Snitz Exchange | Do's and Dont's< |
 |
|
Deleted
deleted
    
4116 Posts |
Posted - 09 March 2002 : 17:17:42
|
quote:
That makes sence. 
There should be a law against being so organized. 
Nathan Bales - Romans 15:13 ---------------------------------- Snitz Exchange | Do's and Dont's
This is called Engineering .
Think PinkPost v40b03 Patches< |
 |
|
fatum
Junior Member
 
Belgium
281 Posts |
Posted - 10 March 2002 : 14:01:36
|
I'm still in favor of using some global vars or something. Now I always have to go back and look up how I translated eg. "All Forums" so that it will look the same on all pages. If we put general sentences/words (like "All Forums", "username", ...) together and create a "dictionary" for mod developpers, it would be more manageble for translators.
Just my 0.02 euro 
Dutch support forum | version4 beta3 Dutch testsite< |
 |
|
Deleted
deleted
    
4116 Posts |
Posted - 10 March 2002 : 16:02:51
|
I'm not sure, but let's see how it becomes with v3.4... It can also be done easily later.
Think PinkPost v40b03 Patches< |
 |
|
HuwR
Forum Admin
    
United Kingdom
20593 Posts |
Posted - 11 March 2002 : 04:07:03
|
Bozden,
quote:
The new table names, new field names created by the MOD must consist of UPPERCASE English ASCII charset for compatibility reasons.
What compatability problems does this cause ?
< |
 |
|
Deleted
deleted
    
4116 Posts |
Posted - 11 March 2002 : 05:47:56
|
|
 |
|
HuwR
Forum Admin
    
United Kingdom
20593 Posts |
Posted - 11 March 2002 : 06:10:53
|
Ok, I figured it may be for SQL 6, but didn't realise chilli ASP would require this. I don't see how it affects your problem with turkish though, since field names and tables names are not geberally passed to any casing routines, only their contents, which is my understanding of what the article is saying.
< |
 |
|
Deleted
deleted
    
4116 Posts |
|
HuwR
Forum Admin
    
United Kingdom
20593 Posts |
Posted - 11 March 2002 : 06:58:07
|
I'm not trying to be argumentative, or finicky, but not of your links would suggest that they MUST be in uppercase.
Your first link PRB: ADO Recordset Field Name with Letter "i" Is Case-sensitive with Turkish Settings (Q279651)
Says only that the case in the rs("fieldName") must match the case of the actual field, so you couldn't call the field FRED and then use rs("Fred"), but as long as the field is called 'Fred' then it is OK.
The other links were pretty specific and I don't see how they would affect the forum.
Don't get me wrong, I am not saying we shouldn't do this, since it is necesary for SQL 6 compatability, but people may think that this is necesary in everything they do, and unless they want to support SQL 6 this is not true.
< |
 |
|
Topic  |
|