Mail Author for Merge Topic Mod - Postet den (1973 Views)
JJenson
Advanced Member
JJenson
Innlegg: 2121
2121
Ok be nice everyone first attempt at anything remotely like this.
Ok I asked Davio if I could take a shot at trying the email function on his mod. Basically I want to continue learning and this seemed like a great way and he was gracious enough to let me.

I would like to know where I have errored in my thinking on this cause I am sure there are many spots lol. Basically I have taken the original code for the emailing a person when their topic is moved and copied it and renamed the function DoAutoMoveEmailMerge and also have done this with the sub for this function. I will post code of this below. In my limited understanding of this and logic it seems like this should email someone if topic is merged.
This is the emailing function in post_info.asp
Code:

if MergeTopic then 'not implemented yet
         'Send mail to author letting him know his topic was merged with another.
         DoAutoMoveEmailMerge(allRec(Topic_ID, intOlderTopic))
         strSql  = "SELECT M.MEMBER_ID, M.M_NAME, M.M_EMAIL, T.FORUM_ID, T.T_SUBJECT "
         strSql = strSql & " FROM " & strMemberTablePrefix & "MEMBERS M, " & strActivePrefix & "TOPICS T "
         strSql = strSql & " WHERE M.MEMBER_ID = T.T_AUTHOR "
         strSql = strSql & " AND T.TOPIC_ID = " & TopicNum

         set rs2 = my_Conn.Execute (strSql)

         email = rs2("M_EMAIL")
         user_name = rs2("M_NAME")
         Topic_Title = rs2("T_SUBJECT")
         ForumId = rs2("FORUM_ID")
         Usernum = rs2("MEMBER_ID")

         rs2.close

         strRecipientsName = user_name
         strRecipients = email
         strSubject = strForumTitle & " - Topic Moved"
         strMessage = "Hello " & user_name & vbNewLine & vbNewLine
         strMessage = strMessage & "Your posting on " & strForumTitle & "." & vbNewLine
         strMessage = strMessage & "Regarding the subject - " & Topic_Title & "." & vbNewLine & vbNewLine

         if not(chkForumAccess(ForumID,Usernum,false)) then
            strMessage = strMessage & "Has been removed from public display. If you have any questions regarding this, please contact the Administrator of the forum" & vbNewLine
         else
            strMessage = strMessage & "Has been moved to a new forum, You can view it at " & vbNewLine & Left(Request.Form("refer"), InstrRev(Request.Form("refer"), "/")) & "topic.asp?TOPIC_ID=" & TopicNum & vbNewLine
         end if
   %>
   <!--#INCLUDE FILE="inc_mail.asp" -->
   <%
      end if

      'ProcessSubscriptions Reply_Author, Cat_ID, Forum_ID, NewTopicID, Moderation
   else
      Go_Result "That topic does not exist in the database. Make sure the url you entered has the correct ID of the topic.", 0
   end if
   'Response.End
   Go_Result err_Msg, 1
   Response.End
end if

Here is the sub also in post_info.asp
Code:

sub DoAutoMoveEmailMerge(TopicNum)
   '## Emails Topic Author if Topic Moved.
   strSql  = "SELECT " & strMemberTablePrefix & "MEMBERS.MEMBER_ID," & strMemberTablePrefix & "MEMBERS.M_NAME, " & strMemberTablePrefix & "MEMBERS.M_EMAIL, " & strActivePrefix & "TOPICS.FORUM_ID, " & strActivePrefix & "TOPICS.T_SUBJECT "
   strSql = strSql & " FROM " & strMemberTablePrefix & "MEMBERS, " & strActivePrefix & "TOPICS "
   strSql = strSql & " WHERE " & strMemberTablePrefix & "MEMBERS.MEMBER_ID = " & strActivePrefix & "TOPICS.T_AUTHOR "
   strSql = strSql & " AND   " & strActivePrefix & "TOPICS.TOPIC_ID = " & TopicNum

   set rs2 = my_Conn.Execute (strSql)

   email = rs2("M_EMAIL")
   user_name = rs2("M_NAME")
   Topic_Title = rs2("T_SUBJECT")
   ForumId = rs2("FORUM_ID")
   Usernum = rs2("MEMBER_ID")

   rs2.close
   set rs2 = nothing
   if lcase(strEmail) = "1" then
      strRecipientsName = user_name
      strRecipients = email
      strSubject = strForumTitle & " - Topic Moved"
      strMessage = "Hello " & user_name & vbNewLine & vbNewLine
      strMessage = strMessage & "Your posting on " & strForumTitle & "." & vbNewLine
      strMessage = strMessage & "Regarding the subject - " & Topic_Title & "." & vbNewLine & vbNewLine

      if not(chkForumAccess(ForumID,Usernum,false)) then
         strMessage = strMessage & "Has been removed from public display, If you have any questions regarding this, please contact the Administrator of the forum" & vbNewLine
      else
         strMessage = strMessage & "Has been moved to a new forum, You can view it at " & vbNewLine & Left(Request.Form("refer"), InstrRev(Request.Form("refer"), "/")) & "topic.asp?TOPIC_ID=" & TopicNum & vbNewLine
      end if
%>
<!--#INCLUDE FILE="inc_mail.asp" -->
<%
   end if
end sub

If someone could just point me and help me understand this a little better I would greatly appreciate it.

Thanks All
   
 Sidestørrelse 
Postet den
JJenson
Advanced Member
JJenson
Innlegg: 2121
2121
Anyone have a direction to tell me to look at I don't wnat the codeing for this done at all just some ideas where I should look at and see what I can figure out?

Thanks All<
Postet den
HuwR
Forum Admin
HuwR
Innlegg: 20611
20611
what is actually going wrong ?<
Postet den
JJenson
Advanced Member
JJenson
Innlegg: 2121
2121
Well Basically everything works as it should with the mod but when I try to use the code above and I have tried other vriations the topics get merged but there is supposed to be a email telling the author of the topic that it was merged with another topic. and it gives them the url to their topic.
So everything gets merged but no email is being sent.<
Postet den
JJenson
Advanced Member
JJenson
Innlegg: 2121
2121
This is the newest code I have tried for this.
Code:

if MergeTopic then
         if strEmail = "1" and strMoveNotify = "1" then DoAutoMergeEmail(allRec(Topic_ID, intOlderTopic))
         strSQL = "SELECT F_SUBSCRIPTION FROM " & strTablePrefix & "FORUM WHERE FORUM_ID=" & cLng(aryForum(1))
         set rs = my_conn.execute (strSQL)
         if rs("F_SUBSCRIPTION") < 3 then
            strSQL = "DELETE FROM " & strTablePrefix & "SUBSCRIPTIONS WHERE TOPIC_ID=" & Topic_ID
            my_conn.execute(strSQL),,adCmdText + adExecuteNoRecords
         end if
         rs.close
         set rs = nothing
      end if

That is for the code to call for the sub to send the email and here is the sub code
Code:

sub DoAutoMergeEmail(TopicNum)
   '## Emails Topic Author if Topic Merged.
   strSql  = "SELECT " & strMemberTablePrefix & "MEMBERS.MEMBER_ID," & strMemberTablePrefix & "MEMBERS.M_NAME, " & strMemberTablePrefix & "MEMBERS.M_EMAIL, " & strActivePrefix & "TOPICS.FORUM_ID, " & strActivePrefix & "TOPICS.T_SUBJECT "
   strSql = strSql & " FROM " & strMemberTablePrefix & "MEMBERS, " & strActivePrefix & "TOPICS "
   strSql = strSql & " WHERE " & strMemberTablePrefix & "MEMBERS.MEMBER_ID = " & strActivePrefix & "TOPICS.T_AUTHOR "
   strSql = strSql & " AND   " & strActivePrefix & "TOPICS.TOPIC_ID = " & TopicNum

   set rs2 = my_Conn.Execute (strSql)

   email = rs2("M_EMAIL")
   user_name = rs2("M_NAME")
   Topic_Title = rs2("T_SUBJECT")
   ForumId = rs2("FORUM_ID")
   Usernum = rs2("MEMBER_ID")

   rs2.close
   set rs2 = nothing
   if lcase(strEmail) = "1" then
      strRecipientsName = user_name
      strRecipients = email
      strSubject = strForumTitle & " - Topic Moved"
      strMessage = "Hello " & user_name & vbNewLine & vbNewLine
      strMessage = strMessage & "Your posting on " & strForumTitle & "." & vbNewLine
      strMessage = strMessage & "Regarding the subject - " & Topic_Title & "." & vbNewLine & vbNewLine

      if not(chkForumAccess(ForumID,Usernum,false)) then
         strMessage = strMessage & "Has been merged with another topic, You can view it at " & vbNewLine & Left(Request.Form("refer"), InstrRev(Request.Form("refer"), "/")) & "topic.asp?TOPIC_ID=" & TopicNum & vbNewLine
      end if
%>
<!--#INCLUDE FILE="inc_mail.asp" -->
<%
   end if
end sub

I really am just walking through all of this trying to get a understanding of how it works and not sure if I am on the right path or not. <
Sist redigert av
Postet den
HuwR
Forum Admin
HuwR
Innlegg: 20611
20611
is it getting to the mail function ? you need to put some response.write checks in your code to ascertain where it is going wrong, it is not possible to say that by just looking at a code sample. for instance is strMoveNotify = "1" etc etc<
Postet den
JJenson
Advanced Member
JJenson
Innlegg: 2121
2121
Ok now to check this out I need to write something like

Response.Write strMoveNotify ="1"
Response.End

Is this what I need to do to get the information on that?<
Postet den
HuwR
Forum Admin
HuwR
Innlegg: 20611
20611
yes, then if that checks out move your response.end to find out where it gets to, you can simply do something like

response.write "I'm here"
response.end<
Postet den
JJenson
Advanced Member
JJenson
Innlegg: 2121
2121
Ok will give it a shot a little later today and let you know what happens.
Thanks Huw<
Postet den
Davio
Development Team Member
Davio
Innlegg: 12217
12217
Jeff, this line:
Code:
if MergeTopic then
It's not my variable and I don't see you setting a value to it. So this is probably why your email code isn't running.
You should probably start that bit of email code with this:
Code:
if strEmail = "1" and strMoveNotify = "1" then
   DoAutoMergeEmail(allRec(Topic_ID, intOlderTopic))
   ...rest of code goes here
end if
<
Support Snitz Forums
Sist redigert av
Postet den
JJenson
Advanced Member
JJenson
Innlegg: 2121
2121
Ahh ok I will give that a shot. My thinking on that line was that would refer back to where the code begins for the Merge Topic code. Thanks for the direction Davio and huw.<
Du må legge inn en melding