MOD Developers, please read... - Postet den (14621 Views)
Snitz Forums Admin
RichardKinser
Innlegg: 16655
16655
I have noticed the use of:

Code:
<!--#INCLUDE FILE="inc_func_common.asp" -->
as a replacement for:

Code:
<!--#INCLUDE FILE="inc_functions.asp" -->
But,

Code:
<!--#INCLUDE FILE="inc_func_common.asp" -->
is already an include in both inc_header.asp and inc_header_short.asp, so in a lot of the MODS that I have looked at, it's basically being included twice.
Please go over your MODS and check to make sure that you aren't including:
Code:
<!--#INCLUDE FILE="inc_func_common.asp" -->
in any of your files that also have either inc_header.asp or inc_header_short.asp as an include.<
   
 Sidestørrelse 
Postet den
Senior Member
@tomic
Innlegg: 1790
1790
Doh! Thanks for the heads up.
@tomic<
Postet den
Development Team Member
Davio
Innlegg: 12217
12217
Thanks Richard.
Wouldn't you get an error if the file was included twice? Because I would have fixed that in my mods if an error showed up. Otherwise, I might be guilty of doing that myself.<
Postet den
Advanced Member
GauravBhabu
Innlegg: 4288
4288
Originally posted by Davio

Wouldn't you get an error if the file was included twice? ...

No, it will not cause any errors. Only difference is that whenever a call is made to a function or sub the function/sub in the file which is included last will be executed.<
Postet den
Junior Member
ajhvdb
Innlegg: 392
392
I think you only get an error if you have a Dim statement outside of the sub/functions<
Postet den
Medlem er låst
Deleted
Innlegg: 4116
4116
Originally posted by ajhvdb
I think you only get an error if you have a Dim statement outside of the sub/functions

Also CONST...<
Stop the WAR!
Postet den
Junior Member
Tmpj
Innlegg: 467
467
Thanks for the info Richard, I was having a new MOD in mind! wink<
Postet den
Development Team Member
Davio
Innlegg: 12217
12217
Can I bump this post to remind all mod developers about this?
I am installing a few mods and I am seeing this happening in almost all of the mods.
Please don't include the inc_func_common.asp file, if you already include the inc_header.asp or inc_header_short.asp files.
Here are a few of the mods that I know of, that are guilty of this. I will update this list as I find them:
- Inactive users mod - Ipgate mod - Private Messages Mod - Active Users Mod<
Postet den
Average Member
richfed
Innlegg: 999
999
Can we simply delete the include for this file on these mods?<
Postet den
Medlem er låst
The Impact
Innlegg: 398
398
Yes, you would delete the include file which is in the file that includes an inc_header.asp, right ?<
Postet den
Development Team Member
Davio
Innlegg: 12217
12217
Yes, delete the inc_func_common.asp include from the files that have both inc_func_common.asp and inc_header.asp included.<
Du må legge inn en melding