| Author |
 Topic  |
|
|
SiSL
Average Member
Turkey
671 Posts |
|
|
HuwR
Forum Admin
United Kingdom
20584 Posts |
 Posted - 10 April 2009 : 12:42:11
|
I implemented it on a copy of the code here, will tweak the styles a little and then copy the files across, I did however change where I inserted the code into inc_header.asp
in your readme you say to add it after line 91, that is incorrect, that section only gets dispalyed if there is an error with the dbtype it needs adding after line 222 |
 |
|
|
SiSL
Average Member
Turkey
671 Posts |
|
|
HuwR
Forum Admin
United Kingdom
20584 Posts |
|
|
SiSL
Average Member
Turkey
671 Posts |
|
|
HuwR
Forum Admin
United Kingdom
20584 Posts |
Posted - 10 April 2009 : 14:17:40
|
| the scroll bars and max-height stuff works ok in FF, but for some reson is not working in IE (any version, not sure why as it normally works fine in IE7 and IE8, will have to have another look later) |
|
|
|
SiSL
Average Member
Turkey
671 Posts |
Posted - 10 April 2009 : 14:40:23
|
quote:
Originally posted by HuwR
the scroll bars and max-height stuff works ok in FF, but for some reson is not working in IE (any version, not sure why as it normally works fine in IE7 and IE8, will have to have another look later)
it may because use of height, max-height together and not in PRE but on DD; with IE, I use such:
.code { min-height: 40px; }
.code dd { max-height: 300px; overflow: auto; /* no other height modification */ }
.code dd pre { display: block; /* no height modificiation */ }
So I limit max-height from DD but not giving any particular height to it, also min-height to main container.
That's why I say PRE is a PITA element, along with "<select>" that W3C is frowned upon. (If that does not work, it may be one of reasons I passed to CODE, been long)
|
CHIP Online Forum
My Mods
Select All Code | Fix a vulnerability for your private messages | Avatar Categories W/ Avatar Gallery Mod | Complaint Manager
Admin Level Revisited | Merge Forums | No More Nested Quotes Mod
|
Edited by - SiSL on 10 April 2009 14:44:06 |
|
|
|
HuwR
Forum Admin
United Kingdom
20584 Posts |
Posted - 10 April 2009 : 14:45:32
|
height is for IE6, since IE6 doesn't respect max-height  that is why there is a height: auto !important IE>6 and FF should use that instead of height:200px; |
|
|
|
SiSL
Average Member
Turkey
671 Posts |
|
|
HuwR
Forum Admin
United Kingdom
20584 Posts |
Posted - 10 April 2009 : 16:12:58
|
I doubt very much that Win7 will make that much difference, the problem is mainly one of cost and time, we have over 1000 PC's running XP and IE6, ( some of us the developers and IT community ~ 100 are allowed to use browsers other than IE6) but the cost in licensing and time to move everyone to win7 will just be too prohibitive, and that will be the same for everyone)
I will try seperating the styles into a CSS file as that seems to work ok in the .net version and the only difference is it is in an external css file
[rant]you can't just forget about 30% of your users, so support for IE6 is important, as is supporting IE7/8 and FF[/rant] |
|
|
|
HuwR
Forum Admin
United Kingdom
20584 Posts |
Posted - 10 April 2009 : 17:38:16
|
| the size problem was caused by not having a doctype for the Snitz pages |
|
|
|
SiSL
Average Member
Turkey
671 Posts |
Posted - 10 April 2009 : 20:12:32
|
quote:
Originally posted by HuwR
the size problem was caused by not having a doctype for the Snitz pages
That explains it. Then that would make it default snitz code tag + select all :)
I still think there could be a way for it without DOCTYPE like you have in current. Will try myself by saving that page there.
Without DOCTYPE enviroment, scrollbars can be achieved as following, since max-height, min-height etc belongs to doctype based CSS's.
Giving a static height to all codes from DD, such as:
.code dd { height: 200px; max-height: 500px !important; overflow: auto; }
.code dd pre { padding: 0; display: block; max-height: 300px; }
|
Edited by - SiSL on 10 April 2009 20:39:16 |
|
|
|
HuwR
Forum Admin
United Kingdom
20584 Posts |
Posted - 11 April 2009 : 02:39:19
|
It works, but not how it should, without a doctype IE7 behaves like IE6, with a doctype it behaves like IE8 and FF, but it will do
couple of minor tweaks though, you have the !important tag on the wrong property, and the second max-height should be the same as the first otherwise it will only ever be 300px tall. it should be
.code dd { height:auto !important; height: 200px; max-height: 500px; overflow: auto; }
.code dd pre { padding: 0; display: block; max-height: 500px; } |
|
|
|
HuwR
Forum Admin
United Kingdom
20584 Posts |
Posted - 11 April 2009 : 02:41:33
|
| I will look at implementing it on this code later (may need to edit the db as it will probably interfere with the scrollcode tags which were implemented a while back |
|
|
| |
Topic |
|
MOD: Select All Code 1.0
