Author |
Topic |
|
gary b
Junior Member
USA
267 Posts |
Posted - 24 July 2007 : 23:31:04
|
When you are using 'email validation' and 'require registration', visitors "apply for membership" -- that is, they "register". Admins are presented with a list of 'pending members'.
If you 'approve' one (or more) pending memberships, email notification is sent. When the Accounts Pending screen refreshes, the "Approved?" column displays the word 'Yes'. However, the checkbox (used to select applicants for approval or deletion) is still there. Since an approval email has already been sent, I do not want to (incorrectly) click the checkbox of an applicant that has already been approved -- possibly sending a second email to applicant. My remedy: Hide the checkbox for applicants who have already been approved!
This 'mod' requires changes to only two lines of code. If you want to disable the checkbox for 'approved' applicants, follow the instructions below. Be careful of line wraps. Find these 2 lines of code in ADMIN_ACCOUNTS_PENDING.ASP (approx Ln 434)
Response.Write " <td bgcolor=""" & CColor & """ align=""center""><font face=""" & strDefaultFontFace & """ size=""" & strFooterFontSize & """ color=""" & strForumFontColor & """><input type=""checkbox"" name=""id"" value=""" & MP_MemberID & """ onclick=""Toggle(this)""></font></td>" & vbNewLine & _
" </tr>" & vbNewLine
REPLACE THE 2 LINES ABOVE WITH THE FOLLOWING SEVEN LINES OF CODE: if MP_MemberApprove = 1 then Response.Write " <td bgcolor=""" & CColor & """ align=""center""><font face=""" & strDefaultFontFace & """ size=""" & strFooterFontSize & """ color=""" & strForumFontColor & """> </font></td>" & vbNewLine & _ " </tr>" & vbNewLine else Response.Write "<td bgcolor=""" & CColor & """ align=""center""><font face=""" & strDefaultFontFace & """ size=""" & strFooterFontSize & """ color=""" & strForumFontColor & """><input type=""checkbox"" name=""id"" value=""" & MP_MemberID & """ onclick=""Toggle(this)""></font></td>" & vbNewLine & _ " </tr>" & vbNewLine end if
That's it... The checkbox beside applicants that have been approved is hidden.
Caution: Make a backup copy of Admin_Accounts_Pending.asp before changing the code.
Note: Tested on Snitz v3.4.06
Email me if you have questions or have a problem.< |
|
Shaggy
Support Moderator
Ireland
6780 Posts |
Posted - 25 July 2007 : 04:04:00
|
You're still going to need that checkbox if you want to delete a member after approving them.
< |
Search is your friend “I was having a mildly paranoid day, mostly due to the fact that the mad priest lady from over the river had taken to nailing weasels to my front door again.” |
|
|
gary b
Junior Member
USA
267 Posts |
Posted - 25 July 2007 : 07:16:36
|
Hi Shaggy...
Yes, I thought about that. If 'approved' applicant completes registration, the name is automatically removed. If he/she never completes registration, that name will have to be deleted from pending members. SOP for our forum is to delete 'approved' (but unregistered after 30 days) applicants using Delete All Pending Members. This clears out the bot-initiated applications and approved but unfinished applications.
Thanks for the observation, Shaggy. Have a good day.
[Edit: Just getting up... need more coffee!!]< |
Edited by - gary b on 25 July 2007 07:17:32 |
|
|
AnonJr
Moderator
United States
5768 Posts |
Posted - 25 July 2007 : 09:16:31
|
Its also worth noting that you'll need the check box to activate the account if they are having trouble with the e-mail not getting through and/or problems with the URL being wrapped/truncated by their e-mail client.... or any of a number of other odd situations.< |
|
|
gary b
Junior Member
USA
267 Posts |
Posted - 25 July 2007 : 12:28:45
|
Hmmm.. I did NOT think about that. Good point... Oh, well... the idea sounded good! It appeared to be a viable way to preclude duplicate 'approval' emails in a multi-Admin forum.
Shaggy or Anon... why don't ya just delete this post. I don't want anyone to use what is turning out to be a not-so-good idea.
I guess we'll just have to pay closer attention to the display... Approved? = Yes/No
Thanks for the input, guys...< |
|
|
Shaggy
Support Moderator
Ireland
6780 Posts |
Posted - 25 July 2007 : 12:44:56
|
Well, it was something you needed on your forums so there's nothing to say that someone else won't have similar need for it as well.
< |
Search is your friend “I was having a mildly paranoid day, mostly due to the fact that the mad priest lady from over the river had taken to nailing weasels to my front door again.” |
|
|
PPSSWeb
Junior Member
312 Posts |
Posted - 25 July 2007 : 13:48:06
|
Why not change the "yes" to a different color to make it stand out more. Or put a check in the approve function that will bypass the email portion if the user has already been approved?< |
Edited by - PPSSWeb on 25 July 2007 15:16:52 |
|
|
thermal_seeker
Junior Member
United Kingdom
430 Posts |
Posted - 25 July 2007 : 14:14:27
|
Would that check not conflict if you have the reminder email MOD??< |
No good at coding, but I can plough a field !! |
|
|
PPSSWeb
Junior Member
312 Posts |
Posted - 25 July 2007 : 15:24:14
|
Actually, I just looked at the code for the pending page and the check is already there. It should only send out an email to approved members if they have never been approved before. Otherwise, it goes through the motions, but the following checks bypass the email sending portions for already approved users.
Approve all:
Approve selected:
So this should be a non-issue. It will appear to the admin that the emails are being sent again, but they should not be getting sent unless you changed the code.
thermal_seeker, The reminder email MOD uses the exact opposite check to make sure the user is already approved before sending out the reminder emails. < |
|
|
|
Topic |
|