| Author |
 Topic  |
|
Classicmotorcycling
Development Team Leader
Australia
2084 Posts |
 Posted - 03 June 2006 : 23:32:25
|
Has anyone managed to get this working with the Active Users MOD? In particular with active_users.asp! I know there is a conflict with the WhatPage function and have not had the time to look at it fully, but if someone else has already done it, then it would save me some more time.. Thanks in advance...
< |
Cheers,
David Greening |
 |
|
|
AnonJr
Moderator
United States
5768 Posts |
Posted - 04 June 2006 : 09:36:36
|
Which conflict with the WhatPage function?
As to the AU MOD, I haven't tested it yet. It is on my list of MODs for the Warsong Records Forum, but I won't be able to do much until the new mother board for my file server comes in next week....  < |
|
|
|
Classicmotorcycling
Development Team Leader
Australia
2084 Posts |
Posted - 04 June 2006 : 18:34:33
|
AnonJr,
This is the error I am getting:Microsoft JET Database Engine error '80040e14'
Syntax error (missing operator) in query expression 'FORUM_ID==23'.
/forums/active_users.asp, line 570 And this is the code that relates to line 570 is in red:strSql = "SELECT F_SUBJECT FROM " & strTablePrefix & "FORUM WHERE FORUM_ID=" & fForum_ID
set rst = my_conn.execute(strSql)
if rst.EOF or rst.BOF then
strPage = fscript & "?" & fquery' fLang(strLangMOD_Ls3kAU_01270)
elseIt is called on by this:" & WhatPage(strLastPage,strQS) & " I will have a play around with it in the mean time and let you know if I get it sorted.< |
Cheers,
David Greening |
|
|
|
AnonJr
Moderator
United States
5768 Posts |
Posted - 05 June 2006 : 14:39:52
|
| Have you done a response.write of the SQL Statement before it executes?< |
|
|
|
Classicmotorcycling
Development Team Leader
Australia
2084 Posts |
Posted - 05 June 2006 : 15:09:56
|
| Yes, I have done the response.write of the sql statement. It shows the forum ID, which is why it is confusing me.. I have got it to show the forum ID in the AU screen, but there is no link with it, and the name of the forum is not showning up on any of the categories, apart from the parent with sub forums. Real strange I know..< |
Cheers,
David Greening |
|
|
|
AnonJr
Moderator
United States
5768 Posts |
Posted - 06 June 2006 : 10:58:53
|
Hmm. The error you posted seems to indicate that there's an extra "=" in the query...
As to the rest, I've not worked with AU yet so I'm not very familiar with the ins and outs of it. Since the forums are almost pulled the same as regular forums and the Active Topics page doesn't seem to have a similar problem, I'm not sure where to start.
Got a link to the site so I can see it in action?< |
|
|
|
AnonJr
Moderator
United States
5768 Posts |
Posted - 29 June 2006 : 16:31:14
|
Managed to track down and fix a couple of other little bugs. New posts in sub forums weren't changing the icons to indicate that a new post was made. Half the problem was a stupid mistake on my part, and the other half is another story... I'll get to that in a minute.
First - to fix the error you need to make two minor changes.
Change #1:
In inc_subforum.asp around line 136 change:Response.Write(ChkIsNew(Topic_LastPost))
To:Response.Write(ChkIsNew(ForumLastPost))
Change #2:
In default.asp* go to "sub ChkIsNew(dt)" near the bottom of the page. Find (should be the third line in the sub): if dt > Session(strCookieURL & "last_here_date") and (ForumCount > 0 or ForumTopics > 0) then And change it to: if dt > Session(strCookieURL & "last_here_date") and ((ForumCount + arrSubInfo(2)) > 0 or (ForumTopics + arrSubInfo(1)) > 0) then
*(My line numbers are so far off on that page it'd be impossible to give an accurate number...)
Oh, and for the record I was greatly frustrated trying to figure out the second fix because ChkIsNew() is a function in inc_func_chknew.asp as well and that was where I was making all my initial changes... and pulling my hair out trying to figure out why it wasn't making any difference whatsoever. 
I hope to update the download this weekend... things have been quite busy. Bobby wants the Jesus Joshua 24:15 site and the Warsong Records site to have a new look by Sept. when the new CD comes out. 
---
Edit: there was one more change in default.asp
Find: if ForumFType = 0 then
ChkIsNew(ForumLastPost)
elseAnd change it to:if ForumFType = 0 then
If ForumLastPost <> "" And (arrSubInfo(3) = "none" Or ForumLastPost > arrSubInfo(3)) Then
ChkIsNew(ForumLastPost)
ElseIf arrSubInfo(3) <> "none" Then
ChkIsNew(arrSubInfo(3))
Else
ChkIsNew(ForumLastPost)
End If
else< |
Edited by - AnonJr on 29 June 2006 16:40:54 |
|
|
|
Jezmeister
Senior Member
United Kingdom
1141 Posts |
Posted - 03 October 2006 : 17:47:51
|
Hey guys question, its not majorly important, im sure if I come back to it later I can find a workaround but I'm having a slight issue, I'm trying to make editing the forums properties possible to done by the "SubAdmin" (basically just another member level assigned to a maximum of one member per forum), all is fine except I don't want the subadmin to be able to change the parent forum and if I change the post.asp code to this:
Response.Write "<select name=""Parent"" class=""ForumTextBoxDropDown"" size=""1""" & vbNewLine
if (sLev = 4) and (mLev <> 4) then
Response.Write "disabled>"
Else
Response.Write ">"
End if
Upon submitting the forum is deleted... any quick fixes for this?
EDIT: On second thoughts it may be easiest for me simply to restrict database changes in post_info.asp... I'll have a look tomorrow
fixed using an excessive amount of if sLev <> 4's in post_info.asp meh< |
Edited by - Jezmeister on 04 October 2006 15:45:28 |
|
|
|
Jezmeister
Senior Member
United Kingdom
1141 Posts |
Posted - 28 November 2006 : 18:19:56
|
quote:
Originally posted by Jezmeister
if anyones interested im gonna expand this mod in the next few weeks to allow individual members to have and moderate their own subforums (not just being made moderator of that forum as normal), if anyone wants it I'll post the code when I'm done
a few of you seemed interested in the idea so: http://forum.snitz.com/forum/topic.asp?whichpage=1&TOPIC_ID=62904< |
|
|
|
modifichicci
Average Member
Italy
787 Posts |
Posted - 07 October 2007 : 08:40:31
|
From the read me:
Known Bugs:
* This code has not been tested with MySQL.
* Deleting a parent forum deletes any references to the Sub-Forums. They still exsist, but can not be edited or viewed unless you type the ID in the URL.
* Hidden Sub-Forums still show up on the list. Access is denied to those who aren't suposed to have it, but it is visible to all.
MySql working well after changes posted in this thread
Hidden subforums fixed:
in inc_subforums
at line 280
strSQL = "SELECT F.FORUM_ID, F.F_SUBJECT, F.F_TOPICS, F.F_COUNT, F.F_LAST_POST, F.F_LAST_POST_TOPIC_ID, " & _
add
F.F_PRIVATEFORUMS, F.F_PASSWORD_NEW,
after
F.F_COUNT
so it looks like:
strSQL = "SELECT F.FORUM_ID, F.F_SUBJECT, F.F_TOPICS, F.F_COUNT, F.F_PRIVATEFORUMS, F.F_PASSWORD_NEW, F.F_LAST_POST, F.F_LAST_POST_TOPIC_ID, " & _
at line 316
strSubList = strSubList & "<a href=""forum.asp?FORUM_ID=" & rs("FORUM_ID") & """>" & chkString(rs("F_SUBJECT"),"display") & "</a>"
change to
forumprivato = rs("F_PRIVATEFORUMS")
parolaprivata = rs("F_PASSWORD_NEW")
IDForum = rs("FORUM_ID")
MembroId = getMemberID(strDBNTUserName)
if MembroID = 0 then membroID = -1
if chkDisplayForum(forumprivato,parolaprivata,IDForum,MembroId) then
strSubList = strSubList & getCurrentIcon(strIconBar,"","align=""absmiddle""") & " " &"<a href=""forum.asp?FORUM_ID=" & rs("FORUM_ID") & """>" & chkString(rs("F_SUBJECT"),"display") & "</a><size=""1""> (" & rs("F_TOPICS") & "/" & rs("F_COUNT") & ")"
end if
That adds also number of Topic/post in subforums
Deleting:
fixed adding a message if there are subforums in forum delting, asking to delete or move them before deleting parent forum.
Deleting cannot be performed if subforums are present.
pop_delete
line 712 -713
case "Forum"
Response.Write("Only Administrators can delete Forums.")
add below
strSql = "SELECT FORUM_ID FROM " & strTablePrefix & "FORUM "
strSql = strSql & " WHERE F_PARENT = " & Forum_ID
set rsdel = my_Conn.Execute (strSql)
if rsdel.BOF or rsdel.EOF then
Response.Write("<b>No subforums in this forum.</b>")
cancellaforum=0
else
Response.Write("<b><font color=""" & strHiLiteFontColor & """>ATTENTION: </font>There are subforums in this forum.<br /> Delete or move them before deleting this forum!</b>")
cancellaforum = 1
end if
rsdel.close
set rsdel = nothing
after line 718 before
Response.Write "</font></p>" & vbNewLine & _
" <form action=""pop_delete.asp?mode="
add
if cancellaforum = 0 then
and before the end select of line 769
add
end if
< |
Ernia e Laparocele
Forum di Ernia e Laparocele
Acces - MySql Migration Tutorial
Adamantine forum |
|
|
|
modifichicci
Average Member
Italy
787 Posts |
|
|
bitwise2000
Starting Member
38 Posts |
Posted - 20 February 2008 : 20:19:32
|
Has anyone modified 1nc_subforum.asp to correctly hide private forums from display on default.asp? No matter how you set a forum, it always displays if its parent is visible.
I'd like a visible parent and hidden subforums.< |
|
|
|
Bassman
Junior Member
Netherlands
256 Posts |
Posted - 21 February 2008 : 05:37:09
|
| Noting wrong with the inc_subforum.asp as far as I can see. It works fine for my forum http://wj.scoutingforum.nl/ In there are hidden forums in all cats. Check if all the code for subforums in corect in default.asp.< |
|
|
|
AnonJr
Moderator
United States
5768 Posts |
Posted - 21 February 2008 : 06:21:54
|
I'll ditto Bassman, it shouldn't be showing if its a hidden forum. I have had a problem where it shows the Sub Forum text (but no links) if there is only one sub forum and its hidden.
In case the age of this thread wasn't a hint, I haven't had much time lately to fix it up and move it closer to production-level code.  < |
|
|
|
bitwise2000
Starting Member
38 Posts |
Posted - 21 February 2008 : 12:55:51
|
This is still listed as an issue in the readme; "Hidden Sub-Forums still show up on the list. Access is denied to those who aren't suposed to have it, but it is visible to all." Member modifichicci addresses it in his post above too, by directly querying F_Privateforums, but I was looking for a solution which uses chkDisplayForum from inc_func_secure.
I don't think I've missed any code mods in default.asp. There is no reference in there to F_PrivateForum or chkDisplayForum anyway, so how would the private forums not display unless it was in inc_subforums?
Look at the bottom forum "Product Reviews" here:
http://www.penturners.org/forum/default.asp?CAT_ID=4
That subforum is set hidden. Clicking on it generates the expected error message, but I'd rather it not show up.
Here's another issue: The hidden forums table header still shows when the forum is hidden.
http://www.penturners.org/forum/forum.asp?forum_id=58
Overall a great mod!< |
|
|
|
Topic |
|
sr_erick's Sub-forums MOD
