Author |
Topic |
Greg Bowman
Starting Member
USA
30 Posts |
Posted - 09 May 2001 : 16:11:51
|
Anders, congrats again.
I rev'ed up from version 2 to version 4 without any problems. There is a lot more functionality and this is much cleaner than rev 2.
A few little issues worth considering for rev 5:
1. I get emailed even if I am the author of a post (V2 did not do this so maybe I have introduced a bug) 2. I like being able to send the actual content of the post out with the notification (links are not adequate for offline users on email). I modified my V4 to work like you had it in V2. 3. It was a lot tougher to go from V2 to V4 (than from scratch). It would be great if you could find time to mark code that changed between the last rev. So the delta between V4 and V5 next time. I know this is more work, so I do not expect much. 4. A wish list of additional features: a. The ability to auto-subscribe the topic author to that topic. b. report: A mod to the members.asp so when I click on a user I can see what they subscribe to. c. admin: When I am admin the ability to change the subscriptions for a user (on a forum). d. admin: A report that lets me see the list of people subscribed to each forum. e. report: A report on most popular subscriptions to topics.
Great work, thanks!
Greg.
|
|
|
Martha2Mary
Junior Member
New Zealand
250 Posts |
Posted - 09 May 2001 : 17:09:21
|
One thing I would like to have changed/implemented would be the use of 2 images instead of the checkbox. I have tried to do this myself, but with no success whatsoever :(
Anyway, I just thought that one image could be used if you are not subscribed to that particular forum/category, and a different image (maybe the same as the first, but with a tick on it) could be used if you are subscribed. I personally feel that this would blend in better with the Snitz Forums look. Do you think that this is something that could be done?
TIA!
*If Knowledge is Power, and Power Corrupts, what hope is there for Mankind * |
|
|
Martha2Mary
Junior Member
New Zealand
250 Posts |
Posted - 09 May 2001 : 17:17:50
|
quote:
Anders, congrats again. 2. I like being able to send the actual content of the post out with the notification (links are not adequate for offline users on email). I modified my V4 to work like you had it in V2.
Hi Greg,
Would you be willing to send your modified version 4 files to me, so that my Forums will also send the content of the posts with the notification, as in version 2? My email addy is Martha2Mary@hisgrace.org.nz
Many thanks if you are able to do this!
*If Knowledge is Power, and Power Corrupts, what hope is there for Mankind * |
|
|
Anders M
Junior Member
Sweden
117 Posts |
Posted - 09 May 2001 : 17:50:46
|
I found a bug. The subscription checkbox is displayed on forum.asp even if a user is not logged on. To fix it, change line 115 in forum.asp from
if rsSubscr.BOF or rsSubscr.EOF then to
if mlev=0 or rsSubscr.BOF or rsSubscr.EOF then
-Anders M
|
|
|
Anders M
Junior Member
Sweden
117 Posts |
Posted - 09 May 2001 : 18:41:43
|
quote: There is a discussion about auto email notification when a topic is moved. When I read the discussion, I realized that my subscription database table is not updated when a topic is moved
I replaced the download zip file. It now contains the correct code. If you want to fix the bug yourself, instead of downloading the complete mod, change the following code at line 357 in post_info.asp from
'## Forum_SQL strSql = "UPDATE " & strTablePrefix & "FORUM SET " strSql = strSql & " F_TOPICS = F_TOPICS + 1 " strSql = strSql & " WHERE FORUM_ID = " & aryForum(1) my_Conn.Execute(strSql)
end if err_Msg = "" aryForum = ""
to
'## Forum_SQL strSql = "UPDATE " & strTablePrefix & "FORUM SET " strSql = strSql & " F_TOPICS = F_TOPICS + 1 " strSql = strSql & " WHERE FORUM_ID = " & aryForum(1) my_Conn.Execute(strSql)
end if '#################### Email Subscription MOD, start added code ################### 'Start bug fix strSql = "UPDATE " & strTablePrefix & "SUBSCRIPTIONS " strSql = strSql & " SET CAT_ID = " & aryForum(0) strSql = strSql & ", FORUM_ID = " & aryForum(1) strSql = strSql & " WHERE TOPIC_ID = " & Request.Form("TOPIC_ID") my_Conn.Execute(strSql) 'End bug fix '################################ End added code ################################# err_Msg = "" aryForum = ""
-Anders M
|
|
|
ahimanikya
Starting Member
22 Posts |
Posted - 09 May 2001 : 22:27:12
|
If some one use forum code or html then html tags are showing up in the mail. can't we remove all the tags before sending or can we send it in mulipart/alternative.
|
|
|
Anders M
Junior Member
Sweden
117 Posts |
Posted - 10 May 2001 : 10:05:22
|
quote: Anders, congrats again.
Thanks
quote: 1. I get emailed even if I am the author of a post (V2 did not do this so maybe I have introduced a bug)
Yes, the author get emailed if he subscribes. I could add an option in the admin interface for switching this off. But I will not release version 5 for some time now, so get back to me if you want a quick fix for stopping email to author.
quote: 2. I like being able to send the actual content of the post out with the notification (links are not adequate for offline users on email). I modified my V4 to work like you had it in V2.
This information is sent in the email: 1) An intro text that says that the email comes from your forum. 2) Author of the post. 3) URL to the post 4) The post itself. You only want 4) ?
quote: 3. It was a lot tougher to go from V2 to V4 (than from scratch). It would be great if you could find time to mark code that changed between the last rev. So the delta between V4 and V5 next time. I know this is more work, so I do not expect much.
Why not use a program like ExamDiff Pro? It will point out the delta, and make it easy upgrading the ASP files.
quote: 4. A wish list of additional features: a. The ability to auto-subscribe the topic author to that topic. b. report: A mod to the members.asp so when I click on a user I can see what they subscribe to. c. admin: When I am admin the ability to change the subscriptions for a user (on a forum). d. admin: A report that lets me see the list of people subscribed to each forum. e. report: A report on most popular subscriptions to topics.
b - e would be nice features. But a? Isn't it better to let the author choose himself?
Greg, thanks for the input. Please report how this mod works on your site, when you have had it going for some time.
Regards, -Anders M
|
|
|
Anders M
Junior Member
Sweden
117 Posts |
Posted - 10 May 2001 : 10:18:31
|
quote: Hi Greg,
Would you be willing to send your modified version 4 files to me, so that my Forums will also send the content of the posts with the notification, as in version 2?
Martha2Mary, version 4 sends the content of the post. Doesn't it for you?
|
|
|
Anders M
Junior Member
Sweden
117 Posts |
Posted - 10 May 2001 : 10:20:19
|
quote: I love this mod !! I would love to see one more feature like subscribe to All except such and such Forum/Topic. Please do consider this in version 5
Consider it considered
|
|
|
Anders M
Junior Member
Sweden
117 Posts |
Posted - 10 May 2001 : 10:38:18
|
quote: One thing I would like to have changed/implemented would be the use of 2 images instead of the checkbox.... <snip>
I like the idea. Admin configurable of course (choose checkbox v.s. image).
When the user clicks the image, we need to:
- get some ASP code running in order to update the database
- change the image
No. 1. can be done by opening a popup, like today. No. 2. can be done with JavaScript (not done today).
Another more simple solution is to reload default.asp (or forum.asp) when the user clicks the image. Then it is easy getting the ASP code running, as well as replacing the image.
The JavaScript thing would probably be neater than reloading the page. Or maybe not? Greg mentioned in another topic that the popup can be annoying. So maybe reloading the page is not a bad idea after all? Which alternative is least annoying?
|
|
|
Martha2Mary
Junior Member
New Zealand
250 Posts |
Posted - 10 May 2001 : 17:03:51
|
quote:
I like the idea. Admin configurable of course (choose checkbox v.s. image).
When the user clicks the image, we need to:
- get some ASP code running in order to update the database
- change the image
No. 1. can be done by opening a popup, like today. No. 2. can be done with JavaScript (not done today).
Another more simple solution is to reload default.asp (or forum.asp) when the user clicks the image. Then it is easy getting the ASP code running, as well as replacing the image.
The JavaScript thing would probably be neater than reloading the page. Or maybe not? Greg mentioned in another topic that the popup can be annoying. So maybe reloading the page is not a bad idea after all? Which alternative is least annoying?
Well, IMHO, the pop-up idea is fine, as how often do you actually have to subscribe? Also, it will make the code changes much easier. I think the javascript for the image changeover is fine, as long as you find one that is compatible with Netscape. I use 'onclick' image changes on my main website (http://www.hisgrace.org.nz/healing/memorials/guardianangel_ns.htm ~ just click on the Candle), and found the following code to be compatible with both IE and NS:
The actual script:
<script language="JavaScript"> <!-- function flip() { if (document.images) document.images['image1'].src = 'image_name_here.gif'; } //--></script>
HTML code for the actual onclick change:
<a href="javascript:flip()"><img src="image_name_here.gif" border="0" alt="Click here to Subscribe" name="image1"></a>
You probably already know all the above, but thought I'd share it ~ just in case
At the end of the day, do whatever you, as the person writing the code, find easier - reloading the page, or the popup. I'll be more than happy with either.
*If Knowledge is Power, and Power Corrupts, what hope is there for Mankind * |
|
|
Anders M
Junior Member
Sweden
117 Posts |
Posted - 11 May 2001 : 02:56:39
|
quote: If some one use forum code or html then html tags are showing up in the mail. can't we remove all the tags before sending or can we send it in mulipart/alternative.
You are perfectly right. We should do something about it. I prefer sending the email as plain text, since I use ChiliMail which only supports text.
I need some help here from more experienced Snitz hackers (believe it or not, I'm new in this community). I suppose lots of developers have been working with forum code before? Maybe there are som ready-to-use functions for converting between forum code / html / plain text
|
|
|
Anders M
Junior Member
Sweden
117 Posts |
Posted - 11 May 2001 : 03:52:04
|
quote: Well, IMHO, the pop-up idea is fine, as how often do you actually have to subscribe? Also, it will make the code changes much easier. I think the javascript for the image changeover is fine, as long as you find one that is compatible with Netscape.
Maybe we should also change the word "Subscribe" at the top of the column to an image? Does anyone have images we can use?
|
|
|
paoloc
Starting Member
8 Posts |
Posted - 11 May 2001 : 06:48:32
|
What about a Digest option in version 5.0?
|
|
|
Anders M
Junior Member
Sweden
117 Posts |
Posted - 11 May 2001 : 07:09:03
|
I already wrote about digest in an earlier post:
quote: Interesting feature.
But how shall it be implemented? I run my forum on a Linux server. I could set up a cron job to be executed daily. This cron job could send out the digest email to the "digest subscribers".
Does anyone have an idea of how to make a platform independent solution?
As I said, I don't know how a digest system should be implemented.
|
|
|
Topic |
|