| Author |
 Topic  |
|
ruirib
Snitz Forums Admin
Portugal
26364 Posts |
 Posted - 04 August 2012 : 03:51:22
|
It has a lot more problems, Carefree. getALevel doesn't work because the return value is never assigned.
Worse, even, if added a function call in pop_profile and you call a function that uses strSQL itself. As a result, the strSQL from the calling code, which is an update statement, gets a SELECT statement appended to it.
admin_levels.asp has multiple issues. As it is, it's simply impossible to add any new entries to the database. To be able to add then, the code that tests the mode, add to be moved to the end of the page and a parameter added to allow the mode to be tested. The sorting used in the page, which was alphabetic, adds nothing in terms of clarity. Ended up sorting by admin level and alphabetically, which makes much more sense.
With all respect for your work, if you post a mod you never tested, at least you should say it clearly in the instructions that accompany the mod. I was doing this for someone else and it cost me several hours, to understand what was going on and fix it, on all pages that has serioys. The seriousness of the errors (functions not returning values, function calls that change SQL statements being built in the calling code) is such that even a single attempt at actually testing the code would show all the issues I found and had to solve.
Ah, yes, at least an image is missing from the download. |
Snitz 3.4 Readme | Like the support? Support Snitz too |
 |
|
|
Carefree
Advanced Member
Philippines
4222 Posts |
Posted - 04 August 2012 : 13:49:03
|
Well, that's just odd. It works here, adding/deleting/editing all do what they're supposed to do. The forum admin bypasses the permissions check, other admins are stopped if their level isn't sufficient.
Changing a member's profile works properly, admin level is assigned or edited without interfering with any other values; database fields are updated properly. I changed the strSQL throughout the "inc_adminlevel.asp" to ensure no conflict exists with another page.
Changing the sorts took about 30 seconds.
Forgot the image, but fixed that. |
|
|
|
ruirib
Snitz Forums Admin
Portugal
26364 Posts |
Posted - 04 August 2012 : 14:05:35
|
| Had to change several files to get it working and I used the download from Snitzbitz. I was effectively prevented to access any admin page and couldn't edit a single profile. |
Snitz 3.4 Readme | Like the support? Support Snitz too |
|
|
|
Carefree
Advanced Member
Philippines
4222 Posts |
Posted - 04 August 2012 : 22:16:02
|
| Don't know which version you downloaded, but the bypass routine for forum admins was added in v2.1; primarily because there are so many "admin_" pages in various mods that wouldn't be included. Just adding the barebones & most common mods (avatar, events calendar, polls, etc.) put the total up near 50. |
|
|
|
ruirib
Snitz Forums Admin
Portugal
26364 Posts |
Posted - 05 August 2012 : 05:38:02
|
| I posted this on the 3rd, downloaded the version available at that time, 2.0, which had the problems I reported, all of which I fixed. Wasn't really easy, as I didn't know the mod and the documentation made no reference to even the table for the allowed pages. Anyway, I have a full working version now. |
Snitz 3.4 Readme | Like the support? Support Snitz too |
|
|
|
Carefree
Advanced Member
Philippines
4222 Posts |
Posted - 05 August 2012 : 11:07:46
|
| Well, as long as it's working; that's the main thing. If anyone else downloads a copy from now forward and experiences any issue, please post it here. |
|
|
|
IWishToLearn
Starting Member
United States
24 Posts |
Posted - 10 August 2012 : 15:39:57
|
| I'm unfortunately having all of the same problems the previous poster mentioned, except I don't have his knowledge of programming and have no idea how to fix it. I get locked out of admin options and have to run updateme repeatedly before I get access restored and I'm the Administrator. |
|
|
|
Carefree
Advanced Member
Philippines
4222 Posts |
Posted - 10 August 2012 : 18:24:48
|
| Get the latest version. |
|
|
|
IWishToLearn
Starting Member
United States
24 Posts |
Posted - 11 August 2012 : 00:49:17
|
| I just downloaded it today from the link in this thread. :/ |
|
|
|
Carefree
Advanced Member
Philippines
4222 Posts |
Posted - 11 August 2012 : 11:44:57
|
| Please get the version there right now, I rewrote the instructions from the previous author and eliminated his old files entirely. |
|
|
|
Carefree
Advanced Member
Philippines
4222 Posts |
Posted - 12 August 2012 : 21:53:18
|
| OK - I just put the version currently on SnitzBitz on a plain vanilla forum & it works fine. I had left an old version of the dbs file by accident, that's been fixed. |
|
|
|
Topic |
|
