Snitz Forums 2000
Snitz Forums 2000
Home | Profile | Register | Active Topics | Members | Search | FAQ
Username:
Password:
Save Password
Forgot your Password?

 All Forums
 Help Groups for Snitz Forums 2000 Users
 Help: MOD Implementation
 Troubles with new search
 New Topic  Topic Locked
 Printer Friendly
Author Previous Topic Topic Next Topic  

pitstraight
New Member

Australia
82 Posts

Posted - 20 January 2009 :  15:31:12  Show Profile
I installed the mod rom http://forum.snitz.com/forum/topic.asp?TOPIC_ID=67315

but I'm getting this error in IE only (works fine in Firefox)

Type mismatch: 'chkForumAccessNew'
/forums/search.asp, line 184

I don't understand why it works in one browser and not in the other - why would that be ?<

ruirib
Snitz Forums Admin

Portugal
26364 Posts

Posted - 20 January 2009 :  16:19:04  Show Profile  Send ruirib a Yahoo! Message
You will need to add the function chkForumAccessNew from the 3.4.06 version to your inc_func_common.asp.<


Snitz 3.4 Readme | Like the support? Support Snitz too
Go to Top of Page

pitstraight
New Member

Australia
82 Posts

Posted - 22 January 2009 :  06:45:09  Show Profile
I don't think that explains why it works in Firefox, but I'll do it now

Doesn't seem to be there <

Edited by - pitstraight on 22 January 2009 06:50:03
Go to Top of Page

ruirib
Snitz Forums Admin

Portugal
26364 Posts

Posted - 22 January 2009 :  09:30:17  Show Profile  Send ruirib a Yahoo! Message
Sorry, it's in inc_func_secure.asp.<


Snitz 3.4 Readme | Like the support? Support Snitz too
Go to Top of Page

markos
Starting Member

33 Posts

Posted - 26 January 2009 :  07:39:27  Show Profile
I've installed the search mod listed above, and I have few suggestions.

I think it is wrong to return all the messages that matches the search criteria in result recordset, since you don't show the messagess, but only topic titles. What happens - I have topics on my forum that are more then 100 pages long (strPageSize is set to 25). Now, when I search for some search criteria, it can be found many times in same topic (sometimes more then 100 times!). So, when I get result set for search criteria, number of result pages is at least 5-6 times greater then the number of topics that matches the criteria, and on many of the result pages there's only 1 topic listed (because it has more then 25 rows that matches the search string in it). So, basically, paging doesn't work well because it counts all the replys, but displays only topics.

Since there's no need for all the reply's, we only need unique topic_id of all topics that match the search criteria, I've changed the query a bit:

strFinalSql = "select distinct A.TOPIC_ID, A.* from (" & strSql & strSql2 & strSqlTopics & strSql31

strSql4 = ") As Dv On T.TOPIC_ID=Dv.Topic_ID) A ORDER BY A.CAT_ORDER, A.CAT_NAME, A.F_ORDER, A.F_SUBJECT, A.T_LAST_POST DESC"

And, of course, later on, we must change the numbers here (because we've added additional "distinct Topic_ID" on first position in query)

cCAT_STATUS = 1
cCAT_SUBSCRIPTION = 2
cCAT_NAME = 3
fFORUM_ID = 6
fF_SUBJECT = 7
fCAT_ID = 8
fF_SUBSCRIPTION = 9
fF_STATUS = 10
tTOPIC_ID = 11
tT_AUTHOR = 12
tT_SUBJECT = 13
tT_STATUS = 14
tT_LAST_POST = 15
tT_LAST_POST_AUTHOR = 16
tT_LAST_POST_REPLY_ID = 17
tT_REPLIES = 18
tT_UREPLIES = 19
tT_VIEW_COUNT = 20
mMEMBER_ID = 21
mM_NAME = 22
tLAST_POST_AUTHOR_NAME = 23
fF_PRIVATEFORUMS = 24
fF_PASSWORD_NEW = 25

I think this is much better solution, to avoid multiple result pages with only 1 topic listed on each page.

Further more, we could try to add an option on search, to display topics or to display messages. In first case, we could use my query and in second case the original query, because we can actually display the message containing wanted criteria. (this would be very convenient since the current way of showing only topics and not the messages can be very frustrating, when you have topics with more then 3-4 pages, you have to search manually through the pages in topic to find the reply you need. If rurib wants to do it, I could help a little...<
Go to Top of Page

HuwR
Forum Admin

United Kingdom
20584 Posts

Posted - 26 January 2009 :  08:05:42  Show Profile  Visit HuwR's Homepage
If you have suggestions for changing/improving a MOD, then could you please make a post in either the MOD Add-On Forum (W/Code) or MOD Add-On Forum (WO/Code). This forum is for help with implementing/installing mods not changing them

<
Go to Top of Page

ruirib
Snitz Forums Admin

Portugal
26364 Posts

Posted - 26 January 2009 :  16:03:29  Show Profile  Send ruirib a Yahoo! Message
There is, in fact, no search mod. The search page offered is just a replacement for the default search page, but optimized in terms of performance, just that. In all other aspects, it is similar to the default search page.

Any member can code mods and offer them. I don't plan to add changes to the current optimized search page.<


Snitz 3.4 Readme | Like the support? Support Snitz too
Go to Top of Page

markos
Starting Member

33 Posts

Posted - 27 January 2009 :  11:37:21  Show Profile
I spent whole day doing this and finally got what I've wanted - the search page that will return the messages matching search criteria insted of list of topics!

I'm tottaly exhausted and since I believe this is the final version I'm gonna use, I don't think I'll work on it anymore.
However, since there's not much work left to do, maybe someone will pick it up and create a proper mod from it (this version works ONLY on MSSQL, and has avatar, ignore post and PrivateMSG mods installed - so to use it on clean installation of snitz, one needs to strip down the avatar, pm and ignore mods and add support for mysql. It shouldn't be so difficult for anyone experienced with ASP and SQL. If needed, I can provide some support.

You can see the how it works here: http://forum.stripovi.com/search.asp (please, do select "Search Forum" and "Search by Date" to minimize the load on database and server, since the forum is not so small - more than 600.000 msgs).

The source is here: http://forum.stripovi.com/SearchModForSnitz.rar

Good luck!<

Edited by - markos on 27 January 2009 11:46:47
Go to Top of Page

Etymon
Advanced Member

United States
2385 Posts

Posted - 24 March 2009 :  15:49:59  Show Profile  Visit Etymon's Homepage
Thanks for the work markos! This looks like it lays out really nice.

LOL! Well, the Snitz member here who has the username of CareFree is kind of our self-appointed (and I say that in sincere kindness and appreciation) ... he is our hero type of "proper mod" guru kind of guy. He is usually quite thorough at taking up mods with code and little else and then adding instructions on for folks explaining how to install the mod. That's probably the guy you want since he seems to really dig that kind of thing. He has repackaged the most mods around here as of late.

Would a moderator please move this post over to either the MOD Add-On Forum (W/Code) or MOD Add-On Forum (WO/Code) forums?

Edited by - Etymon on 24 March 2009 15:52:27
Go to Top of Page
  Previous Topic Topic Next Topic  
 New Topic  Topic Locked
 Printer Friendly
Jump To:
Snitz Forums 2000 © 2000-2021 Snitz™ Communications Go To Top Of Page
This page was generated in 0.29 seconds. Powered By: Snitz Forums 2000 Version 3.4.07