Snitz Forums 2000
Snitz Forums 2000
Home | Profile | Register | Active Topics | Members | Search | FAQ
Username:
 Password:
Save Password
Forgot your Password?

 All Forums
 Help Groups for Snitz Forums 2000 Users
 Help: MOD Implementation
 Greeting Cards MOD - few bugs		  New Topic  Topic Locked
 Printer Friendly
Next Page
Author Previous Topic Topic Next Topic
Page: of 2

Andy Humm
Average Member

United Kingdom
908 Posts
Posted - 19 July 2008 :  06:22:44  Show Profile
I have noticed a few observations with the Greeting Cards MOD:
1. The bottom table labelled 'Top 5 Greeting Cards' has a few incorrect operations/links.

Firstly the five images that are displayed are the first five images stored in the database and it would be more dynamic if we pulled the Top 5 images that were sent, to represent the label.

2. Alternatively, would a better way of showing the selection of cards stored be, by pulling a random five images

3. The 'Send this Card" link under the image actually links to the category group rather than the image itself.

Is there an easier way to achieve a dynamic Top 5 Greeting Cards to be shown?

Here is the function we currently have:
Function DisplayTopCards()
Set Conn = Server.CreateObject("ADODB.Connection")
Conn.Open strConnString
rs = "SELECT * FROM " & strTablePrefix & "GREETING_CARD"
set rs = Conn.Execute (rs)

for i=1 to 5 
' note if you want more than three top cards, change this number 
If RS.EOF = False Then
Response.Write	"<td width=""20%"" align=""center"">" & vbNewLine & _
		"	<font face=""" & strDefaultFontFace & """ size=""" & strDefaultFontSize & """ color=""" & strDefaultFontColor & """>" & RS("cardname") & "</font><br />" & vbNewLine & _
		"	<a href=""greeting_cards_post_cats.asp?category=" & RS("catid") & """><img border=""1"" src=""" & RS("smallimagename") & """><br />" & vbNewLine & _
		"	<font face=""" & strDefaultFontFace & """ size=""" & strDefaultFontSize & """>Send this Card</font></a>" & vbNewLine & _
		"</td>" & vbNewLine
RS.MoveNext 
End If 
Next 
RS.Close 
End Function


Fields available in card database
Table GREETING_CARD
ID number
CARDNAME text
CATID number
IMAGENAME text
SMALLIMAGENAME text

<
Edited by - Andy Humm on 19 July 2008 06:58:35

Classicmotorcycling
Development Team Leader

Australia
2085 Posts
Posted - 19 July 2008 :  06:54:39  Show Profile
As I have ignored this same request many a time, but I will advise you, that if you want it so bad, work it out yourself.<
Cheers,

David Greening
Go to Top of Page

Andy Humm
Average Member

United Kingdom
908 Posts
Posted - 19 July 2008 :  07:09:53  Show Profile
David, its is not just me that has spotted these glitches so to speak (see other threads), I value your experience and like always, we have to learn sometime, from square one. The observations are constructive and I am sure if we all work together, not just you, with the varied techno experience, then the product will be that much better. The Greeting cards mod is very good and useful, but to iron out a few creases would put the icing on the cake! I am sure theer are others who would benefit. BTW Dave, I have been trying to 'work it out myself' but there are times I am sure you have asked for help in the past, when you get stuck!<
Go to Top of Page

Syxxamore
(Actually Andy Humm)

1 Posts
Posted - 19 July 2008 :  08:43:36  Show Profile
Classicmotorcycling, thats a bit harsh! Reading the posts regarding the Greetings Card errors Andy Humm is only trying to improve the operatability of the MOD and asking for advise. He is trying to learn too!<
Go to Top of Page

HuwR
Forum Admin

United Kingdom
20600 Posts
Posted - 19 July 2008 :  09:08:28  Show Profile  Visit HuwR's Homepage
Mr Humm, if you register again with the express purpose of barracking another member, you will find your main account locked too.<
Go to Top of Page

Andy Humm
Average Member

United Kingdom
908 Posts
Posted - 19 July 2008 :  12:40:22  Show Profile
Where is the barracking! It is courteous to correspond in an acceptable dialog. All that has occurred here, is a simple observation of errors of a MOD, that others have spotted too. Because it has been highlighted by someone who maybe not so experienced, obviously seeking solution, gets blanked in such a manner, P&Q's. I do value the input on this forum, and we can all can learn from it by the techniques and experience around. Huwr, I am sure you have asked someone in your education. Hope you can see that point of view. Thank you.<
Go to Top of Page

HuwR
Forum Admin

United Kingdom
20600 Posts
Posted - 19 July 2008 :  14:58:48  Show Profile  Visit HuwR's Homepage
registerring a second account to post the reply you posted in this forum is NOT ACCEPTABLE FORUM BEHAVIOUR, do it again and you will be barred.<
Go to Top of Page

ruirib
Snitz Forums Admin

Portugal
26364 Posts
Posted - 19 July 2008 :  15:06:38  Show Profile  Send ruirib a Yahoo! Message
quote:
Originally posted by Andy Humm

Where is the barracking! It is courteous to correspond in an acceptable dialog. All that has occurred here, is a simple observation of errors of a MOD, that others have spotted too. Because it has been highlighted by someone who maybe not so experienced, obviously seeking solution, gets blanked in such a manner, P&Q's. I do value the input on this forum, and we can all can learn from it by the techniques and experience around. Huwr, I am sure you have asked someone in your education. Hope you can see that point of view. Thank you.

When you using a mod, it falls on the mod developer the responsability to provide support. The mod author has replied, maybe not the reply you expected, but such is life! Mod authors are entitled to do that, since they post their code without any obligation. If you don't like someone's support, just don't use their mods. I certainly consider who posted a mod before I try to add it and use it!
The reply you got certainly does not justify your behavior of pretending to be someone else, to try to extract the reply you didn't get! That's the real issue here, educated post or not!
Better follow Huw's advice and do not insist. If someone comes to your help, fine.
This particular subject (meaning your behavior), is not subject to discussion. The reason that lead to you starting this topic, may be. That's the only reason for this topic to remain open, but your behavior deserved that it be closed right now.<

Snitz 3.4 Readme | Like the support? Support Snitz too
Go to Top of Page

Classicmotorcycling
Development Team Leader

Australia
2085 Posts
Posted - 19 July 2008 :  18:06:08  Show Profile
Andy, for you to ask the same thing to get the "most used Greeting Cards" in 5 different posts continuiosly is annoying to say the least, and I was trying to work out a way to get it working, so there was no need to go on about it, including you e-mailing me.

The Title of this topic and the ammount of time that you have posted wanting extra things changed with a free mod with out showing that you was trying to change it all the time suggests that it is not working. It was working when I released it, just not the way that you wanted it to work.

I was trying to work out the best way to get it to work in the background but can not be bothered now.

A starting point would be to create an extra field in the GREETING_CARD table that is updated when a greeting card is selected and call from that. Not easy to work out is it?

But as Huwr and Ruirib have said, the signing up with a second account and to reply to one of your topics with that account is NOT ACCEPTABLE FORUM BEHAVIOUR.<
Cheers,

David Greening
Go to Top of Page

Andy Humm
Average Member

United Kingdom
908 Posts
Posted - 19 July 2008 :  18:36:26  Show Profile
David, point taken and all round apologies sent. Since my first observation/request, I have had dialog from my forum users of the other additional problems and I thought, maybe wrongly, it would be better to tackle them concurrently. I have equally, been looking at ways to incorporate the 'top5' and as you say it probably needs an additional field or maybe add a countif parameter. I see that the GREETINGS_SENT uses a text field for the image name and could these be tracked ie count the frequencies of use, then sort them to extract the top five. Alternatively, would it be easier to randomise the five images so that frequent users see changes of cards rather than a static five. Is there an ID number associated with the cards. I am only providing ideas.
The mod is working extremely well and is very good but my passed on observations are suggestions.
I do appreciate the responses, not only here, but learn from other peoples development skills, thank you. I wouldn't even dream of tackling these issues a while ago, but from I have established so far, I am always trying to solve the issues first, and in deed have fixed many others without asking here. Thank you once again for you valuable time.
Andy<
Go to Top of Page

Classicmotorcycling
Development Team Leader

Australia
2085 Posts
Posted - 20 July 2008 :  04:03:12  Show Profile
Andy,

I have changed the top 5 to be random Greeting Cards. I can not work out the double images sometimes, but that is a small price to pay, as if there are quite a few images, it may not show the same image twice. Need to download the full code and replace greeting_card.asp and greeting_card_functions.asp to have it show random images..

I do not see the rest as an issue.
<
Cheers,

David Greening
Go to Top of Page

Andy Humm
Average Member

United Kingdom
908 Posts
Posted - 20 July 2008 :  11:12:54  Show Profile
Thanks David, much appreciated as you say the 'doubling' will be a minor price to pay. I have statrted to add a few more images and the randomisation seems to pick separate images. Thanking you as always Andy<
Go to Top of Page

modifichicci
Average Member

Italy
787 Posts
Posted - 20 July 2008 :  11:42:19  Show Profile  Visit modifichicci's Homepage
Cards are sent with the email of admin.
To let cards to be sent with user mail nedd to add
strSql = "SELECT M_NAME, M_EMAIL "
strSql = strSql & " FROM " & strMemberTablePrefix & "MEMBERS "
strSql = strSql & " WHERE MEMBER_ID = " & MemberId
set rsMail = my_Conn.Execute (strSql)
strSenderMail = rsMail("M_EMAIL")
rs.close
set rs = nothing

to greeting_cards_cat.asp (at top after dim sequence)
and change strSender to strSenderMail at lines 199 -200

to have right numbers of cards in cat in MySql
we need to add
rs.CursorLocation=AdUseClient

at line 56 after
SQL = "SELECT * FROM " & strTablePrefix & "GREETING_CARD WHERE CATID = " & cat<
Ernia e Laparocele
Forum di Ernia e Laparocele
Acces - MySql Migration Tutorial
Adamantine forum
Go to Top of Page

Andy Humm
Average Member

United Kingdom
908 Posts
Posted - 22 July 2008 :  04:06:48  Show Profile
I have noticed in the Greetings Card Set up when you are editting the general settings ie E-Card Application Title or the number of days to leave cards in database, if you leave either field empty the code is written to ensure the field is not empty and an appropriate error message is displayed. However, if you leave one field empty, you do get the associated error message prompting to add the data, but also you get the message underneath stating that the settings have been done and Return to Greeting Card Setup
Should this latter message be there only when all is successfully completed?

Sub general
mailserver = strMailServer
url = strForumURL
myname = Request.form("myname")
days = Request.form("days")

if mailserver = "" then
	response.write "<center><font face=""" & strDefaultFontFace & """ size=""" & strDefaultFontSize & """ color=""" & strDefaultFontColor & """>You need to put in a SMTP Server<br /><a href=""javascript:history.back()"">Back</a><br />" & vbNewLine
end if
if url = "" then
	response.write "<center><font face=""" & strDefaultFontFace & """ size=""" & strDefaultFontSize & """ color=""" & strDefaultFontColor & """>Please enter the greetings URL!<br /><a href=""javascript:history.back()"">Back</a><br />" & vbNewLine
end if
if myname = "" then
	response.write "<center><font face=""" & strDefaultFontFace & """ size=""" & strDefaultFontSize & """ color=""" & strDefaultFontColor & """>Please enter a name for the application!<br /><a href=""javascript:history.back()"">Back</a><br />" & vbNewLine
end if
if days = "" then
	response.write "<center><font face=""" & strDefaultFontFace & """ size=""" & strDefaultFontSize & """ color=""" & strDefaultFontColor & """>Please enter the amount of days to leave cards in database!<br /><a href=""javascript:history.back()"">Back</a><br />" & vbNewLine
end if

sql = "SELECT * FROM " & strTablePrefix & "GREETING_CONFIG"
rs.open sql,conn,1,3
rs.update
rs("myname") = myname
rs("days") = days

rs.update
rs.close
conn.close

response.write  "<center><font face=""" & strDefaultFontFace & """  size=""" & strDefaultFontSize & """ color=""" & strDefaultFontColor & """>Configuration settings completed<br /><br />" & vbNewLine & _
		"Return to <a href=""admin_greeting_cards.asp"">Greeting Card Setup </a><br /></font>" & vbNewLine
end sub
<
Edited by - Andy Humm on 22 July 2008 04:08:46
Go to Top of Page

Carefree
Advanced Member

Philippines
4222 Posts
Posted - 22 July 2008 :  07:31:59  Show Profile
If you replace that entire subroutine with something like this, the issue would be resolved:


Sub general
mailserver = strMailServer
url = strForumURL
myname = Request.form("myname")
days = Request.form("days")
emsg=0

if mailserver = "" then
	emsg=1
	response.write "<font face=""" & strDefaultFontFace & """ size=""" & strDefaultFontSize & """ color=""" & strDefaultFontColor & """>You need to put in a SMTP Server<br /><a href=""javascript:history.back()"">Back</a><br />" & vbNewLine
end if
if url = "" then
	emsg=1
	response.write "<font face=""" & strDefaultFontFace & """ size=""" & strDefaultFontSize & """ color=""" & strDefaultFontColor & """>Please enter the greetings URL!<br /><a href=""javascript:history.back()"">Back</a><br />" & vbNewLine
end if
if myname = "" then
	emsg=1
	response.write "<font face=""" & strDefaultFontFace & """ size=""" & strDefaultFontSize & """ color=""" & strDefaultFontColor & """>Please enter a name for the application!<br /><a href=""javascript:history.back()"">Back</a><br />" & vbNewLine
end if
if days = "" then
	emsg=1
	response.write "<font face=""" & strDefaultFontFace & """ size=""" & strDefaultFontSize & """ color=""" & strDefaultFontColor & """>Please enter the amount of days to leave cards in DB!<br /><a href=""javascript:history.back()"">Back</a><br />" & vbNewLine
end if

if emsg then
	Response.Write	"Return to <a href=""javascript:history.back()"">Go Back and Enter the Data</a><br />" & sql & "</font><p></center>" & vbNewLine
	WriteFooter
	Response.End
end if

sql = "SELECT * FROM " & strTablePrefix & "GREETING_CONFIG"
rs.open sql,conn,1,3
rs.update
rs("myname") = myname
rs("days") = days

rs.update
rs.close
conn.close
response.write	"<font face=""" & strDefaultFontFace & """ size=""" & strDefaultFontSize & """ color=""" & strDefaultFontColor & """>Done setting configuration...<br /><br />" & vbNewLine & _
		"Return to <a href=""admin_greeting_cards.asp"">Greeting Card Setup </a><br /></font>" & vbNewLine

end sub
<
Go to Top of Page

Andy Humm
Average Member

United Kingdom
908 Posts
Posted - 22 July 2008 :  08:44:53  Show Profile
quote:
Originally posted by Carefree

If you replace that entire subroutine with something like this, the issue would be resolved:


Sub general
mailserver = strMailServer
url = strForumURL
myname = Request.form("myname")
days = Request.form("days")
emsg=0

if mailserver = "" then
	emsg=1
	response.write "<font face=""" & strDefaultFontFace & """ size=""" & strDefaultFontSize & """ color=""" & strDefaultFontColor & """>You need to put in a SMTP Server<br /><a href=""javascript:history.back()"">Back</a><br />" & vbNewLine
end if
if url = "" then
	emsg=1
	response.write "<font face=""" & strDefaultFontFace & """ size=""" & strDefaultFontSize & """ color=""" & strDefaultFontColor & """>Please enter the greetings URL!<br /><a href=""javascript:history.back()"">Back</a><br />" & vbNewLine
end if
if myname = "" then
	emsg=1
	response.write "<font face=""" & strDefaultFontFace & """ size=""" & strDefaultFontSize & """ color=""" & strDefaultFontColor & """>Please enter a name for the application!<br /><a href=""javascript:history.back()"">Back</a><br />" & vbNewLine
end if
if days = "" then
	emsg=1
	response.write "<font face=""" & strDefaultFontFace & """ size=""" & strDefaultFontSize & """ color=""" & strDefaultFontColor & """>Please enter the amount of days to leave cards in DB!<br /><a href=""javascript:history.back()"">Back</a><br />" & vbNewLine
end if

if emsg then
	Response.Write	"Return to <a href=""javascript:history.back()"">Go Back and Enter the Data</a><br />" & sql & "</font><p></center>" & vbNewLine
	WriteFooter
	Response.End
end if

sql = "SELECT * FROM " & strTablePrefix & "GREETING_CONFIG"
rs.open sql,conn,1,3
rs.update
rs("myname") = myname
rs("days") = days

rs.update
rs.close
conn.close
response.write	"<font face=""" & strDefaultFontFace & """ size=""" & strDefaultFontSize & """ color=""" & strDefaultFontColor & """>Done setting configuration...<br /><br />" & vbNewLine & _
		"Return to <a href=""admin_greeting_cards.asp"">Greeting Card Setup </a><br /></font>" & vbNewLine

end sub



Carefree thanks for the new routine
I hade to slightly edit a part of it, as we had double return to enter data quotes.. see your code in red above

Sub general
mailserver = strMailServer
url = strForumURL
myname = Request.form("myname")
days = Request.form("days")
emsg=0

if mailserver = "" then
	emsg=1
	response.write "<center><font face=""" & strDefaultFontFace & """ size=""" & strDefaultFontSize & """ color=""" & strDefaultFontColor & """>You need to put in a SMTP Server<br /><br />" & vbNewLine
end if
if url = "" then
	emsg=1
	response.write "<center><font face=""" & strDefaultFontFace & """ size=""" & strDefaultFontSize & """ color=""" & strDefaultFontColor & """>Please enter the greetings URL!<br /><br />" & vbNewLine
end if
if myname = "" then
	emsg=1
	response.write "<center><font face=""" & strDefaultFontFace & """ size=""" & strDefaultFontSize & """ color=""" & strDefaultFontColor & """>Please enter a name for the application!<br /><br />" & vbNewLine
end if
if days = "" then
	emsg=1
	response.write "<center><font face=""" & strDefaultFontFace & """ size=""" & strDefaultFontSize & """ color=""" & strDefaultFontColor & """>Please enter the amount of days to leave cards in database!<br><br />" & vbNewLine
end if

if emsg then
	Response.Write	"Return to <a href=""javascript:history.back()"">enter the data</a><br />" & sql & "</font><p></center>" & vbNewLine
	Response.End
end if

sql = "SELECT * FROM " & strTablePrefix & "GREETING_CONFIG"
rs.open sql,conn,1,3
rs.update
rs("myname") = myname
rs("days") = days

rs.update
rs.close
conn.close

response.write	"<center><font face=""" & strDefaultFontFace & """ size=""" & strDefaultFontSize & """ color=""" & strDefaultFontColor & """>Configuration Settings Updated<br /><br />" & vbNewLine & _
		"Return to <a href=""admin_greeting_cards.asp"">Greeting Card Setup </a><br /></font>" & vbNewLine

end sub


Thank you as always Andy<
Go to Top of Page
Page: of 2 Previous Topic Topic Next Topic  
Next Page
 New Topic  Topic Locked
 Printer Friendly
Jump To:
Snitz Forums 2000 © 2000-2021 Snitz™ Communications Go To Top Of Page
This page was generated in 0.62 seconds. Powered By: Snitz Forums 2000 Version 3.4.07