Snitz Forums 2000
Snitz Forums 2000
Home | Profile | Register | Active Topics | Members | Search | FAQ
Username:
 Password:
Save Password
Forgot your Password?

 All Forums
 Snitz Forums 2000 DEV-Group
 DEV Bug Reports (Closed)
 Edit Url Properties		  Forum Locked  Topic Locked
 Printer Friendly
Author Previous Topic Topic Next Topic  

Image
Average Member

Canada
574 Posts
Posted - 16 July 2007 :  20:01:51  Show Profile  Visit Image's Homepage  Send Image an ICQ Message
If I Create new Web Link
and I select in Auth Type: Members Only
The Value in database is 4

But, if I Edit Url Properties of this new Web Link its show me Value 0 (All Visitors)
and if I click on "Post Changes" button, the value in database is back to 0.

post.asp line 1140

		if strRqMethod = "EditForum" or _
		strRqMethod = "EditURL" then
			ForumAuthType = fPrivateForums
		else
			ForumAuthType = 0
		end if


post.asp line 337

	if strRqMethod = "EditForum" then
		fDefaultDays = rs("F_DEFAULTDAYS")
		fForumCntMPosts = rs("F_COUNT_M_POSTS")
		fPrivateForums = rs("F_PRIVATEFORUMS")
		fPasswordNew = rs("F_PASSWORD_NEW")
	end if

	if strRqMethod = "EditForum" or _ 
	strRqMethod = "EditURL" then
		TxtSub = rs("F_SUBJECT")
		' DEM --> Added fields to get them into local variables which is a faster run
		ForumSubscription = rs("F_SUBSCRIPTION")
		ForumModeration   = rs("F_MODERATION")
		TxtMsg = rs("F_DESCRIPTION")
	end if


To fix this Bug
post.asp line 337

	if strRqMethod = "EditForum" then
		fDefaultDays = rs("F_DEFAULTDAYS")
		fForumCntMPosts = rs("F_COUNT_M_POSTS")
                'fPrivateForums = rs("F_PRIVATEFORUMS")
		fPasswordNew = rs("F_PASSWORD_NEW")
	end if

	if strRqMethod = "EditForum" or _ 
	strRqMethod = "EditURL" then
		TxtSub = rs("F_SUBJECT")
		' DEM --> Added fields to get them into local variables which is a faster run
		ForumSubscription = rs("F_SUBSCRIPTION")
		ForumModeration   = rs("F_MODERATION")
                fPrivateForums = rs("F_PRIVATEFORUMS")
		TxtMsg = rs("F_DESCRIPTION")
	end if


<
Edited by - AnonJr on 17 March 2009 19:16:53

Davio
Development Team Member

Jamaica
12217 Posts
Posted - 05 January 2008 :  17:10:31  Show Profile
Fixed in version 3.4.07.

Does anyone know what's the point of having Authorization Types "Members Only" and "Allowed Members List" for a URL? The only ones that make sense is the "Members Only (Hidden)" and "Allowed Members List (Hidden)" for a url. Because if the URL is not hidden, anyone can click it and access it, regardless if they are a member or on the allowed members list.

Feedback welcome.<
Support Snitz Forums
Go to Top of Page

modifichicci
Average Member

Italy
787 Posts
Posted - 05 January 2008 :  17:29:17  Show Profile  Visit modifichicci's Homepage
It is possible that this happens also with Members only (hidden) as the fPrivateForums is set only if I edit a forum, not a url and it is set to 0 in line 1140 for 
if strRqMethod = "EditForum" or _
		strRqMethod = "EditURL" then
			ForumAuthType = fPrivateForums
		else
			ForumAuthType = 0
		end if


because in edit url we have not the fPrivateForums value but only in edit forum case.<
Ernia e Laparocele
Forum di Ernia e Laparocele
Acces - MySql Migration Tutorial
Adamantine forum
Go to Top of Page

ruirib
Snitz Forums Admin

Portugal
26364 Posts
Posted - 05 January 2008 :  17:49:07  Show Profile  Send ruirib a Yahoo! Message
I think it's probably just a leftover from the regular forums.<

Snitz 3.4 Readme | Like the support? Support Snitz too
Go to Top of Page

Davio
Development Team Member

Jamaica
12217 Posts
Posted - 05 January 2008 :  17:52:06  Show Profile
I am not understanding what you are saying. The bug has been fixed by moving the "fPrivateForums = rs("F_PRIVATEFORUMS")" code from the "EditForum" if...then statement shown below, to the if...then statement below it.

Move the red code to the blue code.

if strRqMethod = "EditForum" then
	fDefaultDays = rs("F_DEFAULTDAYS")
	fForumCntMPosts = rs("F_COUNT_M_POSTS")
	fPrivateForums = rs("F_PRIVATEFORUMS")
	fPasswordNew = rs("F_PASSWORD_NEW")
end if

if strRqMethod = "EditForum" or _ 
strRqMethod = "EditURL" then
	TxtSub = rs("F_SUBJECT")
	' DEM --> Added fields to get them into local variables which is a faster run
	fPrivateForums = rs("F_PRIVATEFORUMS")
	ForumSubscription = rs("F_SUBSCRIPTION")
	ForumModeration   = rs("F_MODERATION")
	TxtMsg = rs("F_DESCRIPTION")
end if
Are you trying to say something else?<
Support Snitz Forums
Go to Top of Page

Davio
Development Team Member

Jamaica
12217 Posts
Posted - 05 January 2008 :  17:56:20  Show Profile
quote:
Originally posted by ruirib

I think it's probably just a leftover from the regular forums.
Alright. Will be removed.<
Support Snitz Forums
Go to Top of Page

Davio
Development Team Member

Jamaica
12217 Posts
Posted - 05 January 2008 :  18:11:49  Show Profile
To remove the "Members Only" and the "Allowed Members List" authorization type option when creating or editing a url, in post.asp, change lines 1151 - 1184 from this:
if ForumAuthType = 0 then Response.Write(" selected")
Response.Write	">All Visitors</option>" & vbNewLine & _
		"                	<option value=""4"""
if ForumAuthType = 4 then Response.Write(" selected")
Response.Write	">Members Only</option>" & vbNewLine & _
		"                	<option value=""5"""
if ForumAuthType = 5 then Response.Write(" selected")
Response.Write	">Members Only (Hidden)</option>" & vbNewLine
if strRqMethod = "Forum" or _
strRqMethod = "EditForum" then 
	Response.Write	"                	<option value=""2"""
	if ForumAuthType = 2 then Response.Write(" selected")
	Response.Write	">Password Protected</option>" & vbNewLine & _
			"                	<option value=""7"""
	if ForumAuthType = 7 then Response.Write(" selected")
	Response.Write	">Members Only & Password Protected</option>" & vbNewLine & _
			"                	<option value=""3"""
	if ForumAuthType = 3 then Response.Write(" selected")
	Response.Write	">Allowed Member List & Password Protected</option>" & vbNewLine
end if
Response.Write	"                	<option value=""1"""
if ForumAuthType = 1 then Response.Write(" selected")
Response.Write	">Allowed Member List</option>" & vbNewLine & _
		"                	<option value=""6"""
if ForumAuthType = 6 then Response.Write(" selected")
Response.Write	">Allowed Member List (Hidden)</option>" & vbNewLine
if strNTGroups = "1" then
	Response.Write	"                	<option value=""9"""
	if ForumAuthType = 9 then Response.Write(" selected")
	Response.Write	">NT Global Group</option>" & vbNewLine & _
			"                	<option value=""8"""
	if ForumAuthType = 8 then Response.Write(" selected")
	Response.Write	">NT Global Group (Hidden)</option>" & vbNewLine
end if


to this (code in blue are the areas that have been modified/added):

if ForumAuthType = 0 then Response.Write(" selected")
Response.Write	">All Visitors</option>" & vbNewLine
if strRqMethod = "Forum" or strRqMethod = "EditForum" then 
	Response.Write	"                	<option value=""4"""
	if ForumAuthType = 4 then Response.Write(" selected")
	Response.Write	">Members Only</option>" & vbNewLine
end if
Response.Write	"                	<option value=""5"""
if ForumAuthType = 5 then Response.Write(" selected")
Response.Write	">Members Only (Hidden)</option>" & vbNewLine
if strRqMethod = "Forum" or _
strRqMethod = "EditForum" then 
	Response.Write	"                	<option value=""2"""
	if ForumAuthType = 2 then Response.Write(" selected")
	Response.Write	">Password Protected</option>" & vbNewLine & _
			"                	<option value=""7"""
	if ForumAuthType = 7 then Response.Write(" selected")
	Response.Write	">Members Only & Password Protected</option>" & vbNewLine & _
			"                	<option value=""3"""
	if ForumAuthType = 3 then Response.Write(" selected")
	Response.Write	">Allowed Member List & Password Protected</option>" & vbNewLine & _
			"                	<option value=""1"""
	if ForumAuthType = 1 then Response.Write(" selected")
	Response.Write	">Allowed Member List</option>" & vbNewLine
end if
Response.Write	"                	<option value=""6"""
if ForumAuthType = 6 then Response.Write(" selected")
Response.Write	">Allowed Member List (Hidden)</option>" & vbNewLine
if strNTGroups = "1" then
	Response.Write	"                	<option value=""9"""
	if ForumAuthType = 9 then Response.Write(" selected")
	Response.Write	">NT Global Group</option>" & vbNewLine & _
			"                	<option value=""8"""
	if ForumAuthType = 8 then Response.Write(" selected")
	Response.Write	">NT Global Group (Hidden)</option>" & vbNewLine
end if

Fixed in version 3.4.07.<
Support Snitz Forums
Edited by - Davio on 05 January 2008 18:15:30
Go to Top of Page
  Previous Topic Topic Next Topic  
 Forum Locked  Topic Locked
 Printer Friendly
Jump To:
Snitz Forums 2000 © 2000-2021 Snitz™ Communications Go To Top Of Page
This page was generated in 0.12 seconds. Powered By: Snitz Forums 2000 Version 3.4.07