Snitz Forums 2000
Snitz Forums 2000
Home | Profile | Register | Active Topics | Members | Search | FAQ
Username:
Password:
Save Password
Forgot your Password?

 All Forums
 Snitz Forums 2000 DEV-Group
 DEV Bug Reports (Closed)
 Bug+Fix: Cross-Site Scripting in v3.4.05
 Forum Locked  Topic Locked
 Printer Friendly
Author Previous Topic Topic Next Topic  

tHeCrEw
Starting Member

1 Posts

Posted - 29 October 2005 :  06:23:18  Show Profile
Hello,

I would like to report a cross-site scripting bug in vulnerability in version 3.4.05. A vulnerability example is shown below.

http://Snitzforum2Kserver/post.asp?method=Topic&FORUM_ID=1&CAT_ID=1
&Forum_Title=General+chat&type="><script>alert(12345)</script>


Thanks

tHeCrEw (h4xorCrew@gmail.com)


<

Edited by - Davio on 26 September 2006 05:41:34

Davio
Development Team Member

Jamaica
12217 Posts

Posted - 29 October 2005 :  14:27:04  Show Profile
In post.asp find the following code. Should be around line 499.
"              <input name=""Type"" type=""hidden"" value=""" & Request.QueryString("type") & """>" & vbNewLine & _
Change it to this:
"              <input name=""Type"" type=""hidden"" value=""" & strRqType & """>" & vbNewLine & _
This and surrounding code looks like this:
Response.Write	">" & vbNewLine & _
		"              <input name=""ARCHIVE"" type=""hidden"" value=""" & ArchiveView & """>" & vbNewLine & _
		"              <input name=""Method_Type"" type=""hidden"" value=""" & strRqMethod & """>" & vbNewLine & _
		"              <input name=""Type"" type=""hidden"" value=""" & strRqType & """>" & vbNewLine & _
		"              <input name=""REPLY_ID"" type=""hidden"" value=""" & strRqReplyID & """>" & vbNewLine & _
		"              <input name=""TOPIC_ID"" type=""hidden"" value=""" & strRqTopicID & """>" & vbNewLine & _
		"              <input name=""FORUM_ID"" type=""hidden"" value=""" & strRqForumId & """> " & vbNewLine & _
		"              <input name=""CAT_ID"" type=""hidden"" value=""" & strRqCatID & """>" & vbNewLine

In post.asp find the following code. Should be around line 74.
if Request.QueryString("REPLY_ID") <> "" then
	if IsNumeric(Request.QueryString("REPLY_ID")) = True then
		strRqReplyID = cLng(Request.QueryString("REPLY_ID"))
	else
		Response.Redirect("default.asp")
	end if
end if
And add the following code after it:
if Request.QueryString("type") <> "" then
	if strRqMethod = "URL" or strRqMethod = "EditURL" then
		strRqType = 1
	else
		strRqType = 0
	end if
end if
This and surrounding code should look like this:
if Request.QueryString("REPLY_ID") <> "" then
	if IsNumeric(Request.QueryString("REPLY_ID")) = True then
		strRqReplyID = cLng(Request.QueryString("REPLY_ID"))
	else
		Response.Redirect("default.asp")
	end if
end if
if Request.QueryString("type") <> "" then
	if strRqMethod = "URL" or strRqMethod = "EditURL" then
		strRqType = 1
	else
		strRqType = 0
	end if
end if
strCkPassWord = Request.Cookies(strUniqueID & "User")("Pword")
<
Go to Top of Page

Davio
Development Team Member

Jamaica
12217 Posts

Posted - 29 October 2005 :  14:29:39  Show Profile
That is the easiest way to fix the problem. The "Type" variable shouldn't be needed in the url when creating a new forum or url. It can be easily determined by the "Method" variable. This will be fixed in the next Snitz Forums version.<

Support Snitz Forums
Go to Top of Page

MarcelG
Retired Support Moderator

Netherlands
2625 Posts

Posted - 29 October 2005 :  16:21:32  Show Profile  Visit MarcelG's Homepage
I'd like to say thanks to the guys from 'tHeCrEw'!
Whitehats ; gotta love them <

portfolio - linkshrinker - oxle - twitter
Go to Top of Page

taropatch
Average Member

USA
741 Posts

Posted - 30 October 2005 :  00:05:26  Show Profile
Is this the first (only) bug fix for 3.4.05?<
Go to Top of Page

Bassman
Junior Member

Netherlands
256 Posts

Posted - 30 October 2005 :  05:31:47  Show Profile  Visit Bassman's Homepage
Thanks for the update.<
Go to Top of Page

dpschaefer
Starting Member

13 Posts

Posted - 01 November 2005 :  06:47:16  Show Profile
Is there any way to make this post.asp file downloadable? I'm just thinking it would be easier for people than having them going in and editing code (not everyone is projock like Davio)...

-Dave<
Go to Top of Page

Podge
Support Moderator

Ireland
3775 Posts

Posted - 01 November 2005 :  08:08:34  Show Profile  Send Podge an ICQ Message  Send Podge a Yahoo! Message
There is no guarantee that people's post.asp is not already modified i.e. they may have mods installed, in which case they will have no choice but to apply the changes manually. There's not a lot involved in doing that anyway.<

Podge.

The Hunger Site - Click to donate free food | My Blog | Snitz 3.4.05 AutoInstall (Beta!)

My Mods: CAPTCHA Mod | GateKeeper Mod
Tutorial: Enable subscriptions on your board

Warning: The post above or below may contain nuts.
Go to Top of Page

dpschaefer
Starting Member

13 Posts

Posted - 01 November 2005 :  09:03:00  Show Profile
Actually, after adding my own mods, the robustness of adding the code is actually better. Also it doesn't take much to cut and paste, I just have to be careful. Think I answered my own question.<
Go to Top of Page

webshark
Starting Member

1 Posts

Posted - 14 November 2005 :  06:22:01  Show Profile
Hi Guys

When is the next revision of the software due? I noticed that the current version is 3.4.05 which is the one the post.asp bug effects.

Im not a user of the software yet but hopefully will be soon and want to ensure what I download is secure without possibly missing a patch.

Thanks
Paul<
Go to Top of Page

Davio
Development Team Member

Jamaica
12217 Posts

Posted - 14 November 2005 :  17:27:21  Show Profile
quote:
When is the next revision of the software due?
There is no set date at the moment.
quote:
I noticed that the current version is 3.4.05 which is the one the post.asp bug effects. Im not a user of the software yet but hopefully will be soon and want to ensure what I download is secure without possibly missing a patch.

There is only 1 security bug in the 3.4.05 version which is this one you are viewing. If you are ever in doubt, just keep and eye on the security forum: http://forum.snitz.com/forum/forum.asp?FORUM_ID=118<

Support Snitz Forums
Go to Top of Page

Davio
Development Team Member

Jamaica
12217 Posts

Posted - 07 March 2006 :  19:47:04  Show Profile
Fixed in version 3.4.06<

Support Snitz Forums
Go to Top of Page
  Previous Topic Topic Next Topic  
 Forum Locked  Topic Locked
 Printer Friendly
Jump To:
Snitz Forums 2000 © 2000-2021 Snitz™ Communications Go To Top Of Page
This page was generated in 0.18 seconds. Powered By: Snitz Forums 2000 Version 3.4.07