Author |
Topic |
Doughnut
Starting Member
United Kingdom
40 Posts |
Posted - 14 April 2005 : 15:23:19
|
Alright there,
I've installed this and it works great but I've got something a little bit wrong, perhaps in my topic.asp...
The opening post of every topic is duplicated in bold - see here for an example - http://www.carp-uk.net/forum/topic.asp?TOPIC_ID=15870
Any ideas what I've mangled here, would it be in my topic.asp??
Thanks. |
Edited by - Doughnut on 14 April 2005 16:26:29 |
|
masterao
Senior Member
Sweden
1678 Posts |
Posted - 14 April 2005 : 16:34:04
|
Im not sure what got wrong, but it is definitely in topic.asp. If you post a link to a text-version of your topic.asp, I can take a look. |
Jan =========== FR Portal Forums | Active Users 4.0.20 Mod |
|
|
Doughnut
Starting Member
United Kingdom
40 Posts |
Posted - 14 April 2005 : 16:40:46
|
Thanks Masterao here's a link to the topic.txt
Very good mod by the way, just what I needed |
|
|
masterao
Senior Member
Sweden
1678 Posts |
Posted - 14 April 2005 : 17:34:11
|
It is the poll mod which causes the duplication of the post.
Instead for following the readme-file for Sub GetFirst() in topic.asp, try the following (Im not able to test this, so it might need some additional changes). First, remove all changes for the Ignore Post mod in Sub GetFirst(). The other changes in topic.asp will work as is.
When you have done that, look for the following around line 1150:quote:
' End of Code added for Full Moderation
Response.Write " <hr noshade size=""" & strFooterFontSize & """></td>" & vbNewLine & _
" </tr>" & vbNewLine & _
" <tr>" & vbNewLine
'####################################### Poll Mod ##################################
'Remember to remove the &_ from the end of the line above.
Add the following directly below that:quote:
'## Ignore Post mod
if strIgnorePost = "1" then
boolIgnorePost = ChkIgnoreList(arrIgnoreMemberList, TMember_ID)
end if
'## Ignore Post mod
Then look for the following block of code (there are three instances of it):quote:
if Request.QueryString("SearchTerms") <> "" then
Response.Write SearchHiLite(formatStr(Topic_Message))
else
Response.Write formatStr(Topic_Message)
end if
Replace each one with the following:quote:
'### Ignore Post mod
if Request.QueryString("SearchTerms") <> "" then
if strIgnorePost = "1" then
if boolIgnorePost then
WriteIgnPostLinks TopicID, 0, TMember_ID
else
Response.Write SearchHiLite(formatStr(Topic_Message))
end if
else
Response.Write SearchHiLite(formatStr(Topic_Message))
end if
else
if strIgnorePost = "1" then
if boolIgnorePost then
WriteIgnPostLinks TopicID, 0, TMember_ID
else
Response.Write formatStr(Topic_Message)
end if
else
Response.Write SearchHiLite(formatStr(Topic_Message))
end if
end if
'### Ignore Post mod
That should make it work it the poll mod and fix the duplication of the post, but I cannot be 100% sure as I don't have the poll mod installed on my test-forum.
quote: Originally posted by Doughnut
Very good mod by the way, just what I needed
Thank you. |
Jan =========== FR Portal Forums | Active Users 4.0.20 Mod |
|
|
Doughnut
Starting Member
United Kingdom
40 Posts |
Posted - 14 April 2005 : 18:18:23
|
Still trying... a bit lost for a minute so I'm backtracking |
|
|
Doughnut
Starting Member
United Kingdom
40 Posts |
Posted - 14 April 2005 : 18:29:35
|
Ello,
I thought it was me but I've been over this a few times now when I add the new code as above topic.asp stops working, everything goes black....still could be me though
Also I found 4 instances of this rather then three: quote: if Request.QueryString("SearchTerms") <> "" then Response.Write SearchHiLite(formatStr(Topic_Message)) else Response.Write formatStr(Topic_Message) end if
Not sure I'm cut out for this stuff, I didn't realise how much the poll mod would complicate things |
Edited by - Doughnut on 15 April 2005 03:25:41 |
|
|
masterao
Senior Member
Sweden
1678 Posts |
|
Doughnut
Starting Member
United Kingdom
40 Posts |
Posted - 15 April 2005 : 11:48:41
|
You're a gentleman |
|
|
masterao
Senior Member
Sweden
1678 Posts |
Posted - 15 April 2005 : 14:00:31
|
I used the topic.asp-version you linked to and I have now made the changes. You can find it here, topic.asp. Test it and let me know how it works. If it behaves the same as when you made the changes, do you have a backup of topic.asp without the Ignore Post mod? If so, post a link to a text-version of it. I'll take then take a look at adding the mod from scratch.
The poll mod requries a lot of changes, and it can cause problems with some mods. It is a good mod, though, so it is worth the challenge IMO . |
Jan =========== FR Portal Forums | Active Users 4.0.20 Mod |
|
|
Doughnut
Starting Member
United Kingdom
40 Posts |
Posted - 15 April 2005 : 14:45:28
|
I've no idea what you've done but it looks very promising.... I'll do some testing |
|
|
masterao
Senior Member
Sweden
1678 Posts |
|
Doughnut
Starting Member
United Kingdom
40 Posts |
Posted - 15 April 2005 : 14:58:31
|
The poll mod works and my ignorelist works at the same time, I'm just waiting for one of the ordinary users to test their ignore list for me... I'll let you know soon |
|
|
Doughnut
Starting Member
United Kingdom
40 Posts |
Posted - 15 April 2005 : 15:06:07
|
Yes you are a genius I'd probably best not ask what I did wrong as I probably wouldn't understand anyway |
Edited by - Doughnut on 15 April 2005 15:07:24 |
|
|
masterao
Senior Member
Sweden
1678 Posts |
Posted - 15 April 2005 : 15:26:20
|
Far from a genius, Im afraid. Im just a Snitz-learned programmer .
I split up the changes for the getfirst sub, and applied the same code in three places (I think you counted the first addition of the ignore post mod as one). You can compare the files, if you have the previous version of topic.asp left. |
Jan =========== FR Portal Forums | Active Users 4.0.20 Mod |
|
|
Doughnut
Starting Member
United Kingdom
40 Posts |
Posted - 15 April 2005 : 15:34:19
|
Yea I saved the old file and I'll have a look... Thanks very much for this I've been asked for this feature by a good few members and this one works very well, I'm very grateful thanks |
|
|
masterao
Senior Member
Sweden
1678 Posts |
|
Topic |
|