| Author |
 Topic  |
|
|
Shaggy
Support Moderator
Ireland
6780 Posts |
 Posted - 15 March 2005 : 08:11:15
|
Find the following on line 983 of inc_func_common.asp: ElseIf UCase(Left(strArray2(0), 6)) = "file:///" Then Replace it with the following: ElseIf UCase(Left(strArray2(0), 8)) = "file:///" Then |
 Search is your friend
“I was having a mildly paranoid day, mostly due to the
fact that the mad priest lady from over the river had
taken to nailing weasels to my front door again.” |
Edited by - Davio on 18 March 2005 10:05:33 |
|
|
Davio
Development Team Member
Jamaica
12217 Posts |
Posted - 15 March 2005 : 11:47:58
|
Why should users do this Shaggy? What's the bug?
You only provided a fix but no bug. |
Support Snitz Forums
|
Edited by - Davio on 15 March 2005 11:48:21 |
 |
|
|
Shaggy
Support Moderator
Ireland
6780 Posts |
Posted - 15 March 2005 : 12:15:25
|
In the original code, it's checking if the first 6 chracaters from the left of strArray2(0) are equal to file:/// which can never be true as file:/// is 8 characters long so the check should be to see if the first 8 characters from the left of strArray2(0) are equal to file:///
|
Search is your friend
“I was having a mildly paranoid day, mostly due to the
fact that the mad priest lady from over the river had
taken to nailing weasels to my front door again.” |
|
|
|
Davio
Development Team Member
Jamaica
12217 Posts |
|
|
Shaggy
Support Moderator
Ireland
6780 Posts |
Posted - 16 March 2005 : 08:51:35
|
Hmmm ... strange; no example, unfortunately, as I've modified my ReplaceURLs function heavily and removed edit_hrefs altogether - I just spotted it while breezing through a fresh copy of inc_func_common.asp for the "Clipped URLs" topic. Perhaps it's already been fixed here? There's another occurence of it on line 1007, by the way.
|
Search is your friend
“I was having a mildly paranoid day, mostly due to the
fact that the mad priest lady from over the river had
taken to nailing weasels to my front door again.” |
|
|
|
Davio
Development Team Member
Jamaica
12217 Posts |
Posted - 16 March 2005 : 13:48:43
|
Ok so basically you saw the code and figured it looks incorrect. Not that you tested it and found that it doesn't work.
I'll try it on a fresh copy of the code and see if there are any problems. But I doubt it though.  |
Support Snitz Forums
|
|
|
|
Shaggy
Support Moderator
Ireland
6780 Posts |
Posted - 18 March 2005 : 06:31:07
|
Um ... yeah  Logic dictated it shhouldn't work as a 6 character string can't equal an 8 chracter one but if it works, it works and we can pretend like I never mad this post! 
|
Search is your friend
“I was having a mildly paranoid day, mostly due to the
fact that the mad priest lady from over the river had
taken to nailing weasels to my front door again.” |
|
|
|
Davio
Development Team Member
Jamaica
12217 Posts |
Posted - 18 March 2005 : 10:03:44
|
Tested it with a clean 3.4.05 version and no problems either.
So I'll change this to not being a bug. |
Support Snitz Forums
|
|
|
|
Shaggy
Support Moderator
Ireland
6780 Posts |
Posted - 18 March 2005 : 10:29:36
|
Okie-dokie
That's a weird one!
|
Search is your friend
“I was having a mildly paranoid day, mostly due to the
fact that the mad priest lady from over the river had
taken to nailing weasels to my front door again.” |
|
|
|
-gary
Development Team Member
406 Posts |
Posted - 18 March 2005 : 12:01:05
|
| A bug would be something that causes unexpected behaviour. This is just an error that happens to work correctly. |
KawiForums.com
 |
|
|
|
Shaggy
Support Moderator
Ireland
6780 Posts |
Posted - 23 March 2005 : 06:26:20
|
Gah! I'm an idiot! The reason, of course, that it works correctly is thanks to the final part of that if statement which parses any URIs that don't match any of the other clauses in the if statement. Which makes me wonder whether all those elseifs are really necessary; could we not do away with all those checks excepting the ones for [img] and @?
|
Search is your friend
“I was having a mildly paranoid day, mostly due to the
fact that the mad priest lady from over the river had
taken to nailing weasels to my front door again.” |
|
|
| |
Topic |
|
Topic Locked
