Author |
Topic |
jay_v
New Member
85 Posts |
Posted - 17 October 2002 : 09:29:48
|
If the Authorization Type is set to Members Only or Allowed Member List. |
|
HuwR
Forum Admin
United Kingdom
20584 Posts |
Posted - 18 October 2002 : 06:49:43
|
What version are you using ? I'm pretty sure we would know if this was a problem |
|
|
ruirib
Snitz Forums Admin
Portugal
26364 Posts |
Posted - 18 October 2002 : 06:51:21
|
Yes, but I guess that's quite that unsual. As a guest you can see members only or Allowed Member's list forums in default.asp. If you want to avoid that, change the Auth type to Allowed Member List (Hidden). I do agree that the topics should not show, anyway. |
Snitz 3.4 Readme | Like the support? Support Snitz too |
|
|
xstream
Junior Member
242 Posts |
Posted - 18 October 2002 : 07:50:01
|
quote: Originally posted by HuwR
What version are you using ? I'm pretty sure we would know if this was a problem
Current Version.
I have the same problem. I had to set my forums to hidden. They were on password protect, and someone said that he could see the subject titles but could not go in.
X |
Edited by - xstream on 18 October 2002 10:43:21 |
|
|
David K
Junior Member
494 Posts |
Posted - 17 December 2002 : 15:46:36
|
it seems like it's the same in search.asp zbenggg found it |
|
|
RichardKinser
Snitz Forums Admin
USA
16655 Posts |
Posted - 17 December 2002 : 19:11:37
|
found what? No one has ever shown an example of there being a problem. Can anyone view hidden forums on this website? If so, I'm sure we would have heard about it by now. |
|
|
jay_v
New Member
85 Posts |
Posted - 17 December 2002 : 19:54:11
|
Not hidden forums, Richard, but Members Only or Allowed Member List forums. The forum title appears on default.asp, which is fine, but shouldn't the topic titles be hidden on active.asp? |
|
|
RichardKinser
Snitz Forums Admin
USA
16655 Posts |
Posted - 17 December 2002 : 20:36:29
|
that is why we have Members Only (Hidden) and Allowed Member List (Hidden) |
|
|
Ameriscot
Starting Member
21 Posts |
Posted - 18 December 2002 : 01:47:57
|
I have found that in the statistics report of active topics (don't know terminology for this) on my site it will include hidden topics in the count, but when you go to active.asp, it only shows the topics that are not hidden. For example, on default.asp, it could say "There are 4 active topics since your last visit", but when you click on the link, it shows you only 2 topics indicating that there are a further two topics in hidden forums. |
|
|
RichardKinser
Snitz Forums Admin
USA
16655 Posts |
Posted - 18 June 2003 : 03:55:57
|
The way it works now is because we were trying to reduce the # of database calls for each page. But, even though we were able to decrease the # of database calls, we did lose some of the functionality that was there before.
I agree that this needs to be looked at. We might need to write a new function to handle things the way they were handled before. We should be able to copy the chkForumAccess function, and feed it these additional values: F_PRIVATEFORUMS, F_SUBJECT, F_PASSWORD_NEW so that we wouldn't need to have a new database call for each forum there is. |
|
|
RichardKinser
Snitz Forums Admin
USA
16655 Posts |
Posted - 18 June 2003 : 05:29:50
|
ok, here is what I have come up with so far, it should take care of all circumstances:function chkForumAccessNew(fPrivateForums,fFPasswordNew,fForum_Subject,fForum_ID,UserNum)
if MemberID = UserNum then
if mLev < 1 then
chkForumAccessNew = false
elseif mLev = 3 then
chkForumAccessNew = true
elseif mLev = 4 then
chkForumAccessNew = true
exit function
end if
end if
dim Users
dim MatchFound
Select case fPrivateForums
case 0
chkForumAccessNew = true
case 1, 6 '## Allowed Members List
if isAllowedMember(fForum_ID,UserNum) = 1 then
chkForumAccessNew = true
else
chkForumAccessNew = false
end if
case 2 '## password
select case Request.Cookies(strUniqueID & "Forum")("PRIVATE_" & fForum_Subject)
case fFPasswordNew
chkForumAccessNew = true
case else
chkForumAccessNew = false
end select
case 3 '## Either Password or Allowed Members List
if isAllowedMember(fForum_ID,UserNum) = 1 then
chkForumAccessNew = true
else
chkForumAccessNew = false
end if
if not(chkForumAccessNew) then
select case Request.Cookies(strUniqueID & "Forum")("PRIVATE_" & fForum_Subject)
case fFPasswordNew
chkForumAccessNew = true
case else
chkForumAccessNew = false
end select
end if
case 7 '## Members or Password
if Usernum = -1 or Usernum = "" then
select case Request.Cookies(strUniqueID & "Forum")("PRIVATE_" & fForum_Subject)
case fFPasswordNew
chkForumAccessNew = true
case else
chkForumAccessNew = false
end select
else
chkForumAccessNew = true
end if
case 4, 5 '## Members only
if Usernum = -1 or Usernum = "" then
chkForumAccessNew = false
else
chkForumAccessNew = true
end if
case 8, 9 '## NT Global Groups
test="test db"
chkForumAccessNew = false
if strAuthType="db" then
chkForumAccessNew = true
end if
NTGroupSTR = Split(Session(strCookieURL & "strNTGroupsSTR"), ", ")
for j = 0 to ubound(NTGroupSTR)
NTGroupDBSTR = Split(fFPasswordNew, ", ")
for i = 0 to ubound(NTGroupDBSTR)
if NTGroupDBSTR(i) = NTGroupSTR(j) then
chkForumAccessNew = True
exit function
end if
next
next
case else
chkForumAccessNew = true
end select
end function Then active.asp just needs to be modified to use this new function instead of ChkDisplayForum, and the whole section that determines the value of canView can be removed.
If anyone wants to test it, I'd appreciate knowing whether it works like it should or not. |
|
|
Nikkol
Forum Moderator
USA
6907 Posts |
Posted - 18 June 2003 : 07:15:49
|
I might test it for you Richard, but it won't be until later today. One question though. Why is UserNum used as check rather than mlev, or does it matter? |
Nikkol ~ Help Us Help You | ReadMe | 3.4.03 fixes | security fixes ~ |
|
|
RichardKinser
Snitz Forums Admin
USA
16655 Posts |
Posted - 18 June 2003 : 07:18:49
|
Usernum in this case is the same as MemberID. If a person is logged in, then their Usernum/MemberID will have a value equal to the MEMBER_ID. If the person isn't logged in, then Usernum/MemberID will equal -1. |
|
|
Nikkol
Forum Moderator
USA
6907 Posts |
|
RichardKinser
Snitz Forums Admin
USA
16655 Posts |
Posted - 18 June 2003 : 07:23:47
|
I suppose it could, you get the same result either way. I just prefer to check for MemberID rather than mLev. This is basically just a copy of the chkForumAccess function, all I did was strip out the irrelavant parts. |
|
|
Nikkol
Forum Moderator
USA
6907 Posts |
|
Topic |
|