quote:

---

Originally posted by davemaxwell

The problem with that is like in the search page, you can search just one forum, which is passed in the querystring. But the rest comes from the form (I think, don't have the code in front of me - the forumID might get moved into a form field before searching...). .

---

quote:

---

What I would prefer is a function that searches the querystring first, then if nothing is there, it hits the form. Just so it only hits those two object types and not all eight

---

sub InitRequestVars()
    dim objRequest
    if Request.QueryString <> "" then 
     Set objRequest = Request.QueryString
    else
     Set objRequest = Request.Form
    end if

dim SortMethod, strSortMethod, strSortMethod2 
dim strMode
dim SearchName
dim srchUName, srchFName, srchLName, srchInitial

if ((Request.Form = "") And (Request.QueryString = "")) then
 strMode = "" : SearchName = ""
 srchUName = "" : srchFName = "" 
 srchLName = "" : srchInitial = ""
else
 Call InitRequestVars()
end if

sub InitRequestVars()
    dim objRequest
    if Request.Form("mode") = "search" then 
     Set objRequest = Request.Form
    else
     Set objRequest = Request.Querystring
    end if
    SortMethod = Trim(objRequest("method"))
    strMode = (objRequest("mode"))
    SearchName = objRequest("M_NAME")
    srchUName = objRequest("UserName")
    srchFName = objRequest("FirstName")
    srchLName = objRequest("LastName")
    srchInitial = objRequest("INITIAL")
    Set objRequest = Nothing
    Rem -Sort Method
    if SortMethod <> "" then
    	SortMethod = Trim(chkString(SortMethod, "SQLString"))
    	strSortMethod = "&method=" & SortMethod
    	strSortMethod2 = "?method=" & SortMethod
    end if
    strMode = Trim(chkString(strMode, "SQLString"))
    if strMode <> "search" then strMode = ""
    Rem -Search For
    SearchName = Trim(chkString(SearchName, "SQLString"))
    Rem -Find Match in Username
    if srchUName <> "" then srchUName = CheckNumeric(srchUName, "1")
    Rem -Find Match in FirstName
    if srchFName <> "" then srchFName = CheckNumeric(srchFName, "0")
    Rem -Find Match in LastName
    if srchLName <> "" then srchLName = CheckNumeric(srchLName, "0")
    Rem -Match Initial
    if srchInitial <> "" then srchInitial = CheckNumeric(srchInitial, "0")
end sub

function CheckNumeric(lngNumber, strNumber)
    if IsNumeric(lngNumber) then 
     CheckNumeric = cLng(lngNumber)
    else
     CheckNumeric = strNumber
    end if
end function

quote:

---

quote:

---

SearchName = trim(chkString(Request("M_NAME"), "SQLString"))
if SearchName = "" then
SearchName = trim(chkString(Request.Form("M_NAME"), "SQLString"))
end if

---

Uhhmmmm...if it can't find it in the generic request object on the first check, it's not going to find it in the request.form object since the generic checks request.form.

---

quote:

---

Originally posted by HuwR

...That was the point I was trying to make, if you do this
SearchName = trim(chkString(Request("M_NAME"), "SQLString"))
then the if then statement is just a waste of code.

---

quote:

---

Originally posted by GauravBhabu

Oh Yes, that will be good also and can be implemented through out the forum.

---

quote:

---

Don't over use it though its still adds no benefits if ....

---

quote:

---

For items not in Request.Cookies, Request.Form, Request.QueryString, or Request.ClientCertificate, there is an implicit call to Request.ServerVariables. The Request.ServerVariables collection is much slower than the other collections.

---

response.write Request("HTTP_USER_AGENT")

quote:

---

All variables can be accessed directly by calling Request(variable) without the collection name. In this case, the Web server searches the collections in the following order.

QueryString
Form
Cookies
ClientCertificate
ServerVariables

---

quote:

---

Originally posted by work mule


As long as the item exists, it won't go through to the Request.ServerVariables collection...As long as the entry exists, it won't check the next collection nor make it down to the ServerVariable collection.

---

quote:

---

Something evil...
If someone knew that the page your forms posted to did not specifically check for the forms collection [Request.Form("")], they could override all of your form values by recreating your form post via the querystring...

---

quote:

---

So it's not so much an issue of performance, but integrity. If you know you're value is going to be in the form collection, look for it there. If you don't, someone could mess around and add it to the querystring and anything in the form collection would be ignored with a basic Request("") reference.

---

quote:

---

Originally posted by work mule


Something evil...
If someone knew that the page your forms posted to did not specifically check for the forms collection [Request.Form("")], they could override all of your form values by recreating your form post via the querystring...
...If you don't, someone could mess around and add it to the querystring and anything in the form collection would be ignored with a basic Request("") reference.

---

sub InitRequestVars()
    dim objRequest
    if Request.Form("mode") = "search" then 
     Set objRequest = Request.Form
    else
     Set objRequest = Request.Querystring
    end if