Snitz Forums 2000 - (v3.4.03) BUG + FIX: search.asp

Snitz Forums 2000

Username:	Password:
Save Password
Forgot your Password?

All Forums

Snitz Forums 2000 DEV-Group

DEV Bug Reports (Closed)

(v3.4.03) BUG + FIX: search.asp

Forum Locked

Topic Locked

Printer Friendly

Author

Topic

ruirib
Snitz Forums Admin

Portugal
26364 Posts

Posted - 01 October 2002 : 08:52:21

Just found out that when you specify a date limit for the posts to be searched for, only the topic dates are being included. So a reply with a different date than the topic date will be left out of the records to be searched, contrary to what I think should be expected.

To fix this, change line# 298, search.asp:


strSql3 = strSql3 & " AND (T.T_DATE > '" & DateToStr(dateadd("d", -dt, strForumTimeAdjust)) & "')"

Replace it by


strSql3 = strSql3 & " AND ( (T.T_DATE > '" & DateToStr(dateadd("d", -dt, strForumTimeAdjust)) & "') " 
strSql3 = strSql3 & "OR (R.R_DATE > '" & DateToStr(dateadd("d", -dt, strForumTimeAdjust)) & "') ) "

Snitz 3.4 Readme | Like the support? Support Snitz too

Edited by - Davio on 07 March 2003 11:17:51

GauravBhabu
Advanced Member

4288 Posts

Posted - 01 October 2002 : 16:46:04

The second will work fine. T_LAST_POST is updated whenever a topic or reply is posted or edited.

Edited by - GauravBhabu on 01 October 2002 17:09:57

RichardKinser
Snitz Forums Admin

USA
16655 Posts

Posted - 01 October 2002 : 17:10:28

we are not searching for posts with a "Last Post Date", the fix will be the first one. Since this post as a " + FIX" in the title, it only confuses users when you start talking about alternatives. There should only be the "FIX" and that's it.

ruirib
Snitz Forums Admin

Portugal
26364 Posts

Posted - 01 October 2002 : 18:59:45

Ok, I removed the second one, since the first is the one I think works as expected.

Gaurav, I think using T_LAST_POST can be misleading. Imagine a topic 4 months old, that somewhere in its contents has the keyword being searched for. Now imagine that after these four months you have a reply to it, where the keyword is not used. If you search for posts with the keyword, say for the last seven days, a day or two after this last reply has been made, the topic will appear in the result set even if the reply that complies with the time criteria does not have the keyword being searched for. So, IMO, this would lead to the topic erroneously being included in the result set.
Using T_DATE or R_DATE you are indeed ensuring that you have a post that contains the keyword and complies with the date requirements.

Snitz 3.4 Readme | Like the support? Support Snitz too

GauravBhabu
Advanced Member

4288 Posts

Posted - 01 October 2002 : 20:14:43

quote:
Originally posted by RichardKinser

...Since this post as a " + FIX" in the title, it only confuses users when you start talking about alternatives. There should only be the "FIX" and that's it.

ruirib, to avoid the confusion to users and discuss it further, I have posted at http://forum.snitz.com/forum/topic.asp?TOPIC_ID=36195.

Davio
Development Team Member