| Author |
 Topic  |
|
|
Schwanke
New Member
77 Posts |
 Posted - 27 August 2002 : 01:04:37
|
Its mainly just color but it seems to be doing the same 'bug' that haunts some of the lesser used pages of snitz.
You chose to use the default color font on the forum background colors. On my system the two schemes are contrasting enough that that combination is nasty and unreadable.
It really should be the forum font color on the forum background.
I see this in the include file that puts it on the default page. (Because its using the wrong link colors too) and I see it on the members list (because its using the wrong link colors there too)
Ill try to post the fixes if I can figure any out..
|
<>< |
|
|
Schwanke
New Member
77 Posts |
Posted - 27 August 2002 : 01:06:48
|
Ohh I also forgot to mention that the readme is off in several places too. The code seems to have changed since the last time the readme was updated.
|
<>< |
 |
|
|
Schwanke
New Member
77 Posts |
Posted - 27 August 2002 : 01:12:56
|
From the readme you have:
-----------------------------------------
so now it looks like this:
next '## Next Category
end if
if strShowStatistics = "1" then
WriteStatistics
end if
%>
<!--#include file="privatemess.asp"-->
<%
if strShowStatistics = "1" then
WriteStatistics
end if
This would dislay the statistics twice and I dont think thats what you want??
Also
The following:
quote:
on line #515 find this code:
rs.close
if ((intReplycount + intPostCount + intA_Replycount + intA_PostCount) = 0) then
insert the following on line #643 of pop_delete.asp:
'## Forum_SQL - Delete Private Messages that the user has sent or received
strSql = "DELETE FROM " & strTablePrefix & "PM "
strSql = strSql & " WHERE " & strTablePrefix & "PM.M_TO = " & Member_ID
strSql = strSql & " OR " & strTablePrefix & "PM.M_FROM = " & Member_ID
my_Conn.Execute(strSql)
it should now look like this:
rs.close
'## Forum_SQL - Delete Private Messages that the user has sent or received
strSql = "DELETE FROM " & strTablePrefix & "PM "
strSql = strSql & " WHERE " & strTablePrefix & "PM.M_TO = " & Member_ID
strSql = strSql & " OR " & strTablePrefix & "PM.M_FROM = " & Member_ID
my_Conn.Execute(strSql)
if ((intReplycount + intPostCount + intA_Replycount + intA_PostCount) = 0) then
I dont understand how to follow this. The first one says find this code then never does anything with it. The second does find the code but the code found doesnt match precisely the code listed here. (The second code sort of has the first code in it but its missing the set rs = nothing line thats really in the code. |
<>< |
|
|
|
Schwanke
New Member
77 Posts |
Posted - 27 August 2002 : 01:17:42
|
OK fixed the first bug with the color scheme. Needed to change in line 76 of privatemess:
" <td valign=""top"" bgcolor=""" & strForumCellColor & """ colspan=""" & sGetColspan(6,5) & """><font face=""" & strDefaultFontFace & """ size=""" & strDefaultFontSize & """ color=""" & strForumFontColor & """><a href=""pm_view.asp"">Inbox</a></font>" & vbNewLine
to
" <td valign=""top"" bgcolor=""" & strForumCellColor & """ colspan=""" & sGetColspan(6,5) & """><font face=""" & strDefaultFontFace & """ size=""" & strDefaultFontSize & """ color=""" & strForumFontColor & """><span class=""spnMessageText""><a href=""pm_view.asp"">Inbox</a></span></font>" & vbNewLine
The spnmessagetext gives it the right link colors.
|
<>< |
|
|
|
Schwanke
New Member
77 Posts |
Posted - 27 August 2002 : 01:21:30
|
in pm_view.asp line 121 I changed:
" <td><font color=""" & strForumFontColor & """ face=""" & strDefaultFontFace & """ size=""4""><b>" & strDBNTUserName & "'s Inbox</b></font></td>" & vbNewLine
Response.Write
to
" <td><font color=""" & strDefaultFontColor & """ face=""" & strDefaultFontFace & """ size=""4""><b>" & strDBNTUserName & "'s Inbox</b></font></td>" & vbNewLine
Response.Write
Because the 'username inbox' happens outside of the actual forum messages it needs to be the default font color and not the forum font color. That way it matches the colors that are at the top of the page.
(This one may not be a 'bug' but its a problem in my system because of my chosen contrasting color schemes) |
<>< |
|
|
|
Schwanke
New Member
77 Posts |
Posted - 27 August 2002 : 02:18:45
|
Moved to just make this one huge message.
I hope I am not offending the author by doing all this. These are just the mods i am having to make for my system that I figure someone else would have to use as well in my situation.
Umm. Ive come to the conclusion reached at the end of this message that the mod wasnt complete when it was released. The privateread file seems to be the coder's own website file. its a got an include to their forum's menue (thats not in the distro) and a hard link to the skeptics forum. :)
Sorry this message is a mess but its me taking notes while I do this. I hope its atleast partially helpful to someone.
Same thing for the 'outbox' as inbox on line 233 of pm_view
The following is personal preference but I changed line 135 of privatesend.asp to the following:
function pmmembers() { var MainWindow = window.open ("pm_pop_members.asp", "","toolbar=no,location=no,menubar=no,scrollbars=yes,width=300,height=500,top=100,Left=100,resizeable=yes,status=no");
Thats because the intial size contraints are wrong on my system (not sure if thats everyone, ill ask my users). But for me it has to be 300 wide to be able to display properly.
There is also another issue and that is that 'resizeable' is spelled wrong. :P Its supposed to be resizable based on what the microsft documentation says. With the way its spelled now, on my system atleast, I am not able to change the dimensions. Its locked. But if I make it resizable instead of resizeable it always makes the window huge and doesnt obey the size contstraints. But that could be my screwy window manager too. Ive had it do other weird thigns with IE.
pm_pop_members.asp line 300 changed to:
" <td bgcolor=""" & CColor & """><font face=""" & strDefaultFontFace & """ size=""" & strDefaultFontSize & """><span class=""spnMessageText""><a href=""pop_profile.asp?mode=display&id=" & rs("MEMBER_ID") & """ target=""_blank"">" & ChkString(rs("M_NAME"),"display") & "</a></span> <a href=""""><img src=""icon_pm1.gif"" width=""15"" height=""15"" alt=""Send Message"" border=""0"" onClick=""opener.document.PostTopic.sendto.value+='" & ChkString(rs("M_NAME"),"display") & "'; window.close()""></a></font></td>" & vbNewLine & _
to have the spnmessagetext class give the correct colors to the links to the names of people. Also probably need to do that the other places that code like this exists. I found it up by 148 which I guess from the code i read is for the search function.
So you get the idea.. gotta go find all the places where there is a link using CColor for the alternating forum colors and make sure you spnMessageText the link to use the right colors for the link.
Now I am really confused. I just got an error inc_functions.asp not found in privateread.asp. Is this possibly an old release that got released new accidental? (Please dont be offended if its not.) Ill see if I can figure out what functions it looking for and where they are now.
Private read is still using inc_top and inc_functions. :(
Changing them.
Error Type:
Active Server Pages, ASP 0126 (0x80004005)
The include file 'includes/inc_forum_menu.asp' was not found.
/cfm-test/smcforums/privateread.asp, line 92
HUH??
I cant find anything in the forums directory or the pm's release directory that might be this file. Anyone have an idea what I should change that to? taking it out for now to see what happens
On line 125ish of privateread it ChkDate needs changed to ChkDateFormat. (I think, it seems to work for me, I'm hacking this now..)
<img src="icon_posticon.gif" border="0" hspace="3" WIDTH="15" HEIGHT="15"><font color="<% =strForumFontColor %>" face="<% =strDefaultFontFace %>" size="<% =strFooterFontSize %>">Sent - <% =ChkDate(rsMessage("M_SENT")) %> <% =ChkTime(rsMessage("M_SENT")) %></font>
OOOOOOOOHHHHHHHHHHHHHHHHHH now I get it.
The privatread is someoens private system version of privateread. Thats why there was that weird include. Cuz now there is a link to the skeptics forum in this code. :PP
I guess this mode wasnt completed. :(
|
<>< |
|
|
|
@tomic
Senior Member
USA
1790 Posts |
Posted - 27 August 2002 : 02:24:00
|
How odd, I wonder where that stuff came from. I just downloaded the MOD from Richard's site and started over. I think I accidently saved an incorrect file. I will go over it and get the right on in there and take care of the other issues you mentioned.
@tomic |
SportsBettingAcumen.com |
|
|
|
@tomic
Senior Member
USA
1790 Posts |
Posted - 27 August 2002 : 02:58:24
|
Actually it needs more than what you mentioned. I need to use strImageURL and the iconfiles.asp page.
@tomic |
SportsBettingAcumen.com |
|
|
|
@tomic
Senior Member
USA
1790 Posts |
Posted - 27 August 2002 : 04:29:06
|
The file has been updated with these fixes except for the preferences.
@tomic |
SportsBettingAcumen.com |
|
|
|
Alergy
Starting Member
United Kingdom
11 Posts |
Posted - 27 August 2002 : 09:24:01
|
quote:
The file has been updated with these fixes except for the preferences.
Sorry to sound like a n00b but does this mean that the PM MOD has been updated for 3.4.01? (I've seen the topics that say wait a while, but the above quote was confusing me) Or is it a matter of working through the MOD code and working out how it should be applied to the new version?
Regards,
Ali
P.s. just implemented snitz on my site and really really pleased with it - it's great work, thanks!  |
Edited by - Alergy on 27 August 2002 09:30:27 |
|
|
|
@tomic
Senior Member
USA
1790 Posts |
Posted - 27 August 2002 : 09:53:17
|
I have replaced the file I accidently overwrote and checked the rest out and it seems to all work fine on 3.4.01
@tomic |
SportsBettingAcumen.com |
|
|
|
HuwR
Forum Admin
United Kingdom
20584 Posts |
Posted - 27 August 2002 : 09:57:22
|
| why don't you just wait for Richard to release an update |
|
|
|
Carefree
Advanced Member
Philippines
4207 Posts |
Posted - 27 August 2002 : 10:02:08
|
| Because, HuwR, Richard bowed out due to time constraints (in another message) and @tomic took over the project with his blessings. |
|
|
|
Schwanke
New Member
77 Posts |
Posted - 27 August 2002 : 19:17:17
|
| Thanks for all this. Ill throw it on this evening and give you another critiquie <evil grin> :) |
<>< |
|
|
|
Schwanke
New Member
77 Posts |
Posted - 27 August 2002 : 21:11:04
|
Umm. The colors still arent right :( I downloaded the new set and they all function properly so I know I got your newer release but the colors are still not using the <span class=""spnMessageText"">insert link here</span> like it should. My contrasting colors makes it all look nasty..
(And you forgot to make the name "so and so's Inbox" in the right color for being on the default background and not on the forum colors. Mine comes out a black on dark blue. This is the reverse bug of the other.)
I'm gunna go change it now, ill make a link to a changed pack file for you to look at it if I can get it to work right.
|
<>< |
|
|
|
Schwanke
New Member
77 Posts |
Posted - 27 August 2002 : 21:36:47
|
Created a zip file with all the 'fixed' colors. (I wasnt sure if you considered a change to using the color variables an optional part or not.) Just includes the files that I changed for anyone that has a contrasting system like I do.
http://www.schwankeweb.net/files/PMModFixes.zip |
<>< |
|
|
| |
Topic |
|
Topic Locked
