| Author |
 Topic  |
|
DJBBIZ
Junior Member
214 Posts |
 Posted - 28 December 2002 : 19:39:20
|
I can't remember offhand exactly what I fixed, I would have to go back to the files, but I downloaded the version that was here so if you compare this version to mine you should find the changes. I am using SQL and maybe that was part of the problem if you are using Access. Sometimes a different approach gives a solution for both. If I get a chance I will do a file compare and jog my memory...too many late nights...too many mods...
99.9% of the mod worked, I just remember making a few tweks its a great mod, thanks |
"The difference between good ideas and good results is performance"
the management institute | tmiFinance | tmiCreative | ProfileOnDemand |
 |
|
|
zbenggg
Junior Member
Israel
227 Posts |
Posted - 28 December 2002 : 19:52:12
|
| WOW !!! |
I love Israel
 |
|
|
|
DJBBIZ
Junior Member
214 Posts |
Posted - 28 December 2002 : 20:16:07
|
You jogged my memory sum and yes the variable in the db file was changed as the old one was not compatible with SQL.
I did not realize the link was in each reply in order to try and see who has seen each individual reply. My thought was as long as the time stamp was there you could see which replies had been seen by the user, but the old method might be easier for the user. What does everybody think? I imagine that when it is in the reply, it only shows the members who have seen it from that point forward and not the list of people having seen it before. Where the spot it is in now just accummulates a total list of viewer. Is this the behavior you have on your forums? |
"The difference between good ideas and good results is performance"
the management institute | tmiFinance | tmiCreative | ProfileOnDemand |
|
|
|
DJBBIZ
Junior Member
214 Posts |
Posted - 28 December 2002 : 21:57:48
|
Well I put the Icon in each reply but the function and query call work like I originally thought they did. They give you a cummulative date order list of all the people who have viewed any part of the topic. In order to see who has read a specific post within that topic you need to look at the date and/or time of the topic post and see if it is before or after the date and/or time of the WHO's Seen This box. This is why I put the function on top as the result was always the same, a list that you compare the dates against to see who has seen which topic.
Now in a perfect world I would like this to tell me who has seen which posts. A cummulative list with breaks along the way, or maybe just the names of the members who have seen this post. In other words when you reply you are the only one on that Who's Seen This list for that reply as noone has visited and read it yet. But the reply topic before that could have a long list of people who have seen everything up to that point. So each reply does the date math for just that reply and not the rest.
For right now the mod works great, it show date and time of the member(s) who have read the topic and you just compare to the time stamp on the reply to see what he/she has read so far.
I will study the possibility of a feature enhancement to give more information at the individual reply button level as well. |
"The difference between good ideas and good results is performance"
the management institute | tmiFinance | tmiCreative | ProfileOnDemand |
|
|
|
Kal Corp
Average Member
USA
878 Posts |
Posted - 31 December 2002 : 01:16:42
|
From i can see the there is nothing different in the first code i created and what you said you updated. every thing is the same for the sql stuff. the only think different is the DSB part that creates the Database tables.
Thanks for the fix.
As for making a link for each reply. yes it was created like that so you can see who viewed what reply. Just go to that reply and hit the link so see who seen the topic and up to what reply they seen. Works great.
Well i glad there was not a code update. I could not find a problem with it, after some people said it didnt work. I tested on SQL, and all of my forums are SQL and the DSB file that someone created for me worked ok for me and others, but just 100% of everyone. maybe the DSB file you gave is better. Thanks again! |
{VAS}-Kal Corp
VAS Development NetWork - Forums for old Snitz Mods!
Creator of all things {VAS}
|
Edited by - Kal Corp on 31 December 2002 01:18:33 |
|
|
|
Jeepers Ron
New Member
USA
95 Posts |
Posted - 31 December 2002 : 11:47:47
|
This part of the code is not working for me
if (rs.EOF or rs.BOF) then '## New config-value
my_conn.execute ("INSERT INTO " & strTablePrefix & "WHOSEEN(WHOSEEN_TOPIC ,WHOSEEN_MEMBER,WHOSEEN_DATE) VALUES (" & Topic_ID & ", " & MemberID &", " & DateToStr(strForumTimeAdjust) & ")")
else
Is there anything I need to do with the '## New config-value |
Jeeper from Michigan
|
|
|
|
DJBBIZ
Junior Member
214 Posts |
Posted - 31 December 2002 : 19:59:57
|
| That should not be an issue, but I think this code is a SQL Server issue, maybe a problem for Access. I use SQL, which db do you have? What error message are you getting? |
"The difference between good ideas and good results is performance"
the management institute | tmiFinance | tmiCreative | ProfileOnDemand |
Edited by - DJBBIZ on 31 December 2002 20:00:50 |
|
|
|
DJBBIZ
Junior Member
214 Posts |
Posted - 01 January 2003 : 00:24:04
|
Hey Kal Corp, I remembered one other thing I needed to change in topic.asp:
this variable:" & DateToStr(strForumTimeAdjust) & "
needed to be enclosed in single quotes like this: '" & DateToStr(strForumTimeAdjust) & "' |
"The difference between good ideas and good results is performance"
the management institute | tmiFinance | tmiCreative | ProfileOnDemand |
|
|
|
Jeepers Ron
New Member
USA
95 Posts |
Posted - 01 January 2003 : 11:40:26
|
quote:
Originally posted by DJBBIZ
That should not be an issue, but I think this code is a SQL Server issue, maybe a problem for Access. I use SQL, which db do you have? What error message are you getting?
First off Happy New Year! 
Now for my problem;
I'm using MS ACCESS so maybe a problem. I'll try to change that variable:" & DateToStr(strForumTimeAdjust) & " When ever I can access my site again 
Funny thing happened this morning with My CuteFTP. My web site is working with all of the files showing up, But when I log in with CuteFTP. All I see is my (cgi-bin) directory and the database file within, no other directories or files are showing up.
Maybe I'll have to try another FTP program 
|
Jeeper from Michigan
|
|
|
|
Jeepers Ron
New Member
USA
95 Posts |
Posted - 01 January 2003 : 13:52:40
|
Okay, I downloaded SmartFTP and I can now see all of my files.
This is the error code I get before changing the MemberID &", " & DateToStr(strForumTimeAdjust) & ")")
Microsoft JET Database Engine error '80040e07'
Data type mismatch in criteria expression.
/test/topic.asp, line 237
------------
And this is after changing to: MemberID &", " & DateToStr(strForumTimeAdjust) & "
Microsoft VBScript compilation error '800a0409'
Unterminated string constant
/test/topic.asp, line 237
my_conn.execute ("INSERT INTO " & strTablePrefix & "WHOSEEN(WHOSEEN_TOPIC ,WHOSEEN_MEMBER,WHOSEEN_DATE) VALUES (" & Topic_ID & ", " & MemberID &", " & DateToStr(strForumTimeAdjust) & "
---------------
Any ideas?
|
Jeeper from Michigan
|
|
|
|
Kal Corp
Average Member
USA
878 Posts |
|
|
DJBBIZ
Junior Member
214 Posts |
Posted - 30 January 2003 : 14:23:48
|
Take a look at my modification above. Try putting in the single quotes around it, I needed this for SQL Server to work.
'" & DateToStr(strForumTimeAdjust) & "' |
"The difference between good ideas and good results is performance"
the management institute | tmiFinance | tmiCreative | ProfileOnDemand |
|
|
|
86atc250r
Starting Member
9 Posts |
Posted - 11 March 2003 : 16:39:12
|
The problem I ran into is the date string is too large to be stored as a long....
I saw someone in this thread had the solution to change the data type to "text", however, that causes a problem when the date is compared (i.e. showing "who's seen this" for responses within threads).
This solution would be fine if the mod were simply doing an "ORDER BY", but since that date is being compared with a >= operator, it needs to be a numeric data type.
It appears that the originator of this mod has solved this problem on his own forum by simply removing the option of seeing who's seen a response to a particular thread by only allowing you to click "who's seen this" on the topic originator (instead of allowing it on all the subsequent responses as this mod was originally written to allow).
After some quick playing around, I came up with a "jerry rigged" solution (This is for MS databases, I don't have a MYSQL db setup for testing) - change the data type of WHOSEEN_DATE in the DB to currency & alter line 52 of pop_whoseen.asp to read
strSql = strSql & " And WHOSEEN_DATE >= " & cCur(Request.QueryString("DATE"))
Hope that all makes sense. This solution, albeit crude, allows enough headroom on the date value for milleniums to come.
A more real (and likely more compatable with other DB's) solution would be to convert the date from a string format to and acutal date/time data type probably using the now() function, however, that would require a bit more re-writing than what I've presented here. |
Edited by - 86atc250r on 11 March 2003 17:48:16 |
|
|
|
DJBBIZ
Junior Member
214 Posts |
Posted - 11 March 2003 : 23:19:18
|
| I have not gone back to study the code closely, but as I understand the Snitz date functions, they are really just integer math in disguise due to the date function incompatable SQL code between Access, SQL Server and MySQL. As such the dates are recorded as 14 digit characters that are then manipulated to determine days and other functions required to get the results. As such I don't think the fact that it is text or in the case of SQL Serve,r NVARCHAR matters. |
"The difference between good ideas and good results is performance"
the management institute | tmiFinance | tmiCreative | ProfileOnDemand |
|
|
|
Kal Corp
Average Member
USA
878 Posts |
Posted - 07 April 2003 : 12:19:02
|
quote:
Originally posted by 86atc250r
It appears that the originator of this mod has solved this problem on his own forum by simply removing the option of seeing who's seen a response to a particular thread by only allowing you to click "who's seen this" on the topic originator (instead of allowing it on all the subsequent responses as this mod was originally written to allow).
?????
Here is my forums and the mod running on it.
http://vasserver.dyndns.org:88/kalsforums/topic.asp?TOPIC_ID=1697
As you can see you can see who view each post and reply
I have been away for sometime and now will be looking at this again. |
{VAS}-Kal Corp
VAS Development NetWork - Forums for old Snitz Mods!
Creator of all things {VAS}
|
|
|
|
Topic |
|
Topic Locked
