Snitz Forums 2000 - BUG+FIX(3.3.03) pop

Snitz Forums 2000

Username:	Password:
Save Password
Forgot your Password?

All Forums

Snitz Forums 2000 DEV-Group

DEV Bug Reports (Closed)

BUG+FIX(3.3.03) pop_porfile.asp missing <td>

Forum Locked

Topic Locked

Printer Friendly

Author

Topic

Nathan
Help Moderator

USA
7664 Posts

Posted - 09 February 2002 : 20:25:57

The problem is here. . . the needed addition is in red.

<%		if strUseExtendedProfile then %>	  
</table>
<table border="0" width="100%" cellspacing="0" cellpadding="3" valign=top>
  <tr>
    <td bgColor="<% =strPageBGColor %>" align=center nowrap>
    <br>
    <font face="<% =strDefaultFontFace %>" size="<% =strDefaultFontSize %>"><a href="JavaScript: onClick= history.go(-1) ">Back to previous page</a></font></p>
    <p> </p>
    </td>
  </tr>
  <tr>
   <td>
<%		else%>
  <tr>
    <td bgColor="<% =strPageBGColor %>" align=center nowrap>
<%
		end if

Nathan Bales - Romans 15:13
---------------------------------
Snitz Exchange | Mod Resource

Davio
Development Team Member

Jamaica
12217 Posts

Posted - 09 February 2002 : 23:29:57

Want to give us some line numbers there Nathan?
And why do you think a <td> tag should be there?

- David

GauravBhabu
Advanced Member

4288 Posts

Posted - 09 February 2002 : 23:56:04

I don't think so. Here is what you need to do...

The following statements - Line Numbers 556 to 581

 
%>	
        </table>		
        </td>
      </tr>
    </table>		
    </td>
  </tr>
  
</table>		
    </td>
  </tr>
<%		if strUseExtendedProfile then %>	  
</table>
<table border="0" width="100%" cellspacing="0" cellpadding="3" valign=top>
  <tr>
    <td bgColor="<% =strPageBGColor %>" align=center nowrap>
    <br>
    <font face="<% =strDefaultFontFace %>" size="<% =strDefaultFontSize %>"><a href="JavaScript: onClick= history.go(-1) ">Back to previous page</a></font></p>
    <p> </p>
    </td>
  </tr>
  <tr>
<%		else%>
  <tr>
    <td bgColor="<% =strPageBGColor %>" align=center nowrap>
<%
		end if

Replace as below

 
%>	
         </table>		
        </td>
       </tr>
      </table>		
     </td>
    </tr>
   </table>		
<%		
if strUseExtendedProfile then %>	  
  <table border="0" width="100%" cellspacing="0" cellpadding="3" valign=top>
   <tr>
    <td bgColor="<% =strPageBGColor %>" align=center nowrap>
    <br>
    <font face="<% =strDefaultFontFace %>" size="<% =strDefaultFontSize %>"><a href="JavaScript: onClick= history.go(-1) ">Back to previous page</a></font></p>
    <p> </p>
    </td>
   </tr>
  </table>
<%
end if
%>

www.forumSquare.com - GauravBhabu - It is difficult to IMPROVE on Perfection, There is no harm in Keep Trying.

GauravBhabu
Advanced Member

4288 Posts

Posted - 10 February 2002 : 00:04:06

There are some tags which do not have opening tags and should be removed as shownin in my post above.
I think the extra tags were left where they are because at some point during development the inc_footer.asp and inc_footer_short.asp were mpoved tothe bottom of the file.

Rememeber one set of followeing tags is left open in inc_top.asp/inc-top_short.asp and that closes in inc_footer.asp or inc_footer_short.asp

This is left open in inc_top.asp
<table>
<tr>
<td>

Closes in inc_footer.asp

</td>
</tr>
</table>

www.forumSquare.com - GauravBhabu - It is difficult to IMPROVE on Perfection, There is no harm in Keep Trying.

Nathan
Help Moderator

USA
7664 Posts

Posted - 10 February 2002 : 00:08:28

Line numbers. I should be ashamed of myself 566-582

This chunk of HTML I took from my profile here at snitz.

<table border="0" width="100%" cellspacing="0" cellpadding="3" valign=top>
  <tr>
    <td bgColor="#FEFEFE" align=center nowrap>
    <br>
    <font face="Verdana, Arial, Helvetica" size="2"><a href="JavaScript: onClick= history.go(-1) ">Back to previous page</a></font></p>
    <p> </p>
    </td>
  </tr>
  <tr>
 
    </td>
  </tr>
</table>

You will notice that right after that blank line there is a td close (</td>) that is orphaned. When the forum is set into a larger table (to fit into an existing site) that orphaned </td> sometimes closes a cell in the table that is up one level. (I have come accross this in the help forum twice this week)

If you look at the if structure, you will see that the 'else' statment provides a <td> for the non extended profile, but no <td> is provided for the extended profile.

Nathan Bales - Romans 15:13
---------------------------------
Snitz Exchange | Mod Resource

<edit> forgot, you have to put a space in there or else the blank line will close itself.

</edit>

Edited by - Nathan on 10 February 2002 01:31:55

GauravBhabu
Advanced Member

4288 Posts

Posted - 10 February 2002 : 00:31:11

The tags shown inred which need to be closed at the end of
Select case staement for "display"

Line Numbers 126 - 154


<table border="0" width="100%" cellspacing="0" cellpadding="0">
  <tr>
    <td bgColor="<% =strPageBGColor %>" align=center  <%= strColspan %>>
    <p align=center><font face="<% =strDefaultFontFace %>" size="<% =strHeaderFontSize %>">User Profile<br></font></p>
    </td>
  </tr>
  
 <tr>
    <td bgColor="<% =strPageBGColor %>" align=center <%= strColspan %>>
    <table border="0" width="90%" cellspacing="0" cellpadding="4" align=center>
      <tr><%		if mLev = 4 then %>
        <td valign=top align=left bgcolor="<% =strHeadCellColor %>"> <a href="pop_profile.asp?mode=Modify&ID=<% =rs("MEMBER_ID") %>&name=<% =ChkString(rs("M_NAME"),"urlpath") %>"><font face="<% =strDefaultFontFace %>" size="<% =strDefaultFontSize %>" color="<% =strHeadFontColor %>"><b><% =ChkString(rs("M_NAME"),"display") %></a></b></font></td>
<%		else %>				
        <td valign=top align=left bgcolor="<% =strHeadCellColor %>"><font face="<% =strDefaultFontFace %>" size="<% =strDefaultFontSize %>" color="<% =strHeadFontColor %>"><b> <% =ChkString(rs("M_NAME"),"display")  %></b></font></td>
<%		end if%>
        <td valign=top align=right bgcolor="<% =strHeadCellColor %>"><font face="<% =strDefaultFontFace %>" size="<% =strDefaultFontSize %>" color="<% =strHeadFontColor %>">Member Since: <% =ChkDate(rs("M_DATE")) %> </font></td>
      </tr>
    </table>
    </td>
  </tr>
  
  
  <tr>
    <td bgcolor="<% =strPageBGColor %>" align=left valign=top>
    <table border="0" width="90%" cellspacing="1" cellpadding="0" align="center">
      <tr>

<%		if strUseExtendedProfile then %>

-----------------------------------
Line Number 556 to 581 need to be modified as below
-----------------------------------



%>		
        </table>----Opening tag on Line 355 		
        </td>-----Opening tag on Line 354 
           
      </tr> ----Open from 152
    </table> ----Open from 151		
    </td> ----Opening tag from 150
  </tr> ----Opening tag from 149
</table> ----Opening tag from 126		
    </td> ----Extra Tag
 </tr>----Extra Tag
<%		if strUseExtendedProfile then %>	  
</table>----Extra Tag
<table border="0" width="100%" cellspacing="0" cellpadding="3" valign=top>
  <tr>
    <td bgColor="<% =strPageBGColor %>" align=center nowrap>
    <br>
    <font face="<% =strDefaultFontFace %>" size="<% =strDefaultFontSize %>"><a href="JavaScript: onClick= history.go(-1) ">Back to previous page</a></font></p>
    <p> </p>
    </td>
  </tr>
  <tr>
</table>---Addition for opening tag on Line 572
----Not required<%		else%>
  <tr>
    <td bgColor="<% =strPageBGColor %>" align=center nowrap>
<%
		end if
%> ----Addition required

www.forumSquare.com - GauravBhabu - It is difficult to IMPROVE on Perfection, There is no harm in Keep Trying.

Edited by - GauravBhabu on 10 February 2002 00:36:46

Nathan
Help Moderator

USA
7664 Posts

Posted - 10 February 2002 : 01:31:24

Gaurav's method is more complete. My way only fixed the bug, but didn't clean up the HTML.

Nathan Bales - Romans 15:13
---------------------------------
Snitz Exchange | Mod Resource

RichardKinser
Snitz Forums Admin

USA
16655 Posts

Posted - 09 March 2002 : 01:22:35

This has been addressed in v3.4

Topic

Forum Locked

Topic Locked

Printer Friendly

Jump To:

Snitz Forums 2000

This page was generated in 0.45 seconds.