Snitz Forums 2000 - BUG: cool links need http:// but don't get checked

Snitz Forums 2000

Username:	Password:
Save Password
Forgot your Password?

All Forums

Snitz Forums 2000 DEV-Group

DEV Bug Reports (Closed)

BUG: cool links need http:// but don't get checked

Forum Locked

Topic Locked

Printer Friendly

Author

Topic

Roland
Advanced Member

Netherlands
9335 Posts

Posted - 21 January 2002 : 15:21:35

As discussed in http://forum.snitz.com/forum/topic.asp?TOPIC_ID=21453 , the cool links in the profile do not get checked for an http:// or https:// suffix and therefore, if those are left out the link will be wrong and useless.
The error checking IS there for the homepage link though.

This should get fixed in upcoming versions. Perhaps it can even be done to have the page check for the suffix and if it's not there automatically insert it?

Thank you very kindly for your time and I await the rush of (off topic) comments with a, for man, unknown feeling of utter desire.

Roland

- here to help when possible -

http://www.frutzle.com
Also for logo requests!

RichardKinser
Snitz Forums Admin

USA
16655 Posts

Posted - 21 January 2002 : 16:03:08

in both register.asp and pop_profile.asp I changed this:

	if (lcase(left(Request.Form("Homepage"), 7)) <> "http://") and (lcase(left(Request.Form("Homepage"), 8)) <> "https://") and (Request.Form("Homepage") <> "") then
		Err_Msg = Err_Msg & "<li>You Must prefix your URL with <b>http://</b> or <b>https://</b></li>"
	end if

to this:

	if (lcase(left(Request.Form("Homepage"), 7)) <> "http://") and (lcase(left(Request.Form("Homepage"), 8)) <> "https://") and (Request.Form("Homepage") <> "") then
		Err_Msg = Err_Msg & "<li>You Must prefix your Homepage URL with <b>http://</b> or <b>https://</b></li>"
	end if
	if (lcase(left(Request.Form("LINK1"), 7)) <> "http://") and (lcase(left(Request.Form("LINK1"), 8)) <> "https://") and (Request.Form("LINK1") <> "") then
		Err_Msg = Err_Msg & "<li>You Must prefix your Cool Links URL with <b>http://</b> or <b>https://</b></li>"
	end if
	if (lcase(left(Request.Form("LINK2"), 7)) <> "http://") and (lcase(left(Request.Form("LINK2"), 8)) <> "https://") and (Request.Form("LINK2") <> "") then
		Err_Msg = Err_Msg & "<li>You Must prefix your Cool Links URL with <b>http://</b> or <b>https://</b></li>"
	end if
	if (lcase(left(Request.Form("Photo_URL"), 7)) <> "http://") and (lcase(left(Request.Form("Photo_URL"), 8)) <> "https://") and (Request.Form("Photo_URL") <> "") then
		Err_Msg = Err_Msg & "<li>You Must prefix your Picture URL with <b>http://</b> or <b>https://</b></li>"
	end if

Roland
Advanced Member

Netherlands
9335 Posts

Posted - 21 January 2002 : 16:33:35

Thanks, I bet I could've done that myself, but this way it's immediately in a forum for everyone else to see.

One more thing I've noticed about a lot of forums:
on the FAQ page the logo won't show in the example for a linkable image. Reason: people use a full URL to the logo and the forum URL is also inserted from the DB. I think that part should be removed as it's not necessary, or there should be some code to check if there's an http:// prefix to the logo URL and then not add the forum URL or something like that.

Sorry to take this slightly OT.

Roland

- here to help when possible -

http://www.frutzle.com
Also for logo requests!

RichardKinser
Snitz Forums Admin

USA
16655 Posts

Posted - 29 January 2002 : 21:50:17

fixed in v3.4

Topic

Forum Locked

Topic Locked

Printer Friendly

Jump To:

Snitz Forums 2000

This page was generated in 0.16 seconds.