Author |
Topic |
SimonT
Junior Member
United Kingdom
202 Posts |
Posted - 14 January 2002 : 14:21:17
|
nomad_2k I get the following error after doing your bug fix
Microsoft JET Database Engine error '80040e14'
Syntax error (missing operator) in query expression 'FORUM_ID ='.
/forum/inc_activeusers.asp, line 376
It might be user error so sorry if I did your codeing wrong here is a link to my inc_activeusers.asp file
http://www.flagball.co.uk/test/inc_activeusers.asp.txt |
|
|
HuwR
Forum Admin
United Kingdom
20584 Posts |
Posted - 14 January 2002 : 14:46:45
|
quote:
I will change it HuwR. I would like to know who asked you to confront me on this, if you will tell me
<edit> thanks nomad I will add you to the contributers list.
Nathan Bales - Romans 15:13 --------------------------------- Snitz Exchange | Mod Resource
Edited by - Nathan on 14 January 2002 13:52:40
Nobody, I just happened to read it, I generally download most mods to take a look at them.
|
|
|
dimitris
Starting Member
8 Posts |
Posted - 14 January 2002 : 16:10:14
|
Thank you. It works.
I think there is a type mismatch in "strOnlienLocation" = strOnlineLocation
quote:
.....
If IsNull(intOnlineForumType) Then strOnlienLocation = "Forum has been deleted!!" Else if ChkForumType(intOnlineForumType) then .... ... ... End If
|
|
|
GauravBhabu
Advanced Member
4288 Posts |
Posted - 14 January 2002 : 17:00:19
|
Here is a modification which will make code shorter and make it easier to manage:
<edit correction>
Add following statement to the top of inc_activeusers.asp at around line 8
Dim intOnlineForumType,strOnlineSubject
Find the following statement Block in inc_activeusers.asp Line 75 to 129
Case "forum.asp" If Request.QueryString("FORUM_ID") <> "" Then set rst = my_conn.execute("SELECT FORUM_ID, F_SUBJECT FROM " & strTablePrefix & "FORUM WHERE FORUM_ID = " & Request.QueryString("FORUM_ID")) Forum_Subject = rst("F_SUBJECT") intOnlineForumType = rst("FORUM_ID") rst.close set rst = nothing if ChkForumType(intOnlineForumType) then strOnlineLocation = "Viewing Topics in: <a href=""link.asp?FORUM_ID=" & Request.QueryString("FORUM_ID") & """>" strOnlineLocation = strOnlineLocation & Forum_Subject else strOnlineLocation = "Viewing: <a href=""link.asp?FORUM_ID=" & Request.QueryString("FORUM_ID") & """>Private Forum" end if end if Case "topic.asp" if Request.QueryString("ARCHIVE") = "true" Then strOnlineLocation = strOnlineLocation & "Viewing Archived Message" else if Request.Querystring("TOPIC_ID") <> "" Then set rst = my_conn.execute("SELECT FORUM_ID,TOPIC_ID, T_SUBJECT FROM " & strTablePrefix & "TOPICS WHERE TOPIC_ID = " & Request.Querystring("TOPIC_ID")) Topic_Subject = rst("T_SUBJECT") intOnlineForumType = rst("FORUM_ID") rst.close set rst = nothing if ChkForumType(intOnlineForumType) then strOnlineLocation = "Viewing Topic: <a href=""link.asp?TOPIC_ID=" & Request.QueryString("TOPIC_ID") & """>" strOnlineLocation = strOnlineLocation & Topic_Subject else strOnlineLocation = "Viewing Topic in: <a href=""link.asp?TOPIC_ID=" & Request.QueryString("TOPIC_ID") & """>Private Forums" end if end if end if Case "post.asp" if Request.QueryString("method") = "Reply" Then set rst = my_conn.execute("SELECT FORUM_ID, TOPIC_ID FROM " & strTablePrefix & "TOPICS WHERE TOPIC_ID = " & Request.Querystring("TOPIC_ID")) intOnlineForumType = rst("FORUM_ID") rst.close set rst = nothing if ChkForumType(intOnlineForumType) then strOnlineLocation = "Replying To Message: <a href=""link.asp?TOPIC_ID=" & Request.QueryString("TOPIC_ID") & """>" & Request.QueryString("Topic_Title") else strOnlineLocation = "Replying To Message in: <a href=""link.asp?TOPIC_ID=" & Request.QueryString("TOPIC_ID") & """>Private Forum" end if elseif Request.QueryString("method") = "Topic" Then intOnlineForumType = Request.QueryString("FORUM_ID") if ChkForumType(intOnlineForumType) then strOnlineLocation = "Posting New Topic in: <a href=""link.asp?FORUM_ID=" & Request.QueryString("FORUM_ID") & """>" & Request.QueryString("Forum_Title") else strOnlineLocation = "Posting New Topic in: <a href=""link.asp?FORUM_ID=" & Request.QueryString("FORUM_ID") & """>Private Forum" end if else strOnlineLocation = strOnlineLocation & "Unknown" end if Case else strOnlineLocation = strOnlineLocation & "Unknown Page"
Replace the above with the statements as below:
Case "forum.asp", "topic.asp", "post.asp" Call GetOnlineLocation() Case else strOnlineLocation = strOnlineLocation & "Unknown Page"
Find the following statement in inc_activeusers.asp function ChkForumType(fForum)
Now add the following code just before the above statement
sub GetOnlineLocation() Select case strOnlinePageName Case "forum.asp" strOnlineLocation = "Viewing Topics in: " Call ProcessOnlineLocation(Request.QueryString("FORUM_ID"),"forum")
Case "topic.asp" if Request.QueryString("ARCHIVE") = "true" Then strOnlineLocation = strOnlineLocation & "Viewing Archived Message" else strOnlineLocation = "Viewing Topic: " Call ProcessOnlineLocation(Request.QueryString("TOPIC_ID"),"topic") end if Case "post.asp" if Request.QueryString("method") = "Reply" Then strOnlineLocation = "Replying To Message : " Call ProcessOnlineLocation(Request.Querystring("TOPIC_ID"),"topic") elseif Request.QueryString("method") = "Topic" Then strOnlineLocation = "Posting New Topic in: " Call ProcessOnlineLocation(Request.QueryString("FORUM_ID"),"forum") else strOnlineLocation = strOnlineLocation end if Case else 'Do Nothing end select end sub
sub ProcessOnlineLocation(intID,strSubjectType) strOnlineSubject = "" intOnlineForumType = "" if strSubjectType = "topic" then set rst = my_conn.execute("SELECT FORUM_ID, TOPIC_ID, T_SUBJECT AS strSubject FROM " & strTablePrefix & "TOPICS WHERE TOPIC_ID = " & intID) elseif strSubjectType = "forum" then set rst = my_conn.execute("SELECT FORUM_ID, F_SUBJECT AS strSubject FROM " & strTablePrefix & "FORUM WHERE FORUM_ID = " & intID) End if if not rst.eof then strOnlineSubject = rst("strSubject") intOnlineForumType = rst("FORUM_ID") if not ChkForumType(intOnlineForumType) then strOnlineSubject = "Private Forum" Select Case strSubjectType Case "topic" strOnlineLocation = strOnlineLocation & "<a href=""link.asp?TOPIC_ID=" & intID & """>" & strOnlineSubject Case "forum" strOnlineLocation = strOnlineLocation & "<a href=""link.asp?FORUM_ID=" & intID & """>" & strOnlineSubject end select else strOnlineLocation = "Forum or Topic not Found or is deleted" end if rst.close set rst = nothing end sub
www.forumSquare.com - GauravBhabu - It is difficult to IMPROVE on Perfection, There is no harm in Keep Trying.
Edited by - GauravBhabu on 14 January 2002 17:50:16 |
|
|
nomad_2k
Junior Member
United Kingdom
173 Posts |
Posted - 14 January 2002 : 17:44:52
|
GauravBhabu that makes the code easier to manage.
Sorry about the typo in inc_activeusers.asp
|
|
|
Nathan
Help Moderator
USA
7664 Posts |
Posted - 14 January 2002 : 18:08:55
|
Reddneck. . . that error occurs on 3.3final versions of the forum. I am not sure what causes it but it seems to work ok on version 3.3.03
I need to change the compatability listing from 3.3.x to 3.3.03
quote: Nobody, I just happened to read it, I generally download most mods to take a look at them.
Thats cool, it was a result of me not reading the license correctly. Next time rather than posting . . . an email
Grav, Nomad, dimitres, you guys have been busy
Nathan Bales - Romans 15:13 --------------------------------- Snitz Exchange | Mod Resource |
|
|
Reddneck
Starting Member
Canada
7 Posts |
Posted - 14 January 2002 : 18:14:59
|
quote:
Reddneck. . . that error occurs on 3.3final versions of the forum. I am not sure what causes it but it seems to work ok on version 3.3.03
I need to change the compatability listing from 3.3.x to 3.3.03
Hmmmmmm, I upgraded to version 3.3.03 last night and that's what version it says I am running in the Main Forum Configuration screen.........Still no work.....Suggestions?
Thanks again for all your help.
|
|
|
GauravBhabu
Advanced Member
4288 Posts |
Posted - 14 January 2002 : 18:15:48
|
Nathan, Looks like you got a sticky(sleepy) Keyboard.
www.forumSquare.com - GauravBhabu - It is difficult to IMPROVE on Perfection, There is no harm in Keep Trying.
Edited by - GauravBhabu on 14 January 2002 18:16:28 |
|
|
Nathan
Help Moderator
USA
7664 Posts |
Posted - 14 January 2002 : 19:29:34
|
No, I cant blame my sleepyness on my keyboard.
Nathan Bales - Romans 15:13 --------------------------------- Snitz Exchange | Mod Resource |
|
|
HuwR
Forum Admin
United Kingdom
20584 Posts |
Posted - 14 January 2002 : 19:33:43
|
Nathan,
could you start a new topic for this, this ones getting a bit scrambled and long, just include a link to it when you create a new topic and we can lock this one.
|
|
|
Nathan
Help Moderator
USA
7664 Posts |
|
HuwR
Forum Admin
United Kingdom
20584 Posts |
Posted - 14 January 2002 : 19:52:53
|
Okay, If you think it's ready to go in the completed forum, i will move it for you.
|
|
|
Nathan
Help Moderator
USA
7664 Posts |
Posted - 14 January 2002 : 19:56:49
|
I do intent to make a version 4.0 soon which will include some new features and support for Snitz 4.0bx (And backwards compatability to 3.3.03/3.4 hopefully) So with that in mind. . . maybe it had better wait till then.
Nathan Bales - Romans 15:13 --------------------------------- Snitz Exchange | Mod Resource |
|
|
HuwR
Forum Admin
United Kingdom
20584 Posts |
|
Topic |
|