Author |
Topic  |
tteal
Junior Member
 
USA
438 Posts |
Posted - 16 November 2000 : 03:43:32
|
Awesome code! The only issue I see so far is that after 'x' amount of bookmarks, it doesn't "page" like the rest of things....
Has anyone added this code to page or have a fix for it?
Thanks alot for sharing!
Cheers, Tim
http://www.free-guestbook.com |
 |
|
HuwR
Forum Admin
    
United Kingdom
20587 Posts |
Posted - 16 November 2000 : 04:38:23
|
It's supposed to, I'll try and sort it out today.
<font color=blue>'Resistance is futile'</font id=blue>
I've found the problem, I missed out a piece of code. I have removed the file from the link above and will repost later today.
Edited by - huwr on 16 November 2000 05:41:59 |
 |
|
HuwR
Forum Admin
    
United Kingdom
20587 Posts |
Posted - 16 November 2000 : 06:33:45
|
I have fixed the paging and reposted the file at the link above.
at the top of the file, you will need to set bkMarkPageSize = 5 to the number of bookmarks you want displayed.
Could you try bookmarking a topic with more than one page, and tell me wether the page link works, not sure whether it will, it should give you a row of numbers by the bookmark.
<font color=blue>'Resistance is futile'</font id=blue> |
 |
|
tteal
Junior Member
 
USA
438 Posts |
Posted - 16 November 2000 : 09:39:31
|
HuwR, <BLOCKQUOTE id=quote><font size=1 face="Verdana, Arial, Helvetica" id=quote>quote:<hr height=1 noshade id=quote> Could you try bookmarking a topic with more than one page, and tell me wether the page link works, not sure whether it will, it should give you a row of numbers by the bookmark. <hr height=1 noshade id=quote></BLOCKQUOTE id=quote></font id=quote><font face="Verdana, Arial, Helvetica" size=2 id=quote>
Appears to be working just peachy... at least it shows the link for Page 1, 2, 3, etc... I'll let you know and thanks once again.
Cheers, Tim
http://www.free-guestbook.com |
 |
|
tteal
Junior Member
 
USA
438 Posts |
Posted - 16 November 2000 : 10:19:27
|
When the topic has more then one page, I tried it for you and got this error:
<BLOCKQUOTE id=quote><font size=1 face="Verdana, Arial, Helvetica" id=quote>quote:<hr height=1 noshade id=quote> Microsoft OLE DB Provider for ODBC Drivers (0x80040E14) [Microsoft][ODBC SQL Server Driver][SQL Server]Incorrect syntax near the keyword 'AND'. inc_functions.asp, line 1081 <hr height=1 noshade id=quote></BLOCKQUOTE id=quote></font id=quote><font face="Verdana, Arial, Helvetica" size=2 id=quote>
Also, the table layout for "DELETE" appears different ... slightly. Although all you have to add is the <td> and that fixes it.
Also... would be a great idea to be able to move through the recordset on the first and last record automatically. If someone has 300 bookmarks set, it could take quite a while to get to the last one saved :) Just a thought.
I just thought of another idea... it would be great to either have a link or have a box where if you checked the box, it would "MARK" all of the box's for you so you can delete all of the saved bookmarks at one time.
Maybe add a case statement like: <pre id=code><font face=courier size=2 id=code> Select Case Request.QueryString("mode") Case "deleteall" strTopic = Request.QueryString("id") testSql ="DELETE FROM FORUM_Bookmarks WHERE B_MemberID=" & getmemberID(strDBNTUserName) rs.Open testSql, my_Conn If rs.BOF or rs.EOF Then Response.Write "You currently have no bookmarks defined" Response.end my_conn.Execute (insSql) End If </font id=code></pre id=code> That was just a quick glance and I haven't thoroughly looked at any code and wish I had the time! arggg!!!
Cheers, Tim
http://www.free-guestbook.com
Edited by - tteal on 16 November 2000 10:39:43
Edited by - tteal on 16 November 2000 10:42:11
Edited by - huwr on 18 February 2001 09:45:32 |
 |
|
infinity
New Member

New Zealand
90 Posts |
Posted - 19 November 2000 : 21:01:32
|
Nice mod people.
I get an error if there are no bookmarks defined and the person goes to the bookmarks page... ------------- ADODB.Recordset error '800a0bcd'
Either BOF or EOF is True, or the current record has been deleted. Requested operation requires a current record.
/bookmark.asp, line 87 ------------------
Any way to get around this? I thought one way to fix this would be to put an IF THEN on the actual "view your bookmarks" link so that it only shows if they actually have some. But maybe a better way to fix this is to do something in the bookmarks.asp page that says "you have no bookmarks etc" if they have none.
Anyone able to show me the code to fix this prob?
Regards,
Infinity
Life is but a dream... and that dream is Here and Now. Therefore, Be here Now. |
 |
|
infinity
New Member

New Zealand
90 Posts |
Posted - 19 November 2000 : 21:20:03
|
Hi, Another small issue
What do I need to do to get this mod to return the person to the page they actually bookmarked rather then to the default.asp page? Or, maybe it would be better to in fact let the person select if they wish to return to the page they came from or the entry page, rather than the automatic redirct?
Any ideas?
Regards, Infinity
Life is but a dream... and that dream is Here and Now. Therefore, Be here Now. |
 |
|
HuwR
Forum Admin
    
United Kingdom
20587 Posts |
Posted - 21 November 2000 : 12:45:04
|
<BLOCKQUOTE id=quote><font size=1 face="Verdana, Arial, Helvetica" id=quote>quote:<hr height=1 noshade id=quote> Nice mod people.
I get an error if there are no bookmarks defined and the person goes to the bookmarks page... ------------- ADODB.Recordset error '800a0bcd' <hr height=1 noshade id=quote></BLOCKQUOTE id=quote></font id=quote><font face="Verdana, Arial, Helvetica" size=2 id=quote>
This should be fixed now, download again, if not fixed, let me know
<font color=blue>'Resistance is futile'</font id=blue> |
 |
|
HuwR
Forum Admin
    
United Kingdom
20587 Posts |
Posted - 21 November 2000 : 14:11:55
|
<BLOCKQUOTE id=quote><font size=1 face="Verdana, Arial, Helvetica" id=quote>quote:<hr height=1 noshade id=quote> Hi, Another small issue
What do I need to do to get this mod to return the person to the page they actually bookmarked rather then to the default.asp page? Or, maybe it would be better to in fact let the person select if they wish to return to the page they came from or the entry page, rather than the automatic redirct?
Any ideas? <hr height=1 noshade id=quote></BLOCKQUOTE id=quote></font id=quote><font face="Verdana, Arial, Helvetica" size=2 id=quote>
Now fixed in above link. Was not working before. Also added ability to delete all, and move directly to first or last page
<font color=blue>'Resistance is futile'</font id=blue> |
 |
|
infinity
New Member

New Zealand
90 Posts |
Posted - 21 November 2000 : 15:54:59
|
YOu beaut... Thanks HawR... much appreciated. Works nicely now.
Tell me,,, has anyone found (or made) and nice Icon for this?
Infinity
Life is but a dream... and that dream is Here and Now. Therefore, Be here Now. |
 |
|
HuwR
Forum Admin
    
United Kingdom
20587 Posts |
Posted - 21 November 2000 : 16:32:20
|
No but that would be nice, my graphics are bad to say the least<img src=icon_smile.gif border=0 align=middle>
<font color=blue>'Resistance is futile'</font id=blue> |
 |
|
Davio
Development Team Member
    
Jamaica
12217 Posts |
Posted - 23 November 2000 : 20:47:47
|
Well, i found an icon that could be used for the bookmark mod. I'm no graphics expert but I did what i could.
<img src="http://www.dsilvera.com/forum/icon_bookmark.gif" border=0>
If you want the original icon i found and edit it yourself let me know. The original is in .psp format since I use Paint Shop Pro. That way I can keep it in 16 million colors then save it as a .gif which uses 256 colors. You can right click on the icon above and save it to your computer.
<center><font color=green>*----*----*----*----*----*----*----*----*----*----*----* <font size=2>"However, if you suffer as a Christian, do not be ashamed, but praise God that you bear that name."</font id=size2> 1 Peter 4:16</font id=green></center> |
 |
|
tteal
Junior Member
 
USA
438 Posts |
Posted - 24 November 2000 : 06:19:08
|
Hi, Only problem I'm still having is the "jump to page" and getting this error:
<pre id=code><font face=courier size=2 id=code> Microsoft OLE DB Provider for ODBC Drivers (0x80040E14) [Microsoft][ODBC SQL Server Driver][SQL Server]Incorrect syntax near the keyword 'AND'. /newforum/inc_functions.asp, line 1081
</font id=code></pre id=code>
Cheers, Tim
http://www.free-guestbook.com
Edited by - tteal on 24 November 2000 06:19:26
Edited by - tteal on 24 November 2000 06:19:46 |
 |
|
HuwR
Forum Admin
    
United Kingdom
20587 Posts |
Posted - 24 November 2000 : 08:48:47
|
<BLOCKQUOTE id=quote><font size=1 face="Verdana, Arial, Helvetica" id=quote>quote:<hr height=1 noshade id=quote> Well, i found an icon that could be used for the bookmark mod. I'm no graphics expert but I did what i could.
<img src="http://www.dsilvera.com/forum/icon_bookmark.gif" border=0>
If you want the original icon i found and edit it yourself let me know. The original is in .psp format since I use Paint Shop Pro. That way I can keep it in 16 million colors then save it as a .gif which uses 256 colors. You can right click on the icon above and save it to your computer.
<hr height=1 noshade id=quote></BLOCKQUOTE id=quote></font id=quote><font face="Verdana, Arial, Helvetica" size=2 id=quote>
Brilliant thanks, I'll stick it in the code if I get chance leter today.
<font color=blue>'Resistance is futile'</font id=blue> |
 |
|
HuwR
Forum Admin
    
United Kingdom
20587 Posts |
Posted - 24 November 2000 : 08:54:31
|
<BLOCKQUOTE id=quote><font size=1 face="Verdana, Arial, Helvetica" id=quote>quote:<hr height=1 noshade id=quote> Hi, Only problem I'm still having is the "jump to page" and getting this error:
<pre id=code><font face=courier size=2 id=code> Microsoft OLE DB Provider for ODBC Drivers (0x80040E14) [Microsoft][ODBC SQL Server Driver][SQL Server]Incorrect syntax near the keyword 'AND'. /newforum/inc_functions.asp, line 1081
</font id=code></pre id=code> <hr height=1 noshade id=quote></BLOCKQUOTE id=quote></font id=quote><font face="Verdana, Arial, Helvetica" size=2 id=quote>
This looks like the function chkForumModerator is not being sent the forum ID?
Does this go away if you remove the bookmark code ?
<font color=blue>'Resistance is futile'</font id=blue> |
 |
|
Topic  |
|