| Author |
 Topic  |
|
|
pcguy
Starting Member
42 Posts |
 Posted - 06 November 2001 : 21:31:38
|
The bad word filter seems to work only in the message, allowing bad words in the subject to pass through unchecked.
Can anyone confirm? Fix?
|
|
|
RichardKinser
Snitz Forums Admin
USA
16655 Posts |
Posted - 06 November 2001 : 22:06:45
|
What I did to fix it here was the following:
in inc_functions.asp on line #407 find this:
chkBadWords(fString)
replace it with:
if strBadWordFilter = "1" then
fString = chkBadWords(fString)
end if
Then on line #447 find this:
if fField_Type = "display" then
if strAllowHTML <> "1" then
fString = HTMLEncode(fString)
end if
chkString = fString
exit function
insert the following on line #451 (just above the chkString = fString line):
if strBadWordFilter = "1" then
fString = chkBadWords(fString)
end if
so it now looks like this:
if fField_Type = "display" then
if strAllowHTML <> "1" then
fString = HTMLEncode(fString)
end if
if strBadWordFilter = "1" then
fString = chkBadWords(fString)
end if
chkString = fString
exit function |
 |
|
|
RichardKinser
Snitz Forums Admin
USA
16655 Posts |
Posted - 06 November 2001 : 22:07:34
|
| Can you try it out and see if it works for you? If so, I'll label it as a fix. |
|
|
|
Capt_Dunzell
Junior Member
USA
160 Posts |
Posted - 07 November 2001 : 00:25:54
|
It worked out for me Richard, good timing too, I was just about to ask about this issue when it showed up with a fix. 
http://66.34.117.92/forum/ |
|
|
|
pcguy
Starting Member
42 Posts |
Posted - 07 November 2001 : 09:38:05
|
quote:
Can you try it out and see if it works for you? If so, I'll label it as a fix.
What about line 97? (In side function FormatStr(fString)) ???
Also - should it be:
if strBadWordFilter = 1 then
or
if strBadWordFilter = "1" then ????
Thanks-
Edited by - pcguy on 07 November 2001 09:41:02 |
|
|
|
RichardKinser
Snitz Forums Admin
USA
16655 Posts |
Posted - 07 November 2001 : 13:20:51
|
quote:
What about line 97? (In side function FormatStr(fString)) ???
FormatStr isn't used to display the Subject lines, chkString is.
quote:
Also - should it be:
if strBadWordFilter = 1 then
or
if strBadWordFilter = "1" then ????
Both seem to work. |
|
|
|
Da_Stimulator
DEV Team Forum Moderator
USA
3373 Posts |
Posted - 07 November 2001 : 15:39:32
|
fixed in 3.4
---------------
-Da_Stimulator
Stims Snitz Test area - Running 3.3.03, 4 beta, and Huw's modified code
Need a Mod? Check out the Mod Resource |
|
|
|
Davio
Development Team Member
Jamaica
12217 Posts |
Posted - 07 November 2001 : 15:49:48
|
quote:
Also - should it be:
if strBadWordFilter = 1 then
or
if strBadWordFilter = "1" then ????
I would use:strBadWordFilter = "1" then just to make sure it won't break.
Making a comparison between a string and an integer could lead to some unwanted results.
- David |
|
|
|
Da_Stimulator
DEV Team Forum Moderator
USA
3373 Posts |
Posted - 07 November 2001 : 15:55:17
|
I changed it to
if strBadWordFilter = 1 or strBadWordFilter = "1" then
Because I've come across problems myself with this, it works both ways :P
---------------
-Da_Stimulator
Stims Snitz Test area - Running 3.3.03, 4 beta, and Huw's modified code
Need a Mod? Check out the Mod Resource |
|
|
|
RichardKinser
Snitz Forums Admin
USA
16655 Posts |
Posted - 15 November 2001 : 06:34:39
|
it should be:
if strBadWordFilter = "1" then |
|
|
|
Deleted
deleted
4116 Posts |
Posted - 24 November 2001 : 12:41:37
|
Fixed (and re-fixed - see topic 17762) in [v40b03patch001]...
Think Pink
Test Site not ready yet | Post v40b03 Patches |
|
|
| |
Topic |
|
Forum Locked
Topic Locked
