| Author |
 Topic  |
|
|
aiken
Starting Member
28 Posts |
 Posted - 07 August 2001 : 16:12:44
|
I'm working on integrating snitz with an existing DB with around 300,000 users in it (I don't expect more than a few thousand to actually use the forum software).
admin_count doesn't like that # of users, and gets an overflow error in line 335:
strSql = strSql & " SET U_COUNT = " & cint(RS("Countof"))
The fix is to change that to read:
strSql = strSql & " SET U_COUNT = " & cdbl(RS("Countof"))
Cheers
-b
Edited by - aiken on 07 August 2001 16:56:31
Edited by - aiken on 07 August 2001 22:52:25 |
|
|
HuwR
Forum Admin
United Kingdom
20595 Posts |
Posted - 07 August 2001 : 16:22:19
|
quote:
I'm working on integrating snitz with an existing DB with around 300,000 users in it (I don't expect more than a few thousand to actually use the forum software).
admin_count doesn't like that # of users, and gets an overflow error in line 335:
strSql = strSql & " SET U_COUNT = " & cint(RS("Countof"))
The fix is to change that to read:
strSql = strSql & " SET U_COUNT = " & cdbl(RS("Countof"))
Cheers
-b
The correct fix would actually be to use cLng, since it is not a floating point number
|
 |
|
|
aiken
Starting Member
28 Posts |
Posted - 07 August 2001 : 16:32:40
|
Oops. You're quite right.
-b
|
|
|
|
aiken
Starting Member
28 Posts |
Posted - 07 August 2001 : 22:51:49
|
Another one:
In pop_delete.asp, line 672. Original:
if cint(rsCheck("MEMBER_ID")) = cint(rsCheck("R_AUTHOR")) then
Fixed:
if clng(rsCheck("MEMBER_ID")) = clng(rsCheck("R_AUTHOR")) then
Cheers
-b
|
|
|
|
aiken
Starting Member
28 Posts |
Posted - 08 August 2001 : 00:18:20
|
Ok, two more, which are more severe:
admin_emaillist.asp and search.asp both enumerate every user into either an HTML table or a <select> box. 50,000 usernames in a select box is just entirely too much, and takes quite a while to download, even over DSL.
I'm thinking that the best solution is to have some kind of "many users" flag, which when set to true causes this kind of operation to use a text box along the lines of "username begins with: ", or even "username exactly matches: ".
Cheers
-b
|
|
|
|
gor
Retired Admin
Netherlands
5511 Posts |
Posted - 08 August 2001 : 00:42:32
|
You'll find problems like this in more places:
Try the search page (selectbox with all members), or assigning a moderatr, I think even the members page will go nuts with 300,000 members because with 25 members a page it would create a dropbox with 12,000 items
Then again, this thing has never been tested with or really been designed for a database with that many users in it.
I'm changing the topic title to DR (design request), because I don't really consider it a bug, but things like "changing cint to clng" can easely be implemented (and that will be done).
Pierre
Join a Snitz Mailinglist |
|
|
|
work mule
Senior Member
USA
1358 Posts |
Posted - 08 August 2001 : 00:49:59
|
quote:
Ok, two more, which are more severe:
admin_emaillist.asp and search.asp both enumerate every user into either an HTML table or a <select> box. 50,000 usernames in a select box is just entirely too much, and takes quite a while to download, even over DSL.
I'm thinking that the best solution is to have some kind of "many users" flag, which when set to true causes this kind of operation to use a text box along the lines of "username begins with: ", or even "username exactly matches: ".
Cheers
-b
I would have to agree with the search.asp page. Why take the hit of loading every member's name in the select box for every visit to the page? It may not be necessary. It would be interesting to know how many searches are made where a member's name is selected.
From personal experience, when I've wanted to search for posts by a particular member, I could have typed the name (or copy and pasted) faster than I could scroll through the entire list and select the name. Also, changing it to a text field and allowing people to type in more than one name would be useful.
The drawbacks are that it was quicker to search on the member id of course, however loading in hundreds of members every time the page is loaded probably isn't good for performance either.
My two cents. 
The Work Mule Forums
The Writer Community
|
|
|
|
gor
Retired Admin
Netherlands
5511 Posts |
Posted - 08 August 2001 : 02:23:38
|
I've been working on the search.asp page, since I couldn't get the supersearch MOD to work here.
Replacing it with a textbox makes it load much faster.
Pierre
Join a Snitz Mailinglist |
|
|
|
Davio
Development Team Member
Jamaica
12217 Posts |
Posted - 23 November 2001 : 14:55:21
|
Thoughts on changing CInt to CLng in those pages mentioned above?
- David |
|
|
|
RichardKinser
Snitz Forums Admin
USA
16655 Posts |
Posted - 09 March 2002 : 01:48:36
|
we've addressed this by using cLng where needed.
fixed in v3.4 |
|
|
| |
Topic |
|
Forum Locked
Topic Locked
