Author |
Topic |
Jeepaholic
Average Member
USA
697 Posts |
Posted - 05 August 2001 : 07:02:43
|
...unless you're logged in as Admin.
Scenario:
* Archive some posts in a forum * Click on the archive link for that forum * View one of the posts while logged in as Admin (make sure it's a post with some replies to it) You will notice that all posts are shown as they should be
* Click the logout button You will notice that only the first post is shown
* Login as a regular user You will notice that only the first post is shown
* Login again as an admin You will notice that all posts are shown as they should be
Al Bsharah Jeepaholics Anonymous |
|
HuwR
Forum Admin
United Kingdom
20584 Posts |
Posted - 05 August 2001 : 10:11:11
|
A quick fix, until I sort out the archive code. in topic.asp, look for this
if AdminAllowed = 0 then strSql = strSql & " AND (" & strActivePrefix & "REPLY.R_STATUS < "
change it to
if AdminAllowed = 0 and not ArchiveView then strSql = strSql & " AND (" & strActivePrefix & "REPLY.R_STATUS < "
Basically it is not archiving the R_STATUS field, will post some new archive code later.
|
|
|
itsme_rick
Starting Member
USA
14 Posts |
Posted - 05 August 2001 : 16:52:31
|
This fixed caused a Type Mismatch error [string ""] forum/topics.asp line 227 also, I cant seem to find out how to turn on the subscription functions, like the my subscriptions you have at the top of your forum, cant see anywhere to make the icon show up for members to subscribe to a category. i have category selected as top subscription option. any ideas ?
quote:
A quick fix, until I sort out the archive code. in topic.asp, look for this
if AdminAllowed = 0 then strSql = strSql & " AND (" & strActivePrefix & "REPLY.R_STATUS < "
change it to
if AdminAllowed = 0 and not ArchiveView then strSql = strSql & " AND (" & strActivePrefix & "REPLY.R_STATUS < "
Basically it is not archiving the R_STATUS field, will post some new archive code later.
Best Regards, Rick Parker IT Manager |
|
|
HuwR
Forum Admin
United Kingdom
20584 Posts |
Posted - 05 August 2001 : 18:54:04
|
sorry, should have been
if AdminAllowed = 0 and ArchiveView = "" then strSql = strSql & " AND (" & strActivePrefix & "REPLY.R_STATUS < "
What level of subscription to you have set in admin features , and what do you have the category level set to
|
|
|
work mule
Senior Member
USA
1358 Posts |
Posted - 08 August 2001 : 01:01:44
|
I just noticed a smiliar thing in the archives here at Snitz.
Here's my analysis.
I'm just your normal user - so no moderator or admin rights.
So, I click on an archive topic, the topic messages always show. The replies never do, UNLESS there are replies from me. I noticed this in one topic which was supposed to have 18 replies, however it only showed the six replies posted by me. http://forum.snitz.com/forum/topic.asp?ARCHIVE=true&TOPIC_ID=6863
So my guess (without looking) is that somehow my memberid is involved in retrieving the replies?
The Work Mule Forums The Writer Community
|
|
|
gor
Retired Admin
Netherlands
5511 Posts |
|
gor
Retired Admin
Netherlands
5511 Posts |
Posted - 17 August 2001 : 13:21:55
|
work mule, try if you can see the archived replies here at the site now.
Huw was correct, the R_STATUS value wasn't copied to the archive table when replies were archived. That caused the field to be NULL all the time. You could see the topics because the status of the topic gets set to 0 (locked) when it gets copied to the archive table.
One question:
At the moment even topics that are on hold or haven't been approved get archived. That makes them visible. Shouldn't the archive function filter those out ? (my suggestion would be to do so).
Pierre Join a Snitz Mailinglist |
|
|
gor
Retired Admin
Netherlands
5511 Posts |
Posted - 17 August 2001 : 13:45:58
|
FIX:
in admin_forum.asp chang line 544 - 549 to: strsqlvalues = "" & drs("CAT_ID") & ", " & drs("FORUM_ID") & ", " & drs("TOPIC_ID") & ", " & drs("REPLY_ID") strsqlvalues = strsqlvalues & ", " & drs("R_AUTHOR") & ", '" & chkstring(drs("R_MESSAGE"),"archive") strsqlvalues = strsqlvalues & "', '" & drs("R_DATE") & "', '" & drs("R_IP") & "'" & ", " & drs("R_STATUS") & " " strsql = "INSERT INTO " & strArchiveTablePrefix & "REPLY (CAT_ID, FORUM_ID, TOPIC_ID, REPLY_ID, R_AUTHOR, R_MESSAGE, R_DATE, R_IP, R_STATUS)" strsql = strsql & " VALUES (" & strsqlvalues & ")"
I'll add a Sql statement to setup.asp to update existing replies: strSql = " UPDATE " & strArchiveTablePrefix & "REPLY " &_ " SET R_STATUS = 0 " & _ " WHERE (R_STATUS IS NULL) "
Pierre Join a Snitz Mailinglist |
|
|
tomasalsbro
Average Member
Sweden
818 Posts |
Posted - 17 August 2001 : 18:09:19
|
quote:
...... I'll add a Sql statement to setup.asp to update existing replies: strSql = " UPDATE " & strArchiveTablePrefix & "REPLY " &_ " SET R_STATUS = 0 " & _ " WHERE (R_STATUS IS NULL) "
Pierre Join a Snitz Mailinglist
Pierre, where did you inserted the Sql statement? Which line? Tomas
!-Keep distance in traffic-! www.whiplash.se www.whiplash.pp.se |
|
|
gor
Retired Admin
Netherlands
5511 Posts |
Posted - 17 August 2001 : 18:12:44
|
quote:
quote:
...... I'll add a Sql statement to setup.asp to update existing replies: strSql = " UPDATE " & strArchiveTablePrefix & "REPLY " &_ " SET R_STATUS = 0 " & _ " WHERE (R_STATUS IS NULL) "
Pierre, where did you inserted the Sql statement? Which line? Tomas
Can't give you a line-number for that yet, since it is part of the upgrade script that will upgrade previous versions to 3.3.03 I fixed the database here at the site by just executing the query against the database (you can do that with i.e. Tableeditor).
Pierre Join a Snitz Mailinglist |
|
|
tomasalsbro
Average Member
Sweden
818 Posts |
Posted - 17 August 2001 : 18:16:35
|
OK Gor, by the way - when you answered my question and posted - did you got stucked in a pendling back and forwards to the same place again? I was and it point to a probably bug in post_info.asp. Tomas
!-Keep distance in traffic-! www.whiplash.se www.whiplash.pp.se |
|
|
gor
Retired Admin
Netherlands
5511 Posts |
Posted - 17 August 2001 : 18:32:03
|
quote:
OK Gor, by the way - when you answered my question and posted - did you got stucked in a pendling back and forwards to the same place again? I was and it point to a probably bug in post_info.asp. Tomas
No, had no problems posting.....
Pierre Join a Snitz Mailinglist |
|
|
tomasalsbro
Average Member
Sweden
818 Posts |
Posted - 17 August 2001 : 18:53:00
|
Strange - I was stucked in a endless refresh of that side! Tomas
!-Keep distance in traffic-! www.whiplash.se www.whiplash.pp.se |
|
|
Deleted
deleted
4116 Posts |
|
gor
Retired Admin
Netherlands
5511 Posts |
Posted - 18 August 2001 : 01:08:55
|
Probably, I'm going to close this topic if someone can confirm the problem Jeepaholic mentioned is gone. Please start another topic for the other problem if it can be re-created.
Pierre Join a Snitz Mailinglist |
|
|
RichardKinser
Snitz Forums Admin
USA
16655 Posts |
Posted - 18 August 2001 : 01:11:13
|
Gor, yes, this problem appears to be fixed. |
|
|
Topic |
|