Snitz Forums 2000
Snitz Forums 2000
Home | Profile | Register | Active Topics | Members | Search | FAQ
Username:
Password:
Save Password
Forgot your Password?

 All Forums
 Snitz Forums 2000 DEV-Group
 DEV Bug Reports (Closed)
 V33(.02) BUG+FIX Feature NT Config not saved
 Forum Locked  Topic Locked
 Printer Friendly
Author Previous Topic Topic Next Topic  

Kal Corp
Average Member

USA
878 Posts

Posted - 26 July 2001 :  19:54:55  Show Profile  Visit Kal Corp's Homepage
Feature NT Configuration options not saved afer change

gor
Retired Admin

Netherlands
5511 Posts

Posted - 27 July 2001 :  01:05:53  Show Profile  Visit gor's Homepage
That is because there are no initial values for STRAUTOLOGON and STRNTGROUPS in CONFIG_NEW

Changes needed:

in setup.asp line 2282 add:

my_Conn.execute ("INSERT INTO " & strTablePrefix & "CONFIG_NEW (C_VALUE,C_VARIABLE) VALUES ('" & ChkString(rs("C_STRNTGROUPS"), "SQLString") & "' , 'STRNTGROUPS')")
my_Conn.execute ("INSERT INTO " & strTablePrefix & "CONFIG_NEW (C_VALUE,C_VARIABLE) VALUES ('" & ChkString(rs("C_STRAUTOLOGON"), "SQLString") & "' , 'STRAUTOLOGON')")


in the default Access database the two records are allready there, so no changes needed.

in inc_create_forums_mysql.asp (line 436), inc_create_forums_sql6.asp (line 562) and inc_create_forums_sql7.asp (line 562) add these lines:

my_Conn.execute ("INSERT INTO " & strTablePrefix & "CONFIG_NEW(C_VALUE,C_VARIABLE) VALUES('0', 'STRNTGROUPS')")
my_Conn.execute ("INSERT INTO " & strTablePrefix & "CONFIG_NEW(C_VALUE,C_VARIABLE) VALUES('0', 'STRAUTOLOGON')")




Pierre
Join a Snitz Mailinglist
Go to Top of Page

Kal Corp
Average Member

USA
878 Posts

Posted - 27 July 2001 :  08:53:42  Show Profile  Visit Kal Corp's Homepage


Go to Top of Page

mclek
New Member

Australia
50 Posts

Posted - 29 July 2001 :  22:11:18  Show Profile
Please note that there was a typo in the fix, so the auto logon feature still doesn't save.

The line should read:


my_Conn.execute ("INSERT INTO " & strTablePrefix & "CONFIG_NEW(C_VALUE,C_VARIABLE) VALUES('0', 'STRAUTOLOGON')")


Thanks,
Kym.


Go to Top of Page

gor
Retired Admin

Netherlands
5511 Posts

Posted - 30 July 2001 :  04:08:13  Show Profile  Visit gor's Homepage
You're correct, fixing reply....

BTW, the inc_create_forum_sqlx.asp in version 3.3.02 have the same typo !!

Pierre
Join a Snitz Mailinglist
Go to Top of Page

BugLaden
Starting Member

45 Posts

Posted - 30 July 2001 :  08:02:33  Show Profile  Visit BugLaden's Homepage  Send BugLaden an AOL message
So if setup was already run can we just load setup.asp again? Otherwise how do we implement this fix in an already installed upgrade?

-=BugLaden
CCG Workshop Developer
http://www.ccgworkshop.com

Edited by - Bugladen on 30 July 2001 08:09:31
Go to Top of Page

gor
Retired Admin

Netherlands
5511 Posts

Posted - 30 July 2001 :  09:05:42  Show Profile  Visit gor's Homepage
quote:

So if setup was already run can we just load setup.asp again? Otherwise how do we implement this fix in an already installed upgrade?



Yes, that is a problem with the upgrade of CONFIG_NEW (sorry, was a complex change of the forum), if there allready are values in the CONFIG_NEW table it doesn't upgrade them.
This was to avoid having to check for each value if it allready existed.

Quick Fix: Delete all the records in CONFIG_NEW and run setup again.

Better Fix: I'll make sure that in 3.3.03 you can rerun setup.asp without clearing out CONFIG_NEW so that it adds missing values to CONFIG_NEW and leaves existing values alone.


Pierre
Join a Snitz Mailinglist
Go to Top of Page

lelo
Starting Member

7 Posts

Posted - 05 August 2001 :  06:48:50  Show Profile  Send lelo an ICQ Message
Att:
the new realise (3.3.02) in Setup.asp haven't this fix:
quote:
I would consider that a bug, we should have added ChkString() to those lines in setup.asp (starting line 2178)
Like this:

my_Conn.execute ("INSERT INTO " & strTablePrefix & "CONFIG_NEW (C_VALUE,C_VARIABLE) VALUES ('" & ChkString(rs("C_STRVERSION"), "SQLString") & "' , 'STRVERSION')")

That would have prevented that.


Pierre
Join a Snitz Mailinglist


infact u'll fix a Gub with the 2 new line that contents.....
my_Conn.execute ("INSERT INTO " & strTablePrefix & "CONFIG_NEW (C_VALUE,C_VARIABLE) VALUES ('" & ChkString(rs("C_STRNTGROUPS"), "SQLString") & "' , 'STRNTGROUPS')")my_Conn.execute ("INSERT INTO " & strTablePrefix & "CONFIG_NEW (C_VALUE,C_VARIABLE) VALUES ('" & ChkString(rs("C_STRAUTOLOGON"), "SQLString") & "' , 'STRAUTOLOGON')")

Go to Top of Page

gor
Retired Admin

Netherlands
5511 Posts

Posted - 17 August 2001 :  19:16:40  Show Profile  Visit gor's Homepage
Saving of config has been improved in version 3.3.03 code

Pierre
Join a Snitz Mailinglist
Go to Top of Page

gor
Retired Admin

Netherlands
5511 Posts

Posted - 18 August 2001 :  01:25:01  Show Profile  Visit gor's Homepage
quote:

Saving of config has been improved in version 3.3.03 code



Might just explain a bit more:
With the new saving, it first checks if a variable is allready in CONFIG_NEW
If not is adds it, if it is there it overwrites it.
You can also tell it to only add it and not overwrite it when it is allready there. This comes in handy during the upgrade process since that enabled me to add new/missing values but leave them unchanged if someone allready had added them to the database (by hand or using a MOD).
This also makes sure that once a value is set in a ADMIN screen, it really is saved to the database.

Too much codechanges to post the code here, will be in version 3.3.03

Pierre
Join a Snitz Mailinglist
Go to Top of Page
  Previous Topic Topic Next Topic  
 Forum Locked  Topic Locked
 Printer Friendly
Jump To:
Snitz Forums 2000 © 2000-2021 Snitz™ Communications Go To Top Of Page
This page was generated in 0.14 seconds. Powered By: Snitz Forums 2000 Version 3.4.07