Just flicking through post.asp and I notice that getMemberName() is used when popultaing the select inputs for a forum's allowed members and moderators. Surely this could be cleaned up a bit by selecting M_NAME when selecting the MEMBER_ID from the relevant table? I.E., find the following on line 857:strSql = "SELECT MEMBER_ID "
strSql = strSql & " FROM " & strTablePrefix & "MODERATOR "
strSql = strSql & " WHERE FORUM_ID = " & strRqForumID
And modify it to:strSql = "SELECT M1.MEMBER_ID, M2.M_NAME "
strSql = strSql & " FROM " & strTablePrefix & "MODERATOR M1, " & strMembersTablePrefix &" MEMBERS M2 "
strSql = strSql & " WHERE M1.FORUM_ID = " & strRqForumID & " AND M2.MEMBER_ID=M1.MEMBER_ID"
strSql = strSql & " ORDER BY M2.M_NAME ASC"
Do something similar with the SELECT for the allowed members list and M_NAME can now be read in from the arrays created using getRows. Saves a couple of SQL queries. 
Topic Locked
Posted - 12 April 2005 : 07:55:16
